[Koha-devel] Koha 3.8 release schedule & perltidy process

[Laquerre, Anthony]

Hi Paul, all,
We had to do exactly the same kind of process on another project couple of years ago ( in java ) 

We had decided, at that time, to go gradually and the way we did it was always by "function that you touch".

At the end our, QA team ask us to still be able to understand what is the change even if look of the code can be really different.

Anthony


-----Message d'origine-----
De : koha-devel-bounces at lists.koha-community.org [mailto:koha-devel-bounces at lists.koha-community.org] De la part de Paul Poulain
Envoyé : 9 mars 2012 07:46
À : koha-devel at lists.koha-community.org
Objet : Re: [Koha-devel] Koha 3.8 release schedule & perltidy process

Le 09/03/2012 13:36, Eric Bégin a écrit :
> Hello all,
> 
> Have we considered using git's hooks for tidifying the code before 
> checking it in, or even on the server, this would ensure that whoever 
> does the checkin, it will be tidified.
> 
> Also, if we consider going with a global tidifying, a good timing 
> could be when creating a new branch.

(this message is not for Eric specifically) => do you all have read the IRC discussion ?
http://stats.workbuffer.org/irclog/koha/2012-01-04#i_857956

Most of the points raised on this thread have been discussed, side-effect, pro and cons explained.

For the "do it on the fly" path, I could be OK to go with it if I understood how it can be done:
* perltidying only the lines you submit will result in unreadable code
* perltridying a whole file when you submit a patch will result in an unreadable git blame, like the "big bang" perltidy option
* not everybody uses vim

so, how to achieve the "on the fly" path is still a mystery for me
--
Paul POULAIN
http://www.biblibre.com
Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08 _______________________________________________
Koha-devel mailing list
Koha-devel at lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/