[Koha-devel] Signed off patches to the patches list?

Robin Sheat robin at catalyst.net.nz
Fri Sep 14 13:46:24 CEST 2012


No, the point is more that it should be removed because it's no longer really needed as good practice. 

Mark Tompsett <mtompset at hotmail.com> wrote:

>Greetings,
>
>Not that I have gotten to use this a lot, but I was thinking that
>perhaps a 
>reorder tweak and putting that tiny part in a paragraph of its own
>without 
>the text box should be sufficient for people glossing over to skip it.
>I'm 
>not sure you want to lose the information, but rather just hide it in 
>commentary.
>
>--- BEGIN SUGGEST TWEAK ---
>This is also a good moment to open your bug in bugzilla using 
>http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=xxxx url and
>change 
>"Patch status" to "Signed Off
>
>It is still considered good practice to send the signed off patch to
>the 
>patches mailing list, but not required. If you wish to do so, it can be
>done 
>with a single command:
>git send-email  --to 'koha-patches at lists.koha-community.org' 
>origin/master
>This assumes that you have called the remote for the officia Koha repo 
>"origin" and that you have an up-to-date master branch from there.
>-- END SUGGEST TWEAK ---
>
>Those three lines on their own may get skipped, since the "Bugs with
>more 
>than one patch" is a header and bolded. And without the text box,
>there's 
>nothing to draw the eye to it.
>
>GPML,
>Mark Tompsett 
>
>_______________________________________________
>Koha-devel mailing list
>Koha-devel at lists.koha-community.org
>http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>website : http://www.koha-community.org/
>git : http://git.koha-community.org/
>bugs : http://bugs.koha-community.org/

-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-devel/attachments/20120914/1db12a81/attachment.htm>


More information about the Koha-devel mailing list