[Koha-devel] Some patches which need signed off or QA

[Kenza Zaki]

Hi everyone,

I am working for Koha for approximately 3 months as a trainee for Biblibre. Currently, I have submitted 24 patches which 7 of them have been pushed to master:
Bug 10499	VirtualShelves.t needs a database transaction
Bug 10575	GetOrdersbyBiblionumber.t needs a database transaction
Bug 10642	Inappropriate uses of finish() in C4/RotatingCollections.pm
Bug 10643	Inappropriate uses of finish() in C4/ClassSource.pm
Bug 10644	UT : C4/ClassSource.pm needs unit tests
Bug 10653	UT: RotatingCollections.pm needs unit tests
Bug 10761	UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests.

My internship ends next week (august the 30th) and i would really appreciate if most of my patches could be pushed before i leave Biblibre.
Patches which need QA :
Bug 10508	UT:C4/Branch.pm needs unit tests
Bug 10528	UT: C4/Booksellers.pm needs unit tests
Bug 10630	DelBooksellers return values needs to be more explicit in C4/Bookseller.pm
Bug 1064 0	ModBookseller needs more explicit return value in C4/Bookseller.pm
Bug 10641	GetBooksellerLateOrder has some incoherences in C4/Bookseller.pm
Bug 10681	Inappropriate uses of finish() in C4/Circulation.pm
Bug 10692	UT: Routines about transfers in Circulation.pm need unit tests
Bug 10693	CreateBranchTransferLimit in Circulation.pm need more explicit return values
Bug 10699	DeleteBranchTransferLimits in C4/Circulation.pm needs return value

Patches which need Signed off:
Bug 10682	Inappropriate uses of finish() in C4/Reserves.pm
Bug 10685	Inappropriate uses of finish() in C4/Account.pm
Bug 10698	DeleteTransfer in C4::Circulation.pm needs return value
Bug 10710	UT : OfflineOperation's routines in C4/Circulation.t need unit tests
Bug 10711	GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result
Bug 10767	 UT: Routines which interact with the table issuingrules in C4/Circulation need unit test

Patch which needs to be push to master:
Bug 10629	Inappropriate uses of finish() in C4/Branch.pm

Anyway , working for Koha was a great experience to me!

Thanks

Kenza