[Koha-devel] Failed unit test

[Paul Poulain]

Le 11/01/2013 18:08, Bernardo Gonzalez Kriegel a écrit :
> Hello,
> just trying to do a sign-off following
> http://wiki.koha-community.org/wiki/Sign_off_on_patches
> 
> It's ok that some test of
> 
> prove t/
> prove t/db_dependent
those one probably fail because you don't have the expected datas.

> prove xt/author
> fail even in a clean master?

OTOH: signing-off is checking that the feature works fine. It's the QA
team that will be in charge to check unit tests.
(Of course, if a patch contains a unit test itself, you should not
signoff until you've successfully run it ;-) )

HTH

-- 
Paul POULAIN - BibLibre
http://www.biblibre.com
Free & Open Source Softwares for libraries
Koha, Drupal, Piwik, Jasper