[Koha-devel] Pending PDF::Reuse Release And Koha

[Robin Sheat]

Christopher Nighswonger schreef op wo 10-12-2014 om 16:08 [-0500]:
> Ok. I've pushed up PDF::Reuse 0.36 to CPAN, and opened bug 13407 to
> take care of the related code in Koha. Hopefully this brings about 5
> years of waiting to a successful conclusion.

Hi Chris, I had a look at this and it looks like this patch:

Author: Patrick Matth<E4>i <patrick.matthaei at web.de>
Description: avoid warnings about
             "Use of uninitialized value $string in unpack ..."
Bug: #506214
             
--- a/Reuse.pm
+++ b/Reuse.pm
@@ -1281,8 +1281,10 @@
   
    if (ref($PDF::Reuse::Util::font_widths{$Font}) eq 'ARRAY')
    {   my @font_table = @{ $PDF::Reuse::Util::font_widths{$Font} };
-       for (unpack ("C*", $string)) 
-       {  $w += $font_table[$_];       
+       if (defined $string) {
+           for (unpack ("C*", $string)) 
+           {  $w += $font_table[$_];   
+           }
        }
    }
    else

didn't go in. Was that by design?

It doesn't actually apply cleanly:

patching file Reuse.pm
Hunk #1 FAILED at 1281 (different line endings).
1 out of 1 hunk FAILED
dpkg-source: info: the patch has fuzz which is not allowed, or is malformed
dpkg-source: info: if patch 'uninitialized_warning.patch' is correctly applied by quilt, use 'quilt refresh' to update it

though I can probably fix that myself. But it's probably a good thing to
have upstream, assuming it works as claimed.

It'd also be good to sort this, though I expect not urgent:

W: libpdf-reuse-perl: manpage-has-bad-whatis-entry usr/share/man/man3/PDF::Reuse::Util.3pm.gz
N: 
N:    Each manual page should start with a "NAME" section, which lists the
N:    name and a brief description of the page separated by "\-". The "NAME"
N:    section is parsed by lexgrog and used to generate a database that's
N:    queried by commands like apropos and whatis. This tag indicates that
N:    lexgrog was unable to parse the NAME section of this manual page.
N:    
N:    For manual pages that document multiple programs, functions, files, or
N:    other things, the part before "\-" should list each separated by a comma
N:    and a space. Each thing listed must not contain spaces; a man page for a
N:    two-part command like "fs listacl" must use something like "fs_listacl"
N:    in the "NAME" section so that it can be parsed by lexgrog.
N:    
N:    Refer to the lexgrog(1) manual page, the groff_man(7) manual page, and
N:    the groff_mdoc(7) manual page for details.
N:    
N:    Severity: normal, Certainty: certain
N:    
N:    Check: manpages, Type: binary
N: 

Not sure why that didn't show up on the previous run, maybe I overlooked
it.

-- 
Robin Sheat
Catalyst IT Ltd.
✆ +64 4 803 2204
GPG: 5FA7 4B49 1E4D CAA4 4C38  8505 77F5 B724 F871 3BDF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20141216/219602db/attachment.pgp>