[Koha-devel] Pending PDF::Reuse Release And Koha

[Christopher Nighswonger]

On Tue, Dec 16, 2014 at 12:00 AM, Robin Sheat <robin at catalyst.net.nz> wrote:
> Hi Chris, I had a look at this and it looks like this patch:
>
> Author: Patrick Matth<E4>i <patrick.matthaei at web.de>
> Description: avoid warnings about
>              "Use of uninitialized value $string in unpack ..."
> Bug: #506214

>
> didn't go in. Was that by design?

> though I can probably fix that myself. But it's probably a good thing to
> have upstream, assuming it works as claimed.
>

This is fixed in this commit:

https://github.com/cnighswonger/PDF-Reuse/commit/67d699560c08cac8a1cda15a5274b060655899d2

Passing in an empty string in that case makes no sense, so the
solution in the commit seemed a better fix in this case.


> It'd also be good to sort this, though I expect not urgent:
>
> W: libpdf-reuse-perl: manpage-has-bad-whatis-entry usr/share/man/man3/PDF::Reuse::Util.3pm.gz
> N:
> N:    Each manual page should start with a "NAME" section, which lists the
> N:    name and a brief description of the page separated by "\-". The "NAME"
> N:    section is parsed by lexgrog and used to generate a database that's
> N:    queried by commands like apropos and whatis. This tag indicates that
> N:    lexgrog was unable to parse the NAME section of this manual page.

So what are the man pages generated from? I'm not sure where to apply the fix.

Kind Regards,
Chris