[Koha-devel] Suggestion for the "git so" command

[Kyle Hall]

I don't prepend a status to patches for the reasons Barton outlined. The
only time I do is when a patch set is partially signed off. You milage may
vary ; )

Kyle

http://www.kylehall.info
ByWater Solutions ( http://bywatersolutions.com )
Meadville Public Library ( http://www.meadvillelibrary.org )
Crawford County Federated Library System ( http://www.ccfls.org )
Mill Run Technology Solutions ( http://millruntech.com )

On Mon, Feb 1, 2016 at 5:55 PM, Katrin Fischer <Katrin.Fischer.83 at web.de>
wrote:

> I am using a very similar command for adding [PASSED QA] and my sign-off
> line to multiple patches. Found on the wiki some time ago:
> https://wiki.koha-community.org/wiki/Tips_and_tricks
>
> qa2 = "!f() { c=`expr $1 - 1`; git filter-branch -f --msg-filter \"echo
> -n \\\"[PASSED QA] \\\" && cat && echo \\\"\nSigned-off-by: author
> <author at mail.com>\\\"\" HEAD~$c^..; }; f"
>
> Run as:
> git qa2 <number of commits>
> git qa2 5
>
> Then next something like:
> git bz attach <bug number> HEAD~5..
> git bz edit <bug number>
>
> So far I haven't seen any problems with it. Not sure about the effects
> on obsoleting patches.
>
> Katrin
>
>
>
> Am 01.02.2016 um 17:58 schrieb Barton Chittenden:
> > Yes, it's possible
> >
> > Here's what I use:
> >
> > so = "!f() { c=`expr $1 - 1`; git filter-branch -f --msg-filter \"echo
> > -n \\\"[SIGNED-OFF] \\\" && cat && echo \\\"\nSigned-off-by: Barton
> > Chittenden <barton at bywatersolutions.com
> > <mailto:barton at bywatersolutions.com>>\\\"\" HEAD~$c^..; }; f"
> >
> > ... I'm not sure where that came from. It *may* have even come from an
> > earlier version on the wiki... I think that the issue is that git bz
> > attach will automatically obsolete patches that have the same subject
> > line, whereas appending "[SIGNED-OFF]" may break that. Take that with a
> > large grain of salt, test it yourself and maybe run it by the good QA
> folx.
> >
> > --Barton
> >
> >
> >
> > On Mon, Feb 1, 2016 at 11:37 AM, Owen Leonard <oleonard at myacpl.org
> > <mailto:oleonard at myacpl.org>> wrote:
> >
> >     The wiki has a good command for signing off multiple patches at once:
> >
> >
> https://wiki.koha-community.org/wiki/Git_bz_configuration#Signing_off_2
> >
> >     I have a suggestion for an improvement: Prepend "[SIGNED-OFF]" to the
> >     first line of each.
> >
> >     Is that possible?
> >
> >       -- Owen
> >
> >     --
> >     Web Developer
> >     Athens County Public Libraries
> >     http://www.myacpl.org
> >     _______________________________________________
> >     Koha-devel mailing list
> >     Koha-devel at lists.koha-community.org
> >     <mailto:Koha-devel at lists.koha-community.org>
> >     http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> >     website : http://www.koha-community.org/
> >     git : http://git.koha-community.org/
> >     bugs : http://bugs.koha-community.org/
> >
> >
> >
> >
> > _______________________________________________
> > Koha-devel mailing list
> > Koha-devel at lists.koha-community.org
> > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> > website : http://www.koha-community.org/
> > git : http://git.koha-community.org/
> > bugs : http://bugs.koha-community.org/
> >
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20160202/731effa6/attachment.html>