[Koha-devel] NorwegianPatronDB

[Mark Tompsett]

Greetings,

It seems that “$debug && warn” is a popular style used in C4/Member already. I don’t think a system preference is needed. Just a $debug prepend, perhaps?

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795
Sign it off, kill it, suggest a counter-patch, whatever. I do think this addresses the issue.

GPML,
Mark Tompsett


From: David Cook 
Sent: Wednesday, February 10, 2016 6:40 PM
To: 'Philippe Blouin' 
Cc: koha-devel at lists.koha-community.org 
Subject: Re: [Koha-devel] NorwegianPatronDB

I think you’re right, Philippe.

 

I’ve noticed the same thing. In fact, the “Unable to load Koha::NorwegianPatronDB” was added after the fact to stop the absence of those libraries causing Koha to die. 

 

I don’t necessarily see the point of having that warning there though, as most Koha users probably aren’t going to use the NorwegianPatronDB.

 

Maybe that could have a system preference… so the warns (or the dying) only happens when the system preference is set?

 

David Cook

Systems Librarian

Prosentient Systems

72/330 Wattle St, Ultimo, NSW 2007

 

From: koha-devel-bounces at lists.koha-community.org [mailto:koha-devel-bounces at lists.koha-community.org] On Behalf Of Philippe Blouin
Sent: Thursday, 11 February 2016 8:47 AM
To: koha-devel at lists.koha-community.org
Subject: [Koha-devel] NorwegianPatronDB

 

Hi!
I'm working on 3.22.02 and my logs are FILLED with the following warnings:

Members.pm: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/acqui/booksellers.pl
admin-home.pl: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/admin/preferences.pl

I look at the code, and beside wondering why that custom feature is so profoundly imbricated into master Koha, I was wondering what is not working.

So I hacked the code to add verbose => 1 on the can_load call, and found that NorwegianPatronDB was not compiling because it was missing the following libraries:

apt-get -y install libsoap-lite-perl
apt-get -y install libcrypt-gcrypt-perl
apt-get -y install libconvert-basen-perl

Those modules are specified as NOT mandatory in 3.22.  As such, I should not be flooded with Norwegian errors because they are not available, for a module which I and most do not care for.

Or am I getting it wrong?

Thanks
Philippe



--------------------------------------------------------------------------------
_______________________________________________
Koha-devel mailing list
Koha-devel at lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20160210/80d0ef99/attachment-0001.html>