[Koha-devel] git trailers: should we use more of them ?

[Julian Maurice]

I've added a section in
https://wiki.koha-community.org/wiki/Commit_messages to encourage people
adding more informations to commits.
Changing Signed-off-by seems to be a bad idea. So let's do nothing about
this.

What about the QA signoff ? Reviewed-by or not ?

Le 25/09/2018 à 08:04, Renvoize, Martin a écrit :
> I agree to the idea in principle too, adding detail is great.
> 
> I don't have an issue with misusing the signoff line, I've been aware of
> that distinction for a long time. The major advantage of using it for
> our workflow is that it's often the least technical user doing the
> initial signoff and as such having the -s shortcut built into git is a
> nice aid.  I don't see any similar flags for the other options.
> 
> I can see it leading to the opportunity to really improve our history
> and about pages along with more recognition in release notes.
> 
> Just my two pence.
> 
> On Thu, 20 Sep 2018, 6:56 pm Katrin Fischer, <katrin.fischer.83 at web.de
> <mailto:katrin.fischer.83 at web.de>> wrote:
> 
>     I think we'd need to change a lot of things if we switched from
>     Signed-off-by to another - including a lot of documentation. It
>     might add more confusion than doing good imo. But I'd be OK with
>     changing the line for QA to make things more clear if that is what
>     people would like to see. Also using some additional ones like
>     Mentored-by could be useful.
> 
>     Katrin
> 
> 
>     On 19.09.2018 20:51, Tomas Cohen Arazi wrote:
>>     I like the idea of adding more uses. Mentored-by is interesting
>>     information on the QA step, for example.
>>
>>     El mié., 19 sept. 2018 a las 12:39, Owen Leonard
>>     (<oleonard at myacpl.org <mailto:oleonard at myacpl.org>>) escribió:
>>
>>         > > Bit late in the project to make this change imo? But yes, our
>>         > > interpretation is quite different ;)
>>         > But it's never too late to make a positive change, right ? :)
>>
>>         I agree that it's not too late to make useful changes to our
>>         workflow.
>>         There was a time when we didn't even sign off patches!
>>
>>         I'm not concerned that we're using "signed off" in a way that is
>>         nonstandard, but I am interested in adding better information
>>         to our
>>         patches if it's useful.
>>
>>         It sounds to me like this is something which QA and/or release
>>         managers should decide.
>>
>>          -- Owen
>>
>>         -- 
>>         Web Developer
>>         Athens County Public Libraries
>>         https://www.myacpl.org
>>         _______________________________________________
>>         Koha-devel mailing list
>>         Koha-devel at lists.koha-community.org
>>         <mailto:Koha-devel at lists.koha-community.org>
>>         http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>>         website : http://www.koha-community.org/
>>         git : http://git.koha-community.org/
>>         bugs : http://bugs.koha-community.org/
>>
>>
>>
>>     -- 
>>     Tomás Cohen Arazi
>>     Theke Solutions (http://theke.io <http://theke.io/>)
>>     ✆ +54 9351 3513384
>>     GPG: B2F3C15F
>>
>>
>>     _______________________________________________
>>     Koha-devel mailing list
>>     Koha-devel at lists.koha-community.org
>>     <mailto:Koha-devel at lists.koha-community.org>
>>     http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>>     website : http://www.koha-community.org/
>>     git : http://git.koha-community.org/
>>     bugs : http://bugs.koha-community.org/
> 
>     _______________________________________________
>     Koha-devel mailing list
>     Koha-devel at lists.koha-community.org
>     <mailto:Koha-devel at lists.koha-community.org>
>     http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>     website : http://www.koha-community.org/
>     git : http://git.koha-community.org/
>     bugs : http://bugs.koha-community.org/
> 
> 
> 
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
> 

-- 
Julian Maurice <julian.maurice at biblibre.com>
BibLibre