[Koha-devel] Tags features

[Tomas Cohen Arazi]

Thank you for the clarification!

El mar., 5 mar. 2019 a las 10:41, Mark Tompsett (<mtompset at hotmail.com>)
escribió:

> Greetings,
>
> 14385 is meant to un-hide items belonging for patrons of a particular
> patron category. It’s about exemptions.
> So if a patron is not logged in, there is no patron category, code should
> hide normally based on OpacHiddenItems.
> If a patron is logged in and they are a particular patron category, then
> the hiding does not apply to them, even though OpacHiddenItems would
> normally hide it.
> This is apparent if you look at the 14385 patch:
>
> https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14385&attachment=80463
> And click on Items.pm
>
> The problem with tags is you don’t want to include tags for things which
> are hidden, which I am not sure the tag weights were ever properly handled.
> I recall attempting to clean tags up as much as possible, but I can’t
> recall if I started putting it on bug 10589 or not. I don’t think 14385
> introduced the problem, but merely made it more apparent.
>
> As long as things which are visible (regardless of hidden and then
> un-hidden, or visible in the first place) are counted in the weighting for
> tags, that should be the expected behaviour.
>
> GPML,
> Mark Tompsett
>
>
>
> *From:* Tomas Cohen Arazi
> *Sent:* Tuesday, March 05, 2019 8:21 AM
> *To:* koha-devel
> *Subject:* [Koha-devel] Tags features
>
> Hi all, while fixing issues with emojis in Tags (solved already in 21846,
> waiting from someone to stamp their QA  signoff) I was told about 22420:
> tag cloud broken. Reverting the change from bug 14385 would 'fix it',
> meaning we restore the ability to properly scale tags based on their weight.
>
> I'm sending this email to clarify what is the expected behaviour that
> pretended to be introduced in 14385. It looks like it is trying to filter
> out those biblios that should be hidden in OPAC: cool. I can achieve this
> by decrementing the weights instead of what is done now. But then I noticed
> that the behaviour for logged in users is to display own tags only, and for
> anonymous users it displays all the tags?
>
> Can someone explain the desired behaviour so I don't make it worse while
> fixing the other problem?
>
> Thanks!
>
> --
> Tomás Cohen Arazi
> Theke Solutions (http://theke.io)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
>
> ------------------------------
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>


-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20190305/f1018eee/attachment-0001.html>