[Koha-devel] API use in intranet and OPAC

[Marcel de Rooy]

We found a few other intranet places as well (thx Katrin). The first comes from bug 8030, august 2016.

root at master:/usr/share/koha/koha-tmpl/intranet-tmpl/prog# git grep -l "/api/v1/"
[Bug 15496 12-04-19] en/modules/cataloguing/moveitem.tt
[Bug 23710 01-10-19] en/modules/reserve/request.tt
[FIRST REPORT Bug 8030 19-08-16] js/holds.js
[Bug 18589, but originated from bug 7317 03-02-17] js/ill-list-table.js
[Bug 11897 01-10-2018] js/pages/stockrotation.js

root at master:/usr/share/koha/koha-tmpl/opac-tmpl/bootstrap# git grep -l "/api/v1/"
[FIRST OPAC Bug 23623 16-09-2019] en/modules/opac-memberentry.tt

________________________________

 
 

​Museumstraat 1
Postbus 74888
1070 DN Amsterdam
Rijksmuseum.nl
​
​Nu te zien:
​​​Louise Bourgeois in de Rijksmuseumtuinen
​Operatie Nachtwacht
​
​Verwacht:
​Rembrandt-Velázquez. Nederlandse & Spaanse meesters
​
​
​T/m 18 jaar gratis
  
 Please think before you print
Van: Koha-devel <koha-devel-bounces at lists.koha-community.org> namens Agustin Moyano <agustinmoyano at theke.io>
Verzonden: vrijdag 4 oktober 2019 18:22
Aan: Koha-devel at lists.koha-community.org <Koha-devel at lists.koha-community.org>
Onderwerp: [Koha-devel] API use in intranet and OPAC

Hello everyone, I'll introduce myself for those of you who didn't "git blame" me... I'm the one who introduced that huge, nasty, blocking bug, that didn't ley you place a simple hold on intranet.

I'm glad to announce that patch is on the way, and passed QA.

This was one of the first steps (if not the first) of using the API in intranet. A really clumpsy step, I give you that, but as they saying says.. "That's one small step for [a] man, one giant leap for the API", but in my case, if I've been Neil Armstrong, I've probably tripped as soon as I got out of the module, get my helmet all scratched and filled with moon dust, and instead of a nice clean footprint, there would have been a fuzzy figure resembling a space suit trying to get up.

Marcel de Rooy, the generous soul who passedQA the solution patch, complained (and he was absolutely right) about a couple of things:

1. That there was no comunication about this in dev channel before implementing. It's too late for discusing before implementing, but I would really like to know your opinion post implementation.

2. OPAC and Intranet now use diferent methods to place holds.. one uses the API, the other uses a POST to a .pl file. I think it best to move OPAC to use the API, but this time I'm going to hear you first.

Regards




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20191007/e63a2a26/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image775975.png
Type: image/png
Size: 2974 bytes
Desc: image775975.png
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20191007/e63a2a26/attachment.png>