[Koha-devel] Follow-up patches and why not to use them

Joonas Kylmälä joonas.kylmala at helsinki.fi
Mon Jun 7 06:26:19 CEST 2021


Hi,

On 04/06/2021 15:42, Julian Maurice wrote:
> Do you know you can revert multiple commits at once (ie. only one
> "revert commit" that revert a series of commits) ? Would that make it
> easier for cases like that ?
> And when trying to find all commits of a particular bug, git log --grep
> is your friend.

Yup, however you still need to verify all the changes make sense on top
of the new code base so that doesn't help.

> By enforcing a "1 commit" rule we would lose the (often) logical
> separation of patches that makes review easier.

I didn't suggest 1 commit hard rule per bug. I'm after commits
containing one logical change also.

Joonas


More information about the Koha-devel mailing list