[Koha-devel] Follow-up patches and why not to use them

[Marcel de Rooy]

Agree with Julian here. It depends.
You could squash follow-up patches yourself too before reverting them?
In some cases patches tell us a nice story, in a lot of cases it might be confusing or messy..

________________________________

RIJKS
MUSEUM

​T/m 18 jaar gratis 
​
​Kijk hier de nieuwste aflevering van Rijksmuseum Unlocked
RM

xxx

​Please think before you print
Van: Koha-devel <koha-devel-bounces at lists.koha-community.org> namens Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Verzonden: vrijdag 4 juni 2021 12:36
Aan: koha-devel <koha-devel at lists.koha-community.org>
Onderwerp: [Koha-devel] Follow-up patches and why not to use them

Hi,

I just bumped in another case of follow-up patch style causing us
trouble. In bug
https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.koha-community.org%2Fbugzilla3%2Fshow_bug.cgi%3Fid%3D28490&data=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C034cbe091d724aacf4bb08d927449659%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637583998828372650%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=MO%2B9n0LRxKvAcR56xjhqEKk9Rj%2F1LXAT2h%2F8Gs0KFuo%3D&reserved=0 I had to
spend considerable amount of time just reverting all the problematic
patches and making sure I didn't miss any related patches, instead of
just reverting one patch and knowing I would be good to go with that.
Reverting this many patches also means a lot more review work yet again
because you have no commit messages to reference to easily or if you
want to use those you have to jump from patch to patch to find out what
the change does. And this extra review work needs to be done by two
people when reverting such follow-up patch series!

If we instead asked the original author to fix the patches then this
work would need to be done only ~once. The argument against this I have
heard is that it makes the review work harder because you don't know
what has changed since the previous version. I think however that is not
very useful because the second reviewer doesn't benefit from this at all
and makes their work harder and also the first reviewer even sometimes
might review the revision after many days by which time they have
forgotten already the context so basically they end up in the same
situation as the second reviewer and have to jump between patches.

Just my two cents, I hope we can stop doing follow-ups and instead have
commits which contain one single change to decrease our time spent on
review and make sure we don't miss any problems due to having to jump
between so many contexts.

Joonas
_______________________________________________
Koha-devel mailing list
Koha-devel at lists.koha-community.org
https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.koha-community.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fkoha-devel&data=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C034cbe091d724aacf4bb08d927449659%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637583998828372650%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=YOfCRiFHuDipvbacs%2F7rSGBjfNdBLiMalVrX%2Fw6DPJU%3D&reserved=0
website : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.koha-community.org%2F&data=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C034cbe091d724aacf4bb08d927449659%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637583998828372650%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=BfRZNeIWzogwtfG6rXjeDhxj74KeD3fHMmpdkOD%2B5b4%3D&reserved=0
git : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.koha-community.org%2F&data=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C034cbe091d724aacf4bb08d927449659%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637583998828382643%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=pofwHQiWC6PyO%2BOdya3i4bs4SMRX%2Bj61%2Fg3EZo6Y5iA%3D&reserved=0
bugs : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.koha-community.org%2F&data=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C034cbe091d724aacf4bb08d927449659%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637583998828382643%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=tg71m%2Fsy1lxJpDd7rIX9CIbqVgcvMiOOi4%2BsGFM1534%3D&reserved=0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/d2dd8cd3/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image015731.jpg
Type: image/jpeg
Size: 10243 bytes
Desc: image015731.jpg
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/d2dd8cd3/attachment-0001.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image692184.png
Type: image/png
Size: 910 bytes
Desc: image692184.png
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/d2dd8cd3/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image098181.png
Type: image/png
Size: 737 bytes
Desc: image098181.png
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/d2dd8cd3/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image399729.png
Type: image/png
Size: 799 bytes
Desc: image399729.png
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/d2dd8cd3/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image713238.png
Type: image/png
Size: 804 bytes
Desc: image713238.png
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/d2dd8cd3/attachment-0007.png>