[Koha-patches] [PATCH] C4::Context::import reloaded

[Joshua Ferraro]

On Thu, Jul 31, 2008 at 9:18 AM, paul POULAIN <paul.poulain at biblibre.com> wrote:
> Andrew Moore a écrit :
>> Hi -
>>
>> Just a second opinion since this patch hits the confusing and
>> important C4::Context module.
>>
>> I applied this patch, ran the test suite on it, did a few searches in
>> the opac and staff client, and ran a cronjob. It appears to work fine.
>> So, I think it's OK to apply in my opinion.
>>
>> By eye, it does look like it will help, but I don't really know enough
>> about how C4::Context works or should work best to be able to comment
>> if it's the best way to improve it or not.
>>
> I think this patch solves the point reached by the thread : "Page size &
> speed display" jul, 1st, Frederic Demians :
>> These %s add up to considerably more than 100% don't they?  What does
>> that mean?
>>
>> Also, 23 calls to C4::Context::read_config_file?  Are we failing to
>> detect that we've loaded it, or is that a misinterpretation?
> (I agree that on long term, we should definetly improve Context.pm, but
> this patches improves things)
I appreciate all the feedback on this one, I've gone ahead and
pushed it up.

Cheers,

-- 
Joshua Ferraro SUPPORT FOR OPEN-SOURCE SOFTWARE
CEO migration, training, maintenance, support
LibLime Featuring Koha Open-Source ILS
jmf at liblime.com |Full Demos at http://liblime.com/koha |1(888)KohaILS