[Koha-patches] [PATCH] Bug Fixing bug 2410 : Cant Coerce 0 into hash

[Joshua Ferraro]

On Wed, Jul 30, 2008 at 03:53:11AM -0500, Joshua Ferraro wrote:
> On Wed, Jul 30, 2008 at 03:36:30AM -0500, Joshua Ferraro wrote:
> > Hi Henri-Damien,
> > 
> > Once again, I don't see a bugzilla bug referenced in this patch so I'm
> > not sure what problem it seeks to solve. Please submit a detailed bug
> > report for this issue, along with steps to reproduce it, so that I have
> > a way to test the patch after observing the issue myself.
> 
> Sorry, there is a bug report, but what I need is an example, can you
> give me an ISBN that I can use to reproduce this behavior?
Just by way of a reminder, please give an example ISBN that can be used
to reproduce the bad behavior.

Thanks!

Josh

> 
> Thanks!
> 
> Josh
> 
> > 
> > Thanks!
> > 
> > Josh
> > 
> > On Mon, Jul 28, 2008 at 11:56:37AM +0200, Henri-Damien LAURENT wrote:
> > > Was a problem of Amazon Similar Items
> > > ---
> > >  catalogue/detail.pl |   12 +++++++-----
> > >  1 files changed, 7 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/catalogue/detail.pl b/catalogue/detail.pl
> > > index c7f0afd..9d195b3 100755
> > > --- a/catalogue/detail.pl
> > > +++ b/catalogue/detail.pl
> > > @@ -112,9 +112,9 @@ my (@itemloop, %itemfields);
> > >  		foreach (qw(datedue datelastseen onloan)) {
> > >  			$item->{$_} = format_date($item->{$_});
> > >  		}
> > > -        $item->{datedue} = format_date($item->{datedue});
> > > -        $item->{datelastseen} = format_date($item->{datelastseen});
> > > -        $item->{onloan} = format_date($item->{onloan});
> > > +	$item->{datedue} = format_date($item->{datedue});
> > > +	$item->{datelastseen} = format_date($item->{datelastseen});
> > > +	$item->{onloan} = format_date($item->{onloan});
> > >          # item damaged, lost, withdrawn loops
> > >          $item->{itemlostloop}= GetAuthorisedValues(GetAuthValCode('items.itemlost',$fw),$item->{itemlost}) if GetAuthValCode('items.itemlost',$fw);
> > >          if ($item->{damaged}) {
> > > @@ -216,8 +216,10 @@ if ( C4::Context->preference("AmazonContent") == 1 ) {
> > >          # do we have any of these isbns in our collection?
> > >          my $similar_biblionumbers = get_biblionumber_from_isbn($similar_product->{ASIN});
> > >          # verify that there is at least one similar item
> > > -        $similar_products_exist++ if ${@$similar_biblionumbers}[0];
> > > -        push @similar_products, +{ similar_biblionumbers => $similar_biblionumbers, title => $similar_product->{Title}, ASIN => $similar_product->{ASIN}  };
> > > +	if (scalar(@$similar_biblionumbers)){
> > > + 	       $similar_products_exist++ if ($similar_biblionumbers && ${@$similar_biblionumbers}[0]);
> > > +               push @similar_products, +{ similar_biblionumbers => $similar_biblionumbers, title => $similar_product->{Title}, ASIN => $similar_product->{ASIN}  };
> > > +	}
> > >      }
> > >      my $editorial_reviews = \@{$amazon_details->{Items}->{Item}->{EditorialReviews}->{EditorialReview}};
> > >      my $average_rating = $amazon_details->{Items}->{Item}->{CustomerReviews}->{AverageRating};
> > > -- 
> > > 1.5.4.3
> > > 
> > > _______________________________________________
> > > Koha-patches mailing list
> > > Koha-patches at lists.koha.org
> > > http://lists.koha.org/mailman/listinfo/koha-patches
> > _______________________________________________
> > Koha-patches mailing list
> > Koha-patches at lists.koha.org
> > http://lists.koha.org/mailman/listinfo/koha-patches