[Koha-patches] [PATCH] Add missing to and from email addresses to user and admin EnqueueLetter calls, respectively. Add extra level to verbosity.

[Ryan Higgins]

Hi Andy.

This patch was pushed.  Is there any functionality that might be harmed by
adding
the to_ and from_ addresses to the message_queue table ?

If you foresee any problems, I can open a bug to revert the patch.

Ryan


On Fri, Aug 8, 2008 at 10:00 AM, Ryan Higgins <ryan.higgins at liblime.com>wrote:

>
>
> Ah, ok, I see.  I guess I assumed it would fail without the address set,
> but did not
> bother testing.  So the intended behavior is that message_queue.to_address
> is the recipient
> unless it doesn't exist, in which case you use the borrowernumber address ?
>
> In that case, I formally retract this patch.
>
> Thanks Andy.
>
> Ryan
>
>
>
> On Fri, Aug 8, 2008 at 9:05 AM, Andrew Moore <andrew.moore at liblime.com>wrote:
>
>> On Fri, Aug 8, 2008 at 8:00 AM, Ryan Higgins <ryan.higgins at liblime.com>
>> wrote:
>> >
>> > Yes, I'm getting nulls in the to_address and from_address  in these two
>> > cases without this patch.
>>
>> That's fine as long as the borrowernumber is populated since
>> process_message_queue.pl fills them in.
>>
>> Or, did you mean that it's trying to send emails to a missing address
>> or from a missing address?
>>
>> -A
>>
>
>
>
> --
> Ryan Higgins
>
> LibLime * Open-Source Solutions for Libraries
> Featuring KohaZOOM ILS
> 888-564-2457 x704
>



-- 
Ryan Higgins

LibLime * Open-Source Solutions for Libraries
Featuring KohaZOOM ILS
888-564-2457 x704
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20080812/09d9dde4/attachment-0001.htm>