[Koha-patches] [PATCH] Add missing to and from email addresses to user and admin EnqueueLetter calls, respectively. Add extra level to verbosity.

[Joshua Ferraro]

On Tue, Aug 12, 2008 at 1:37 AM, Ryan Higgins <ryan.higgins at liblime.com> wrote:
>
> Hi Andy.
>
> This patch was pushed.  Is there any functionality that might be harmed by
> adding
> the to_ and from_ addresses to the message_queue table ?
>
> If you foresee any problems, I can open a bug to revert the patch.
It was also reverted :-)

Josh

> Ryan
>
>
> On Fri, Aug 8, 2008 at 10:00 AM, Ryan Higgins <ryan.higgins at liblime.com>
> wrote:
>>
>>
>> Ah, ok, I see.  I guess I assumed it would fail without the address set,
>> but did not
>> bother testing.  So the intended behavior is that
>> message_queue.to_address  is the recipient
>> unless it doesn't exist, in which case you use the borrowernumber address
>> ?
>>
>> In that case, I formally retract this patch.
>>
>> Thanks Andy.
>>
>> Ryan
>>
>>
>> On Fri, Aug 8, 2008 at 9:05 AM, Andrew Moore <andrew.moore at liblime.com>
>> wrote:
>>>
>>> On Fri, Aug 8, 2008 at 8:00 AM, Ryan Higgins <ryan.higgins at liblime.com>
>>> wrote:
>>> >
>>> > Yes, I'm getting nulls in the to_address and from_address  in these two
>>> > cases without this patch.
>>>
>>> That's fine as long as the borrowernumber is populated since
>>> process_message_queue.pl fills them in.
>>>
>>> Or, did you mean that it's trying to send emails to a missing address
>>> or from a missing address?
>>>
>>> -A
>>
>>
>>
>> --
>> Ryan Higgins
>>
>> LibLime * Open-Source Solutions for Libraries
>> Featuring KohaZOOM ILS
>> 888-564-2457 x704
>
>
>
> --
> Ryan Higgins
>
> LibLime * Open-Source Solutions for Libraries
> Featuring KohaZOOM ILS
> 888-564-2457 x704
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>
>



-- 
Joshua Ferraro SUPPORT FOR OPEN-SOURCE SOFTWARE
CEO migration, training, maintenance, support
LibLime Featuring Koha Open-Source ILS
jmf at liblime.com |Full Demos at http://liblime.com/koha |1(888)KohaILS