[Koha-patches] [PATCH] Remove "toggle" from template, use loop_context_vars __odd__ instead.

paul POULAIN paul.poulain at biblibre.com
Wed Dec 31 17:24:54 CET 2008


Galen Charlton a écrit :
> Hi,
>
> On Tue, Dec 30, 2008 at 12:20 PM, Joe Atzberger
> <joe.atzberger at liblime.com> wrote:
>   
>> -        <fieldset class="rows"><legend><!-- TMPL_IF NAME="modify" -->
>> -            Modify a system preference
>> -        <!-- TMPL_ELSE -->
>> -            Add a system preference
>> -        <!-- /TMPL_IF --></legend><ol>
>> +        <fieldset class="rows"><legend>
>> +        <!-- TMPL_IF NAME="modify" -->Modify
>> +        <!-- TMPL_ELSE -->Add
>> +        <!-- /TMPL_IF --> a system preference</legend><ol>
>>     
>
> Will push, but it occurred to me that doing this could cause
> difficulty for some translations since it assumes that the verb should
> always be at the beginning of the sentence and that the rest of the
> sentence remains the same regardless of the verb.  I'm not picking on
> this patch, as this is done in lots of places, but I do want to draw
> attention to the issue and find out if any Koha translators have
> advice.
>   
You're completly right galen !

+        <!-- TMPL_IF NAME="modify" -->Modify a system preference
+        <!-- TMPL_ELSE -->Add a system preference
+        <!-- /TMPL_IF --> 

would be much better for translations, and probably more clear for 
template readers even in english ;-)

(probably my last 2008 mail...)

-- 
Paul POULAIN
http://www.biblibre.com
Expert en Logiciels Libres pour l'info-doc
Tel : (33) 4 91 81 35 08




More information about the Koha-patches mailing list