No subject
Mon Jul 28 14:19:07 CEST 2008
fails to represent integers with sufficient bit-depth, whereas in my 10.4
tests it doesn't. This suggests that the 10.5 version was compiled without
64-bit flags set, and explains why H:T may not show the same problems
(because it doesn't get compiled).
I don't know what architecture your servers are (my tests were on an intel
based MacBook), so I can't tell you how to compile for them. Check your
default compiler options (including build options retained by CPAN), or
build H:T:P with explicit variables, like CFLAGS="-march=ppc64 -arch=ppc64"
(same for CPPFLAGS). Compiler options for new Mac hardware are the unknown
area that needs to be investigated here. This would affect other compiled
packages too, so if we can confirm you have functioning 64-bit support in
any of them, maybe you can steal the CFLAGS options from one of their
Makefiles.
Given that Koha doesn't use EXPR for large number arithmetic, and you didn't
see any other errors, you could also just force the install. In the end, I
don't see any reason, including fixing your affected systems, to make these
changes in the Koha codebase.
------=_Part_42208_2657076.1217516593553
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
<div dir="ltr"><br><br><div class="gmail_quote">On Thu, Jul 31, 2008 at 9:45 AM, MJ Ray <span dir="ltr"><<a href="mailto:mjr at phonecoop.coop">mjr at phonecoop.coop</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
"Chris Nighswonger" <<a href="mailto:chris.nighswonger at liblime.com">chris.nighswonger at liblime.com</a>> wrote: [...]<br>
<div class="Ih2E3d">> I'm wondering that this problem has not manifest itself earlier than this.<br>
> As I noted above, TMPL_ELSIF was introduced back in early March and so has<br>
> been in place nearly five months now. Was the OS upgraded after the Koha<br>
> install?<br>
<br>
</div>Yes, as previously written. However, it's also possible that no<br>
critical use of TMPL_ELSIF had yet been encountered, as the Koha is<br>
only just entering production use as we complete features like<br>
enhanced member import, card printing and koha-rfid and struggle with<br>
the self-issue server.<br>
<div class="Ih2E3d"><br>
> BTW: TMPL_ELSIF is presently used in at least 55 lines of code.<br>
<br>
</div>So let's remove it while it's still easy.<br></blockquote></div><br>What you are talking about removing the ELSIF's *in order* to be able to substitute HTML::Template for HTML::Template::Pro. Nobody else wants to do this, and for good reason, since performance will suffer greatly. It's not just 55 lines, it's the templating system for every page in Koha. <br>
<br>From the ticket you posted, it is clear that the H:T:P on that MacOS (10.5) fails to represent integers with sufficient bit-depth, whereas in my 10.4 tests it doesn't. This suggests that the 10.5 version was compiled without 64-bit flags set, and explains why H:T may not show the same problems (because it doesn't get compiled). <br>
<br>I don't know what architecture your servers are (my tests were on an intel based MacBook), so I can't tell you how to compile for them. Check your default compiler options (including build options retained by CPAN), or build H:T:P with explicit variables, like CFLAGS="-march=ppc64 -arch=ppc64" (same for CPPFLAGS). Compiler options for new Mac hardware are the unknown area that needs to be investigated here. This would affect other compiled packages too, so if we can confirm you have functioning 64-bit support in any of them, maybe you can steal the CFLAGS options from one of their Makefiles.<br>
<br>Given that Koha doesn't use EXPR for large number arithmetic, and you didn't see any other errors, you could also just force the install. In the end, I don't see any reason, including fixing your affected systems, to make these changes in the Koha codebase.<br>
</div>
------=_Part_42208_2657076.1217516593553--
More information about the Koha-patches
mailing list