No subject
Mon Jul 28 14:19:07 CEST 2008
with this patch without breaking the expected
behavior on our side. Let me know if I was not sufficiently clear,
misinterpreted your needs, or if you cannot accept the
extra button click to verify that it's okay to modify the acq record without
adding the holdings record(s).
Ryan
On Thu, Jul 31, 2008 at 8:19 AM, <paul.poulain at biblibre.com> wrote:
> From: Paul POULAIN <paul.poulain at biblibre.com>
>
> It has to be reintroduced, as some (most in France) libraries don't create
> items on recieve, but after "equipment" step.
> ---
> acqui/finishreceive.pl | 58
> ++++++++++++++++++++++++-----------------------
> 1 files changed, 30 insertions(+), 28 deletions(-)
>
> diff --git a/acqui/finishreceive.pl b/acqui/finishreceive.pl
> index 8cf8d4f..8cb5bf2 100755
> --- a/acqui/finishreceive.pl
> +++ b/acqui/finishreceive.pl
> @@ -59,34 +59,36 @@ my $error_url_str;
>
> if ($quantityrec > $origquantityrec ) {
> foreach my $bc (@barcode) {
> - my $item_hash = {
> - "items.replacementprice" => $replacement,
> - "items.price" => $cost,
> - "items.booksellerid" => $supplierid,
> - "items.homebranch" => $branch[$cnt],
> - "items.holdingbranch" => $branch[$cnt],
> - "items.barcode" => $barcode[$cnt],
> - "items.ccode" => $ccode[$cnt],
> - "items.itype" => $itemtype[$cnt],
> - "items.location" => $location[$cnt],
> - "items.enumchron" => $enumchron[$cnt], #
> FIXME : No integration here with serials module.
> - "items.loan" => 0,
> - };
> - $item_hash->{'items.cn_source'} =
> C4::Context->preference('DefaultClassificationSource')
> if(C4::Context->preference('DefaultClassificationSource') );
> - # FIXME : cn_sort is populated by
> Items::_set_derived_columns_for_add , which is never called with
> AddItemFromMarc . Bug 2403
> - my $itemRecord = TransformKohaToMarc($item_hash);
> - $cnt++;
> - $item_hash =
> TransformMarcToKoha(undef,$itemRecord,'','items');
> - # FIXME: possible race condition. duplicate barcode check
> should happen in AddItem, but for now we have to do it here.
> - my %err = CheckItemPreSave($item_hash);
> - if(%err) {
> - for my $err_cnd (keys %err) {
> - $error_url_str .= "&error=" . $err_cnd .
> "&error_param=" . $err{$err_cnd};
> - }
> - $quantityrec--;
> - } else {
> - AddItemFromMarc($itemRecord,$biblionumber);
> - }
> + if ($bc) {
> + my $item_hash = {
> + "items.replacementprice" => $replacement,
> + "items.price" => $cost,
> + "items.booksellerid" => $supplierid,
> + "items.homebranch" => $branch[$cnt],
> + "items.holdingbranch" => $branch[$cnt],
> + "items.barcode" => $barcode[$cnt],
> + "items.ccode" => $ccode[$cnt],
> + "items.itype" => $itemtype[$cnt],
> + "items.location" => $location[$cnt],
> + "items.enumchron" => $enumchron[$cnt], #
> FIXME : No integration here with serials module.
> + "items.loan" => 0,
> + };
> + $item_hash->{'items.cn_source'} =
> C4::Context->preference('DefaultClassificationSource')
> if(C4::Context->preference('DefaultClassificationSource') );
> + # FIXME : cn_sort is populated by
> Items::_set_derived_columns_for_add , which is never called with
> AddItemFromMarc . Bug 2403
> + my $itemRecord = TransformKohaToMarc($item_hash);
> + $cnt++;
> + $item_hash =
> TransformMarcToKoha(undef,$itemRecord,'','items');
> + # FIXME: possible race condition. duplicate barcode check
> should happen in AddItem, but for now we have to do it here.
> + my %err = CheckItemPreSave($item_hash);
> + if(%err) {
> + for my $err_cnd (keys %err) {
> + $error_url_str .= "&error=" . $err_cnd .
> "&error_param=" . $err{$err_cnd};
> + }
> + $quantityrec--;
> + } else {
> + AddItemFromMarc($itemRecord,$biblionumber);
> + }
> + }
> }
>
> # save the quantity received.
> --
> 1.5.3.2
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>
--
Ryan Higgins
LibLime * Open-Source Solutions for Libraries
Featuring KohaZOOM ILS
888-564-2457 x704
------=_Part_7628_16749796.1217640505724
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
<div dir="ltr"><br>Hi Paul.<br><br>I think I understand your intent here: to allow a separation of item creation from receiving (billing/acq).<br><br>A recent patch I submitted for this page and its successor in normal workflow ( parcel.pl )<br>
reports errors on any item records that were not created in the receiving step.<br><br>Your patch removes the capacity to receive multiple items, which is definitely not desired.<br>All you should have to do alter the " if( $quantityrec > 0 ) " conditional.<br>
<br>The question that needs to be answered is 'what is the appropriate behavior if item records are not <br>created?' :<br><br>I think the answer is this: <br>1: (required) allow the user to manually edit 'quantity received' (currently read-only field).<br>
2: (optional) add an onchange for 'quantity received' to show enough item record divs to add the holdings data if we have it.<br>3: (required) add an onsubmit form checker that tests the number of unique barcodes against the number in 'quantity received',<br>
and tells the user that if they say ok, item records will _not_ be created, but the acq module will register that the items<br> were received. Most of this js code is already in place.<br><br>From my understanding, I think this will meet the needs that you express with this patch without breaking the expected<br>
behavior on our side. Let me know if I was not sufficiently clear, misinterpreted your needs, or if you cannot accept the <br>extra button click to verify that it's okay to modify the acq record without adding the holdings record(s).<br>
<br>Ryan<br><br><br><br><div class="gmail_quote">On Thu, Jul 31, 2008 at 8:19 AM, <span dir="ltr"><<a href="mailto:paul.poulain at biblibre.com">paul.poulain at biblibre.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
From: Paul POULAIN <<a href="mailto:paul.poulain at biblibre.com">paul.poulain at biblibre.com</a>><br>
<br>
It has to be reintroduced, as some (most in France) libraries don't create<br>
items on recieve, but after "equipment" step.<br>
---<br>
acqui/finishreceive.pl | 58 ++++++++++++++++++++++++-----------------------<br>
1 files changed, 30 insertions(+), 28 deletions(-)<br>
<br>
diff --git a/acqui/finishreceive.pl b/acqui/finishreceive.pl<br>
index 8cf8d4f..8cb5bf2 100755<br>
--- a/acqui/finishreceive.pl<br>
+++ b/acqui/finishreceive.pl<br>
@@ -59,34 +59,36 @@ my $error_url_str;<br>
<br>
if ($quantityrec > $origquantityrec ) {<br>
foreach my $bc (@barcode) {<br>
- my $item_hash = {<br>
- "items.replacementprice" => $replacement,<br>
- "items.price" => $cost,<br>
- "items.booksellerid" => $supplierid,<br>
- "items.homebranch" => $branch[$cnt],<br>
- "items.holdingbranch" => $branch[$cnt],<br>
- "items.barcode" => $barcode[$cnt],<br>
- "items.ccode" => $ccode[$cnt],<br>
- "items.itype" => $itemtype[$cnt],<br>
- "items.location" => $location[$cnt],<br>
- "items.enumchron" => $enumchron[$cnt], # FIXME : No integration here with serials module.<br>
- "items.loan" => 0,<br>
- };<br>
- $item_hash->{'items.cn_source'} = C4::Context->preference('DefaultClassificationSource') if(C4::Context->preference('DefaultClassificationSource') );<br>
- # FIXME : cn_sort is populated by Items::_set_derived_columns_for_add , which is never called with AddItemFromMarc . Bug 2403<br>
- my $itemRecord = TransformKohaToMarc($item_hash);<br>
- $cnt++;<br>
- $item_hash = TransformMarcToKoha(undef,$itemRecord,'','items');<br>
- # FIXME: possible race condition. duplicate barcode check should happen in AddItem, but for now we have to do it here.<br>
- my %err = CheckItemPreSave($item_hash);<br>
- if(%err) {<br>
- for my $err_cnd (keys %err) {<br>
- $error_url_str .= "&error=" . $err_cnd . "&error_param=" . $err{$err_cnd};<br>
- }<br>
- $quantityrec--;<br>
- } else {<br>
- AddItemFromMarc($itemRecord,$biblionumber);<br>
- }<br>
+ if ($bc) {<br>
+ my $item_hash = {<br>
+ "items.replacementprice" => $replacement,<br>
+ "items.price" => $cost,<br>
+ "items.booksellerid" => $supplierid,<br>
+ "items.homebranch" => $branch[$cnt],<br>
+ "items.holdingbranch" => $branch[$cnt],<br>
+ "items.barcode" => $barcode[$cnt],<br>
+ "items.ccode" => $ccode[$cnt],<br>
+ "items.itype" => $itemtype[$cnt],<br>
+ "items.location" => $location[$cnt],<br>
+ "items.enumchron" => $enumchron[$cnt], # FIXME : No integration here with serials module.<br>
+ "items.loan" => 0,<br>
+ };<br>
+ $item_hash->{'items.cn_source'} = C4::Context->preference('DefaultClassificationSource') if(C4::Context->preference('DefaultClassificationSource') );<br>
+ # FIXME : cn_sort is populated by Items::_set_derived_columns_for_add , which is never called with AddItemFromMarc . Bug 2403<br>
+ my $itemRecord = TransformKohaToMarc($item_hash);<br>
+ $cnt++;<br>
+ $item_hash = TransformMarcToKoha(undef,$itemRecord,'','items');<br>
+ # FIXME: possible race condition. duplicate barcode check should happen in AddItem, but for now we have to do it here.<br>
+ my %err = CheckItemPreSave($item_hash);<br>
+ if(%err) {<br>
+ for my $err_cnd (keys %err) {<br>
+ $error_url_str .= "&error=" . $err_cnd . "&error_param=" . $err{$err_cnd};<br>
+ }<br>
+ $quantityrec--;<br>
+ } else {<br>
+ AddItemFromMarc($itemRecord,$biblionumber);<br>
+ }<br>
+ }<br>
}<br>
<br>
# save the quantity received.<br>
<font color="#888888">--<br>
<a href="http://1.5.3.2" target="_blank">1.5.3.2</a><br>
<br>
_______________________________________________<br>
Koha-patches mailing list<br>
<a href="mailto:Koha-patches at lists.koha.org">Koha-patches at lists.koha.org</a><br>
<a href="http://lists.koha.org/mailman/listinfo/koha-patches" target="_blank">http://lists.koha.org/mailman/listinfo/koha-patches</a><br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Ryan Higgins<br><br>LibLime * Open-Source Solutions for Libraries<br>Featuring KohaZOOM ILS<br>888-564-2457 x704<br>
</div>
------=_Part_7628_16749796.1217640505724--
More information about the Koha-patches
mailing list