[Koha-patches] [PATCH] Reduce logging from rebuild_zebra.pl with a command line option

Galen Charlton galen.charlton at liblime.com
Wed Oct 1 19:34:30 CEST 2008


Hi Michael,

On Tue, Sep 30, 2008 at 9:53 AM, Michael Hafen <mdhafen at tech.washk12.org> wrote:
> +    'v'             => \$reduce_logging,

Sorry to nitpick this to death, but could you change the variable
name?  If -v causes verbose logging, having it set $reduce_logging to
true is counter-intuitive.  I suggest using two variables:
$verbose_logging for the Boolean and $log_options for the zebraidx
command-line options.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt



More information about the Koha-patches mailing list