[Koha-patches] [PATCH] Reduce logging from rebuild_zebra.pl with a command line option
Michael Hafen
mdhafen at tech.washk12.org
Wed Oct 1 19:52:29 CEST 2008
Yes, that's brilliant. I should have thought of that. I'll change that
and resubmit.
On Wed, 2008-10-01 at 12:34 -0500, Galen Charlton wrote:
> Hi Michael,
>
> On Tue, Sep 30, 2008 at 9:53 AM, Michael Hafen <mdhafen at tech.washk12.org> wrote:
> > + 'v' => \$reduce_logging,
>
> Sorry to nitpick this to death, but could you change the variable
> name? If -v causes verbose logging, having it set $reduce_logging to
> true is counter-intuitive. I suggest using two variables:
> $verbose_logging for the Boolean and $log_options for the zebraidx
> command-line options.
>
> Regards,
>
> Galen
More information about the Koha-patches
mailing list