[Koha-patches] [PATCH] [bug #2689] Fix the checked box "manual history" and fix the "null" value of serial next issue publication date

[Joe Atzberger]

Owen --

Can you clarify whether it breaks the translator's production for the whole
template or just the tag in which it is embedded.  I hope it is not the
whole template!

I assume it would break for any <!-- comment --> inside the tag (afaik a
valid HTML construction) and not just TMPL comments.

It is unfortunate that the translation script is such a Frankenstein piece
of code, that we endure all these workarounds rather than fix it directly.

--Joe

On Fri, Oct 17, 2008 at 9:30 AM, Owen Leonard <oleonard at myacpl.org> wrote:

> > +                               <li><label for="manuallist"> Manual
> history:</label> <input type="checkbox" name="manualhist" id="manuallist"
> value="1" <!-- TMPL_IF name="manualhistory" -->checked<!-- /TMPL_IF -->
> /></li>
>
> Embedding a TMPL_IF inside an HTML tag will break the translation
> script. It's inconvenient, but you have to do it like this:
>
> <!-- TMPL_IF name="manualhistory" -->
>   <input type="checkbox" name="manualhist" id="manuallist" value="1"
> checked="checked" />
> <!-- TMPL_ELSE -->
>   <input type="checkbox" name="manualhist" id="manuallist" value="1" />
> <!-- /TMPL_IF -->
>
> Also note that for XHTML compliance you have to use
> 'checked="checked"' instead of just 'checked.'
>
>  -- Owen
>
> --
> Web Developer
> Athens County Public Libraries
> http://www.myacpl.org
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20081017/863a66a7/attachment-0002.htm>