[Koha-patches] [PATCH] Bugfix #2920 AmazonSimilarItems & OPACAmazonSimilarItems

Galen Charlton galen.charlton at liblime.com
Fri Apr 24 16:44:17 CEST 2009


Hi Frederic,

On Wed, Jan 21, 2009 at 4:06 AM, Frederic Demians <f.demians at tamil.fr> wrote:
> In OPAC opac-detail.pl page (same in intranet) AmazonSimilarItems is
> not used to control if Amazon web service is called or not.
> It means that even if AmazonSimilarItems is disabled, requests are
> sent to Amazon to retrieve reader reviews and similar items. It's
> a waste of resources.

This patch (or rather, how it would look taking the recent enhanced
content refactoring) is too broad.  The test in catalogue/detail.pl
and opac/opac-detail.pl should be on AmazonEnabled/OpacAmazonEnabled.
The call to get_amazon_details() retrieves images, reviews, and item
attributes as well as similar items, so if you want avoid retrieving
similar item information when you don't want it, get_amazon_details()
should be the target of a patch.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt



More information about the Koha-patches mailing list