[Koha-patches] [PATCH] Bugfix #2920 AmazonSimilarItems & OPACAmazonSimilarItems

[Frédéric DEMIANS]

>> In OPAC opac-detail.pl page (same in intranet) AmazonSimilarItems is
>> not used to control if Amazon web service is called or not.
>> It means that even if AmazonSimilarItems is disabled, requests are
>> sent to Amazon to retrieve reader reviews and similar items. It's
>> a waste of resources.
>
> This patch (or rather, how it would look taking the recent enhanced
> content refactoring) is too broad. The test in catalogue/detail.pl
> and opac/opac-detail.pl should be on AmazonEnabled/OpacAmazonEnabled.
> The call to get_amazon_details() retrieves images, reviews, and item
> attributes as well as similar items, so if you want avoid retrieving
> similar item information when you don't want it, get_amazon_details()
> should be the target of a patch.

I've seen. Now to avoid  calling get_amazon_details(), you have to 
disable OPACAmazonSimilarItems or OPACAmazonContent...

Could you confirm that this logic would be correct :

Looking at C4::External:Amazon.pm, get_amazon_details call Amazon for 
those services:

    * Similarities
    * EditorialReview
    * Reviews
    * ItemAttributes
    * Images

ItemAttributes and Images should be removed. Image is already retrieved 
client-side. ItemAttributes is not used anywhere. Correct me if I'm wrong.

So 3 Amazon contents, server-side retrieved, must be selectable by 
syspref, combining (OPACAmazonEnabled or AmazonEnabled) and:

    * OPACAmazonSimilarItems -> Similarities
    * OPACAmzonReviews -> EditorialReviews and Reviews


-- 
Frédéric DEMIANS
http://www.tamil.fr/u/fdemians.html