[Koha-patches] [PATCH] Bugfix #2920 AmazonSimilarItems & OPACAmazonSimilarItems

[Galen Charlton]

Hi,

2009/4/24 Frédéric DEMIANS <f.demians at tamil.fr>:
> Looking at C4::External:Amazon.pm, get_amazon_details call Amazon for those
> services:
>
>   * Similarities
>   * EditorialReview
>   * Reviews
>   * ItemAttributes
>   * Images
>
> ItemAttributes and Images should be removed. Image is already retrieved
> client-side. ItemAttributes is not used anywhere. Correct me if I'm wrong.

ItemAttributes and Images could both be removed from the request that
get_amazon_details() makes, although I could see ItemAttributes coming
back at some point, since there are a lot of things it returns such as
recommend ages, running times, etc. that could be valuable if
displayed in the OPAC.

> So 3 Amazon contents, server-side retrieved, must be selectable by syspref,
> combining (OPACAmazonEnabled or AmazonEnabled) and:
>
>   * OPACAmazonSimilarItems -> Similarities
>   * OPACAmzonReviews -> EditorialReviews and Reviews

Right.  The simplest case would be to skip the call to
get_amazon_details if OPACAmazonSimilarItems and OPACAmazonReviews are
both false.  Rather than put the system preference logic inside
get_amazon_details, you could add an array argument to it to specify
the desired data elements, and have the client code (opac-detail.pl
and detail.pl) determine which elements to retrieve.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt