[Koha-patches] [PATCH] [replaceprevious](bug #3196) fix itemlost.pl

[Galen Charlton]

Hi,

On Thu, May 7, 2009 at 5:48 AM, Nahuel ANGELINETTI
<nahuel.angelinetti at biblibre.com> wrote:
> -        FROM   items, biblio, authorised_values
> +        FROM   items
> +            LEFT JOIN biblio ON (items.biblionumber = biblio.biblionumber)
> +            LEFT JOIN biblioitems ON (items.biblionumber = biblioitems.biblionumber)

I've pushed the patch, but seeing these joins made me think of an
issue - there are a lot of places where we have an outer join of items
to biblio and of biblio to biblioitems.  However, is there a reason to
expect or desire that there would be items that are not linked to bibs
or biblioitems rows that do not have corresponding biblio rows?  Those
strike me as being too loose - they should just be plain inner joins.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt