[Koha-patches] [PATCH] [replaceprevious](bug #3196) fix itemlost.pl

[Nahuel ANGELINETTI]

Le Mon, 11 May 2009 10:24:01 -0400,
Galen Charlton <galen.charlton at liblime.com> a écrit :

> Hi,
> 
> On Thu, May 7, 2009 at 5:48 AM, Nahuel ANGELINETTI
> <nahuel.angelinetti at biblibre.com> wrote:
> > -        FROM   items, biblio, authorised_values
> > +        FROM   items
> > +            LEFT JOIN biblio ON (items.biblionumber =
> > biblio.biblionumber)
> > +            LEFT JOIN biblioitems ON (items.biblionumber =
> > biblioitems.biblionumber)
> 
> I've pushed the patch, but seeing these joins made me think of an
> issue - there are a lot of places where we have an outer join of items
> to biblio and of biblio to biblioitems.  However, is there a reason to
> expect or desire that there would be items that are not linked to bibs
> or biblioitems rows that do not have corresponding biblio rows?  Those
> strike me as being too loose - they should just be plain inner joins.

items or biblioitems that don't have corresponding biblio rows are
broken entries, SO they must not be used because it should generate
errors. Anyway, it's only my point of view.

bests,

-- 
Nahuel ANGELINETTI