[Koha-patches] [PATCH] Bug 2505 enable warnings in serials/reorder_members.pl
Colin Campbell
colin.campbell at ptfs-europe.com
Sat May 15 14:40:18 CEST 2010
The only serials routine without warnings enabled was a
script with the least code to generate them
removed the numerous Module use declarations that were not
required
aligned the parameters for a more aesthetically pleasing effect
---
serials/reorder_members.pl | 20 +++++++-------------
1 files changed, 7 insertions(+), 13 deletions(-)
diff --git a/serials/reorder_members.pl b/serials/reorder_members.pl
index c42823d..66d4ab2 100755
--- a/serials/reorder_members.pl
+++ b/serials/reorder_members.pl
@@ -14,27 +14,21 @@
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-
# Routing.pl script used to create a routing list for a serial subscription
# In this instance it is in fact a setting up of a list of reserves for the item
# where the hierarchical order can be changed on the fly and a routing list can be
# printed out
use strict;
-#use warnings; FIXME - Bug 2505
+use warnings;
use CGI;
-use C4::Auth;
-use C4::Context;
-use C4::Output;
-use C4::Koha;
-use C4::Acquisition;
-use C4::Serials;
-my $query = new CGI;
+my $query = CGI->new;
my $subscriptionid = $query->param('subscriptionid');
-my $routingid = $query->param('routingid');
-my $rank = $query->param('rank');
+my $routingid = $query->param('routingid');
+my $rank = $query->param('rank');
-reorder_members($subscriptionid,$routingid,$rank);
+reorder_members( $subscriptionid, $routingid, $rank );
-print $query->redirect("/cgi-bin/koha/serials/routing.pl?subscriptionid=$subscriptionid");
+print $query->redirect(
+ "/cgi-bin/koha/serials/routing.pl?subscriptionid=$subscriptionid");
--
1.6.6.1
More information about the Koha-patches
mailing list