[Koha-patches] [PATCH] Bug 4397: Scan index search results broken for non-latin characters

Tomas Cohen Arazi tomascohen at gmail.com
Fri Feb 28 19:38:02 CET 2014


The Zoom specification defines that a ScanSet should provide a way
to retrieve terms suitable for displaying and another one for using
on further searches [1].

The Net::Z3950::ZOOM implementation actually provides both [2] but we
where using the wrong one.

Using $scanset->display_term(...) instead of $scanset->term(...) fixes the problem.

To test:
- Do a index scan search (advanced search > more options > check 'index scan')
- Notice non-latin characters are replaced by one or more '@' symbols.
- Apply the patch
- Re-do the search, everything shows as it should.
- Try to follow any of the terms (clicking on them) and notice that
  it actually gives you relevant results (i.e. is not searching for @!!!!).
- Sign off :-D

Regards
To+

[1] http://zoom.z3950.org/api/zoom-1.4.html#3.6.3
[2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#term()_/_display_term()

Sponsored-by: Universidad Nacional de Cordoba
---
 C4/Search.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/C4/Search.pm b/C4/Search.pm
index 09c1951..816d803 100644
--- a/C4/Search.pm
+++ b/C4/Search.pm
@@ -457,7 +457,7 @@ sub getRecords {
 
                     ## Check if it's an index scan
                     if ($scan) {
-                        my ( $term, $occ ) = $results[ $i - 1 ]->term($j);
+                        my ( $term, $occ ) = $results[ $i - 1 ]->display_term($j);
 
                  # here we create a minimal MARC record and hand it off to the
                  # template just like a normal result ... perhaps not ideal, but
-- 
1.8.3.2



More information about the Koha-patches mailing list