[Koha-patches] [PATCH] Bug 11877 - Eliminate use of deprecated jQuery .live() method

[Owen Leonard]

As of jQuery 1.9 the .live() method has been removed. A few templates
contain JavaScript which uses it. It can be easily replaced with .on().
This patch makes the correction.

To test, apply the patch and test the following pages:

- In the staff client, Administration -> OAI sets configuration:
  Define mappings for an existing set. You should be able to add rows by
  clicking the "OR" button. You should be able to delete or clear any
  line by clicking the "Delete" link.

- In the staff client, view the details for any patron and click the
  "Change password" button: In the change password form click the link
  to fill the password fields with a random password. This link should
  work correctly.

- If necessary enable OpacRenewalAllowed in system preferences. Log in
  to the OPAC as a patron who has checkouts. On the patron summary page
  (opac-user.pl) look for the "renew selected" and "renew all" links at
  the top of the table of checkouts. Both these links should work
  correctly. Test in prog and bootstrap themes.
---
 .../prog/en/modules/admin/oai_set_mappings.tt      |    9 +++++----
 .../prog/en/modules/members/member-password.tt     |    7 ++++---
 .../opac-tmpl/bootstrap/en/modules/opac-user.tt    |    6 ++++--
 koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt   |    4 ++--
 4 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt
index c4a9b87..60469b8 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt
@@ -7,11 +7,12 @@ $(document).ready(function() {
     $("#mappingform").submit(function(){
       hideDialogBox();
     });
-    $("#ORbutton").live("click", function(){
-       newCondition();
-       return false;
+    $("body").on("click","#ORbutton", function(e){
+        e.preventDefault();
+        newCondition();
     });
-    $(".clear-field").live("click",function(e){
+    $("body").on("click",".clear-field",function(e){
+        e.preventDefault();
         clearRow(e.target);
     });
 });
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
index eb69430..d035a6d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
@@ -12,7 +12,8 @@
                 return true;
             }
         });
-        $("#fillrandom").live('click', function() {
+        $("body").on('click', "#fillrandom",function(e) {
+            e.preventDefault();
             $("#newpassword").after("<input type=\"text\" name=\"newpassword\" value=\"[% defaultnewpassword %]\">").remove();
             $("#newpassword2").after("<input type=\"text\" name=\"newpassword2\" value=\"[% defaultnewpassword %]\">").remove();
         });
@@ -28,7 +29,7 @@
 <div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/members/members-home.pl">Patrons</a>  › <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% firstname %] [% surname %]</a> › [% IF ( newpassword ) %]Password Updated[% ELSE %]Change username and/or password[% END %]</div>
 
 <div id="doc3" class="yui-t2">
-   
+
    <div id="bd">
 	<div id="yui-main">
 	<div class="yui-b">
@@ -40,7 +41,7 @@
 [% ELSE %]
 
 <form method="post" id="changepasswordf" action="/cgi-bin/koha/members/member-password.pl">
-<input type="hidden" name="destination" value="[% destination %]" />	
+<input type="hidden" name="destination" value="[% destination %]" />
 <input type="hidden" name="cardnumber" value="[% cardnumber %]" />
 <input type="hidden" name="borrowernumber" id="borrowernumber" value="[% borrowernumber %]" />
 	[% IF ( errormsg ) %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
index edd569c..c374650 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
@@ -661,10 +661,12 @@
                     }
                     return valid;
                 });
-                $("#renewselected_link").live('click',function(){
+                $("body").on("click","#renewselected_link",function(e){
+                    e.preventDefault();
                     $("#renewselected").submit();
                 });
-                $("#renewall_link").live('click',function(){
+                $("body").on("click","#renewall_link",function(e){
+                    e.preventDefault();
                     $("#renewall").submit();
                 });
                 $("#checkoutst caption").append("<div id=\"renewcontrols\"><a id=\"renewselected_link\" href=\"#\">"+_("Renew selected")+"</a> <a id=\"renewall_link\" href=\"#\">"+_("Renew all")+"</a></div>");
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
index 62a852b..16b88b1 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
@@ -40,10 +40,10 @@ var MSG_CONFIRM_RESUME_HOLDS  = _("Are you sure you want to resume all suspended
             }
             return valid;
         });
-        $("#renewselected_link").live('click',function(){
+        $("body").on("click","#renewselected_link",function(){
             $("#renewselected").submit();
         });
-        $("#renewall_link").live('click',function(){
+        $("body").on("click","#renewall_link",function(){
             $("#renewall").submit();
         });
         $("#checkoutst caption").append("<div id=\"renewcontrols\"><a id=\"renewselected_link\" href=\"#\">"+_("Renew selected")+"</a> <a id=\"renewall_link\" href=\"#\">"+_("Renew all")+"</a></div>");[% END %]
-- 
1.7.9.5