[Koha-patches] [PATCH] Bug 16667: Unused variable and function call in circulation.pl

Srdjan srdjan at catalyst.net.nz
Mon Jun 6 07:14:48 CEST 2016


From: Tomas Cohen Arazi <tomascohen at theke.io>

This patch removes an unused occurence of the $branches variable. Probably a
leftover from a recent rewrite.

To test:
- Run:
  $ git grep '$branches' circ/circulation.pl
=> FAIL: Only on occurence of the variable
- Apply the patch
- Run:
  $ git grep '$branches' circ/circulation.pl
=> SUCCESS: The variable has been removed
- Sign off :-D

Regards

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
---
 circ/circulation.pl | 2 --
 1 file changed, 2 deletions(-)

diff --git a/circ/circulation.pl b/circ/circulation.pl
index b2bcdd1..b2201cf 100755
--- a/circ/circulation.pl
+++ b/circ/circulation.pl
@@ -125,8 +125,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user (
     }
 );
 
-my $branches = GetBranches();
-
 my $force_allow_issue = $query->param('forceallow') || 0;
 if (!C4::Auth::haspermission( C4::Context->userenv->{id} , { circulate => 'force_checkout' } )) {
     $force_allow_issue = 0;
-- 
2.7.4


More information about the Koha-patches mailing list