[Koha-patches] [PATCH] Bug 16649: Make OpenLibrarySearch test pass even if launches offline

Srdjan srdjan at catalyst.net.nz
Mon Jun 6 07:21:36 CEST 2016


From: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Test plan:
  prove t/OpenLibrarySearch.t
should return green even if you are offline

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
---
 t/OpenLibrarySearch.t | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/t/OpenLibrarySearch.t b/t/OpenLibrarySearch.t
index 8084453..b0865e6 100644
--- a/t/OpenLibrarySearch.t
+++ b/t/OpenLibrarySearch.t
@@ -22,7 +22,11 @@ use Test::More tests => 1;
 use LWP::Simple;
 use JSON;
 my $content  = get("https://openlibrary.org/search.json?q=9780201038095");
-my $data     = from_json($content);
-my $numFound = $data->{numFound};
 
-ok( $numFound > 0, "The openlibrary ws should return at least 1 result" );
+SKIP: {
+    skip "json has not been retrieved from openlibrary.org", 1 unless defined $content;
+    my $data     = from_json($content);
+    my $numFound = $data->{numFound};
+
+    ok( $numFound > 0, "The openlibrary ws should return at least 1 result" );
+}
-- 
2.7.4


More information about the Koha-patches mailing list