[Koha-patches] [PATCH] Bug 16636: t/00-load.t warning from C4/External/BakerTaylor.pm

Srdjan srdjan at catalyst.net.nz
Mon Jun 6 07:28:02 CEST 2016


From: Mark Tompsett <mtompset at hotmail.com>

Since the tests are expecting an initialize function, the
initialize call was just moved outside of the INIT block.

TEST PLAN
---------
1) prove t/00-load.t
   -- warnings about INIT for hbyymmincr
2) prove `git grep -l BakerTaylor | grep [.]t$`
   -- should all run okay
3) apply patch
4) repeat steps 1 and 2
   -- warning should be gone, and everything else run okay
5) run koha qa test tools

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
---
 C4/External/BakerTaylor.pm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/C4/External/BakerTaylor.pm b/C4/External/BakerTaylor.pm
index 4450e9b..3f52a57 100644
--- a/C4/External/BakerTaylor.pm
+++ b/C4/External/BakerTaylor.pm
@@ -29,6 +29,7 @@ use warnings;
 
 use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $VERSION);
 use vars qw($user $pass $agent $image_url $link_url);
+&initialize;
 
 BEGIN {
 	require Exporter;
@@ -37,9 +38,6 @@ BEGIN {
 	@EXPORT_OK = qw(&availability &content_cafe &image_url &link_url &http_jacket_link);
 	%EXPORT_TAGS = (all=>\@EXPORT_OK);
 }
-INIT {
-	&initialize;
-}
 
 sub initialize {
 	$user     = (@_ ? shift : C4::Context->preference('BakerTaylorUsername')    ) || ''; # LL17984
-- 
2.7.4


More information about the Koha-patches mailing list