https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292 --- Comment #46 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #45)
(In reply to Jonathan Druart from comment #44)
(In reply to Marcel de Rooy from comment #42)
[FAIL] xt/check_db_revs_sql_syntax.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 18)
Fixed in the last patch (that does more than that).
I welcome enhancing code. But can we squash this now? How do we want to backport etc?
Better to not squash if we want to backport then. Tests should not process files that are not in the git repository, so this is a bug fix that should be part of this bug report IMO. You are correct that Koha::Devel::Files is not in all supported branches, but this specific patch can be skipped if needed. -- You are receiving this mail because: You are watching all bug changes.