http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #51)
It would be better to use Koha::List::Patron instead. Done
I'd make more sense to pass the non empty patron lists only. Done
You are modifying the behavior of the tool. This change should be moved to another bug report (misc/cronjobs/delete_patrons.pl will need the change too). Done, moved to bug 15642 as a dependency.
However, looking over the code again I noted that while the tool did use this subroutine initially, it used it in conjunction with C4::Members GetBorrowersToExpunge which checks for borrowers w/issues in the SQl query it builds and eliminates those borrowers from consideration. The new deletion by list feature doesn't use GetBorrowersToExpunge (since it is basing from a list) so needs to make a check for issues. It seems logical enough to add the check in this sub since we are already calling GetMemberIssuesAndFines and really I just pickup the return value instead of ignoring it. So, I can either leave dependent and wait on 15642, close the other bug and replace the code here, or create a new separate sub to check for issues. Thoughts? -- You are receiving this mail because: You are watching all bug changes.