https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179192|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179196&action=edit Bug 39313: Make OpacTrustedCheckout self-checkout modal accept valid barcode This patch fixes a regression introduced by Bug 38505. To test: 1. Enabled OpacTrustedCheckout system preference 2. Search for an item and get the barcode 3. Go to the OPAC 4. Click the Self-checkout button at the top 5. Enter the barcode and submit 6. Notice you are given an error UNKNOWN_BARCODE and the item is not checked out 7. Apply the patch and restart services 8. Repeat steps 4-6 and confirm you are able to successfully check out the item 9. Test submitting the modal with no barcode entered - confirm you are shown an appropriate error 10. Test with a fake barcode that does not exist - confirm you are shown an appropriate error 11. Run tests to confirm no regressions prove t/db_dependent/Circulation* prove t/db_dependent/DecreaseLoanHighHolds.t prove t/db_dependent/rollingloans.t prove t/db_dependent/api/v1/checkouts.t prove t/db_dependent/Patron/Borrower_PrevCheckout.t prove t/db_dependent/Koha/ILL/Requests.t Sponsored-by: Reserve Bank of New Zealand Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised, including the tests. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.