https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35434 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [1] Please check: FAIL t/db_dependent/Koha/Item.t FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/Koha/Item.t` FAIL valid Scalar value @pickup_locations[0] better written as $pickup_locations[0] [2] Minor point. Feeis like the following code parts should be reversed: if ( C4::Context->preference("IndependentBranches") and !C4::Context->preference("canreservefromotherbranches") ) { my $userenv = C4::Context->userenv; unless ( C4::Context->IsSuperLibrarian ) { return Koha::Libraries->new()->empty if ( $self->homebranch ne $userenv->{branch} ); return Koha::Libraries->search( { branchcode => $self->homebranch } ); } } Koha::Exceptions::MissingParameter->throw( parameter => 'patron' ) unless exists $params->{patron}; -- You are receiving this mail because: You are watching all bug changes.