https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132206&action=edit Bug 30222: Simplify logic for reporting This patch adds two new variables: $wants_email and $wants digest These are used to simplify checks on whether notices should be sent To test: 1 - Apply patch 2 - Confirm notices are not sent of pref is 'cron' and send_notcies flag not set 3 - Confirm notices are sent if pref is cron and send_notices flag is set and borrower does not have preference set for auto renewals 4 - Confirm notices not sent if pref is set to follow messaging preference and borrower does not have preferences set for auto_renewals 5 - Confirm regular notices sent if pref is set to follow messaging preferences and borrower does have the preference set but not digest 6 - Confirm digest notices sent if pref is set to follow messaging preferences and borrower does have the preference set and wants digest Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.