[Bug 30222] New: Auto_renew_digest still sends every day when renewals are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Bug ID: 30222 Summary: Auto_renew_digest still sends every day when renewals are not allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 29381 The non-digest auto-renew notice checks to see whether or not the auto-renew error on the issue has changed since the previous day. If the error is not new, the notice doesn't generate. In the auto-renew-digest, we don't do that check. For any error other than auto_too_soon, the patron will be notified every day. Bug 29381 tried to address this, but did not correct the whole issue. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 [Bug 29381] Auto-renewal digest messages are sent on every cron run -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com, | |hebah@bywatersolutions.com, | |nick@bywatersolutions.com, | |sbrown@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131586&action=edit Bug 30222: Only send auto renewal digest wehn there is an update Currently, the code sends an email to the patron when there is any error that is not 'too_soon' - we also don't include issues that are 'too_soon', so emials may be missing information This patch changes the code to: 1 - push all issues that were checked to the report when a borrower wants a digest 2 - adds a variable to track when any of the issues has been updated, and checkes this when sending digests 3 - if nothing has been updated, no report is sent to the patron To test: 1 - Checkout an item, marked for autorenewal, backdated to be overdue to a patron 2 - Set preferences AutoRenewalNotices = 'according to patron messaging preferences' EnhancedMessagingPreferences = 'Allow' 3 - Set the patrons preference for auto renewal to email+digest 4 - Ensure the patron has an email 5 - Place an item level hold for another patron on the issued item 6 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 7 - Check patron record/notices tab 8 - Note item not renewed, patron notified 9 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 10 - Note item not renewed, status not changed, patron notified again 11 - Apply patch 12 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 13 - Item not renewed, patron no notified 14 - Checkout another item marked for auto renewal to the patron, but due in the future ensure it is outside of 'no renewal before' 15 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 16 - Patron not notified, items not renewd Change to status of 'auto_too_soon' is not notified 17 - Checkout a third item, marked for auto renew, overdue 18 - place an item level hold for another patorn on third item 19 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 20 - patron is notified, nothing renewed, all statuses reported 21 - cancel the item level hold on third item 22 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 23 - item renewed, patron notified, all statuses reported 24 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 25 - nothing renewed, patron not notified, only change is one issue 'auto_too_soon' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131587&action=edit Bug 30222: Simplify logic for reporting This patch adds two new variables: $wants_email and $wants digest These are used to simplify checks on whether notices should be sent To test: 1 - Apply patch 2 - Confirm notices are not sent of pref is 'cron' and send_notcies flag not set 3 - Confirm notices are sent if pref is cron and send_notices flag is set and borrower does not have preference set for auto renewals 4 - Confirm notices not sent if pref is set to follow messaging preference and borrower does not have preferences set for auto_renewals 5 - Confirm regular notices sent if pref is set to follow messaging preferences and borrower does have the preference set but not digest 6 - Confirm digest notices sent if pref is set to follow messaging preferences and borrower does have the preference set and wants digest -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30278 [Bug 30278] Auto renewal should be moved to an object method -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm getting errors when running the cron with the patches, step 13 of the first test plan: root@kohadevbox:koha(master)$ perl misc/cronjobs/automatic_renewals.pl -v --confirm Scalar found where operator expected at misc/cronjobs/automatic_renewals.pl line 151, near ") $wants_email" (Missing operator before $wants_email?) "my" variable $auto_renew masks earlier declaration in same statement at misc/cronjobs/automatic_renewals.pl line 165. syntax error at misc/cronjobs/automatic_renewals.pl line 151, near ") $wants_email " Global symbol "$wants_digest" requires explicit package name (did you forget to declare "my $wants_digest"?) at misc/cronjobs/automatic_renewals.pl line 155. Global symbol "$wants_email" requires explicit package name (did you forget to declare "my $wants_email"?) at misc/cronjobs/automatic_renewals.pl line 157. Global symbol "$borrower_preferences" requires explicit package name (did you forget to declare "my $borrower_preferences"?) at misc/cronjobs/automatic_renewals.pl line 157. syntax error at misc/cronjobs/automatic_renewals.pl line 158, near "}" Global symbol "$wants_email" requires explicit package name (did you forget to declare "my $wants_email"?) at misc/cronjobs/automatic_renewals.pl line 165. Can't redeclare "my" in "my" at misc/cronjobs/automatic_renewals.pl line 166, near "my" Global symbol "$wants_digest" requires explicit package name (did you forget to declare "my $wants_digest"?) at misc/cronjobs/automatic_renewals.pl line 178. Global symbol "$wants_digest" requires explicit package name (did you forget to declare "my $wants_digest"?) at misc/cronjobs/automatic_renewals.pl line 197. Global symbol "$wants_digest" requires explicit package name (did you forget to declare "my $wants_digest"?) at misc/cronjobs/automatic_renewals.pl line 201. syntax error at misc/cronjobs/automatic_renewals.pl line 216, near "}" misc/cronjobs/automatic_renewals.pl has too many errors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131586|0 |1 is obsolete| | Attachment #131587|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131659&action=edit Bug 30222: Only send auto renewal digest wehn there is an update Currently, the code sends an email to the patron when there is any error that is not 'too_soon' - we also don't include issues that are 'too_soon', so emials may be missing information This patch changes the code to: 1 - push all issues that were checked to the report when a borrower wants a digest 2 - adds a variable to track when any of the issues has been updated, and checkes this when sending digests 3 - if nothing has been updated, no report is sent to the patron To test: 1 - Checkout an item, marked for autorenewal, backdated to be overdue to a patron 2 - Set preferences AutoRenewalNotices = 'according to patron messaging preferences' EnhancedMessagingPreferences = 'Allow' 3 - Set the patrons preference for auto renewal to email+digest 4 - Ensure the patron has an email 5 - Place an item level hold for another patron on the issued item 6 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 7 - Check patron record/notices tab 8 - Note item not renewed, patron notified 9 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 10 - Note item not renewed, status not changed, patron notified again 11 - Apply patch 12 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 13 - Item not renewed, patron no notified 14 - Checkout another item marked for auto renewal to the patron, but due in the future ensure it is outside of 'no renewal before' 15 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 16 - Patron not notified, items not renewd Change to status of 'auto_too_soon' is not notified 17 - Checkout a third item, marked for auto renew, overdue 18 - place an item level hold for another patorn on third item 19 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 20 - patron is notified, nothing renewed, all statuses reported 21 - cancel the item level hold on third item 22 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 23 - item renewed, patron notified, all statuses reported 24 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 25 - nothing renewed, patron not notified, only change is one issue 'auto_too_soon' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131660&action=edit Bug 30222: Simplify logic for reporting This patch adds two new variables: $wants_email and $wants digest These are used to simplify checks on whether notices should be sent To test: 1 - Apply patch 2 - Confirm notices are not sent of pref is 'cron' and send_notcies flag not set 3 - Confirm notices are sent if pref is cron and send_notices flag is set and borrower does not have preference set for auto renewals 4 - Confirm notices not sent if pref is set to follow messaging preference and borrower does not have preferences set for auto_renewals 5 - Confirm regular notices sent if pref is set to follow messaging preferences and borrower does have the preference set but not digest 6 - Confirm digest notices sent if pref is set to follow messaging preferences and borrower does have the preference set and wants digest -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131659|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131662&action=edit Bug 30222: Only send auto renewal digest wehn there is an update Currently, the code sends an email to the patron when there is any error that is not 'too_soon' - we also don't include issues that are 'too_soon', so emials may be missing information This patch changes the code to: 1 - push all issues that were checked to the report when a borrower wants a digest 2 - adds a variable to track when any of the issues has been updated, and checkes this when sending digests 3 - if nothing has been updated, no report is sent to the patron To test: 1 - Checkout an item, marked for autorenewal, backdated to be overdue to a patron 2 - Set preferences AutoRenewalNotices = 'according to patron messaging preferences' EnhancedMessagingPreferences = 'Allow' 3 - Set the patrons preference for auto renewal to email+digest 4 - Ensure the patron has an email 5 - Place an item level hold for another patron on the issued item 6 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 7 - Check patron record/notices tab 8 - Note item not renewed, patron notified 9 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 10 - Note item not renewed, status not changed, patron notified again 11 - Apply patch 12 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 13 - Item not renewed, patron no notified 14 - Checkout another item marked for auto renewal to the patron, but due in the future ensure it is outside of 'no renewal before' 15 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 16 - Patron not notified, items not renewd Change to status of 'auto_too_soon' is not notified 17 - Checkout a third item, marked for auto renew, overdue 18 - place an item level hold for another patorn on third item 19 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 20 - patron is notified, nothing renewed, all statuses reported 21 - cancel the item level hold on third item 22 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 23 - item renewed, patron notified, all statuses reported 24 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 25 - nothing renewed, patron not notified, only change is one issue 'auto_too_soon' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131660|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131663&action=edit Bug 30222: Simplify logic for reporting This patch adds two new variables: $wants_email and $wants digest These are used to simplify checks on whether notices should be sent To test: 1 - Apply patch 2 - Confirm notices are not sent of pref is 'cron' and send_notcies flag not set 3 - Confirm notices are sent if pref is cron and send_notices flag is set and borrower does not have preference set for auto renewals 4 - Confirm notices not sent if pref is set to follow messaging preference and borrower does not have preferences set for auto_renewals 5 - Confirm regular notices sent if pref is set to follow messaging preferences and borrower does have the preference set but not digest 6 - Confirm digest notices sent if pref is set to follow messaging preferences and borrower does have the preference set and wants digest -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> ---
4 - Confirm notices not sent if pref is set to follow messaging preference and borrower does not have preferences set for auto_renewals
My patron got a non-digest auto-renew notice via email at this step, with the syspref set to follow patron messaging prefs and the patron's messaging prefs set to receive no auto-renew notice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131721&action=edit Bug 30222: Further simplify logic For any borrower, we are either: 1 - following their preference, and that should set 'wants_email' OR 2 - Never sending / following the cron, and can determine 'wants_email' from the 'send_notices' variable This patch adds an 'else' if not using preferences to accomplish this Follow test plan on previous patches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131662|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 131728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131728&action=edit Bug 30222: Only send auto renewal digest wehn there is an update Currently, the code sends an email to the patron when there is any error that is not 'too_soon' - we also don't include issues that are 'too_soon', so emials may be missing information This patch changes the code to: 1 - push all issues that were checked to the report when a borrower wants a digest 2 - adds a variable to track when any of the issues has been updated, and checkes this when sending digests 3 - if nothing has been updated, no report is sent to the patron To test: 1 - Checkout an item, marked for autorenewal, backdated to be overdue to a patron 2 - Set preferences AutoRenewalNotices = 'according to patron messaging preferences' EnhancedMessagingPreferences = 'Allow' 3 - Set the patrons preference for auto renewal to email+digest 4 - Ensure the patron has an email 5 - Place an item level hold for another patron on the issued item 6 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 7 - Check patron record/notices tab 8 - Note item not renewed, patron notified 9 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 10 - Note item not renewed, status not changed, patron notified again 11 - Apply patch 12 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 13 - Item not renewed, patron no notified 14 - Checkout another item marked for auto renewal to the patron, but due in the future ensure it is outside of 'no renewal before' 15 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 16 - Patron not notified, items not renewd Change to status of 'auto_too_soon' is not notified 17 - Checkout a third item, marked for auto renew, overdue 18 - place an item level hold for another patorn on third item 19 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 20 - patron is notified, nothing renewed, all statuses reported 21 - cancel the item level hold on third item 22 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 23 - item renewed, patron notified, all statuses reported 24 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 25 - nothing renewed, patron not notified, only change is one issue 'auto_too_soon' Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131663|0 |1 is obsolete| | --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 131729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131729&action=edit Bug 30222: Simplify logic for reporting This patch adds two new variables: $wants_email and $wants digest These are used to simplify checks on whether notices should be sent To test: 1 - Apply patch 2 - Confirm notices are not sent of pref is 'cron' and send_notcies flag not set 3 - Confirm notices are sent if pref is cron and send_notices flag is set and borrower does not have preference set for auto renewals 4 - Confirm notices not sent if pref is set to follow messaging preference and borrower does not have preferences set for auto_renewals 5 - Confirm regular notices sent if pref is set to follow messaging preferences and borrower does have the preference set but not digest 6 - Confirm digest notices sent if pref is set to follow messaging preferences and borrower does have the preference set and wants digest Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131721|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 131730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131730&action=edit Bug 30222: Further simplify logic For any borrower, we are either: 1 - following their preference, and that should set 'wants_email' OR 2 - Never sending / following the cron, and can determine 'wants_email' from the 'send_notices' variable This patch adds an 'else' if not using preferences to accomplish this Follow test plan on previous patches Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- IMO no more change should be done to this script before its code is moved and covered by tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #13)
IMO no more change should be done to this script before its code is moved and covered by tests.
I understand the need to move this code and add tests for it, but at the same time this is a very real and immediate pain point for users and I would not like to see this fix delayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #14)
(In reply to Jonathan Druart from comment #13)
IMO no more change should be done to this script before its code is moved and covered by tests.
I understand the need to move this code and add tests for it, but at the same time this is a very real and immediate pain point for users and I would not like to see this fix delayed.
I agree with Andrew, this bug is causing patrons to receive unnecessary emails every day and becoming very painful for libraries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- This bug is causing hundreds, if not thousands, of erroneous emails to be sent each day for some libraries. This leaves them with no choice but to turn off the auto-renewal feature altogether until this fix arrives. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18532 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Is this a regression from bug 29381 or the problem exists since the introduction of the feature (bug 18532)? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Quoting myself: Bug 18532 comment 97 """ This script would have benefit *a lot* from having the code in a module, covered by tests. Any additional enhancements to this file must take into account this move. """ Bug 29381 comment 12 """ There is a terrible lack of tests in this area :-/ """ I know I am grumpy and complaining for everything, by maybe sometimes what I am saying makes sense... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> ---
I know I am grumpy and complaining for everything, by maybe sometimes what I am saying makes sense...
You are not wrong or grumpy! Having tests in this area would have likely prevented this kind of regression from happening in the first place. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #20 from AspenCat Team <aspencatteam@clicweb.org> --- Just wanted to comment that this is a big deal for our patrons. The goal is to get as few emails as possible, which is why we switched to the digest. Due to this bug the digest is now sending these extra emails and patrons are forced to decide which way they receive unwanted emails, by receiving them for each individual item or getting this unable to renew message in digest format over and over again. Is there anything we can do to get this pushed through the community? - Bob Bennhoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131728|0 |1 is obsolete| | Attachment #131729|0 |1 is obsolete| | Attachment #131730|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132205&action=edit Bug 30222: Only send auto renewal digest wehn there is an update Currently, the code sends an email to the patron when there is any error that is not 'too_soon' - we also don't include issues that are 'too_soon', so emials may be missing information This patch changes the code to: 1 - push all issues that were checked to the report when a borrower wants a digest 2 - adds a variable to track when any of the issues has been updated, and checkes this when sending digests 3 - if nothing has been updated, no report is sent to the patron To test: 1 - Checkout an item, marked for autorenewal, backdated to be overdue to a patron 2 - Set preferences AutoRenewalNotices = 'according to patron messaging preferences' EnhancedMessagingPreferences = 'Allow' 3 - Set the patrons preference for auto renewal to email+digest 4 - Ensure the patron has an email 5 - Place an item level hold for another patron on the issued item 6 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 7 - Check patron record/notices tab 8 - Note item not renewed, patron notified 9 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 10 - Note item not renewed, status not changed, patron notified again 11 - Apply patch 12 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 13 - Item not renewed, patron no notified 14 - Checkout another item marked for auto renewal to the patron, but due in the future ensure it is outside of 'no renewal before' 15 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 16 - Patron not notified, items not renewd Change to status of 'auto_too_soon' is not notified 17 - Checkout a third item, marked for auto renew, overdue 18 - place an item level hold for another patorn on third item 19 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 20 - patron is notified, nothing renewed, all statuses reported 21 - cancel the item level hold on third item 22 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 23 - item renewed, patron notified, all statuses reported 24 - perl misc/cronjobs/automatic_renewals.pl -v --confirm 25 - nothing renewed, patron not notified, only change is one issue 'auto_too_soon' Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132206&action=edit Bug 30222: Simplify logic for reporting This patch adds two new variables: $wants_email and $wants digest These are used to simplify checks on whether notices should be sent To test: 1 - Apply patch 2 - Confirm notices are not sent of pref is 'cron' and send_notcies flag not set 3 - Confirm notices are sent if pref is cron and send_notices flag is set and borrower does not have preference set for auto renewals 4 - Confirm notices not sent if pref is set to follow messaging preference and borrower does not have preferences set for auto_renewals 5 - Confirm regular notices sent if pref is set to follow messaging preferences and borrower does have the preference set but not digest 6 - Confirm digest notices sent if pref is set to follow messaging preferences and borrower does have the preference set and wants digest Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132207&action=edit Bug 30222: Further simplify logic For any borrower, we are either: 1 - following their preference, and that should set 'wants_email' OR 2 - Never sending / following the cron, and can determine 'wants_email' from the 'send_notices' variable This patch adds an 'else' if not using preferences to accomplish this Follow test plan on previous patches Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132208&action=edit Bug 30222: Remove warning Use of uninitialized value in string ne at misc/cronjobs/automatic_renewals.pl line 193. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132208|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Comment on attachment 132208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132208 Bug 30222: Remove warning Hum, not sure about this patch actually. But we should remove the warning. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132209&action=edit Bug 30222: Remove warning Use of uninitialized value in string ne at misc/cronjobs/automatic_renewals.pl line 193. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Nick, this patch looks correct, but I may be missing why you didn't keep it like it was before. Can you double check it please? In doubt, obsolete it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #27)
Nick, this patch looks correct, but I may be missing why you didn't keep it like it was before.
Can you double check it please? In doubt, obsolete it.
$auto_renew->auto_renew_error is the result of last run, or renewal has not been attempted previously. In either case, it means that current run either: 1 - renewed it, so remains unset 2 - didn't renew it and we need to update it Either case means the issue was update and belongs in the report, and avoids checking an undef value against $error if it has value we should compare to $error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #29 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.05 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.05 |22.05.00,21.11.05,21.05.14 released in| | --- Comment #31 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #32 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 20.11.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 [Bug 30755] too_soon should not be counted as an error in autorenewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30755 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org