https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Just curious, why push, push, unshift for the options for the dropdown? Could you just define them all at once or push the empty option first? I think the bigger issue is that the values will not be translatable, failing for this You also change the check for empty fields from a truth check to only assigning if not empty string, then checking if defined, is there a reason for that? -- You are receiving this mail because: You are watching all bug changes.