https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36550 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189821|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 189822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189822&action=edit Bug 36550: allow defaults to be defined for koha-elasticsearch koha-elasticsearch only allows the parameters to be specified on the command line, otherwise it'll fall back to values hard-coded in the script. This allows default parameters to be defined in /etc/default/koha-common when installed with the Debian packages. It also copies the current defaults into the defaults file. Test plan, comprehensive: 1. You will need a package setup with elasticsearch, and some records. 2. Build a package (or copy the files modified in this patch over ones you might already have installed) 3. Modify some ES_* values in /etc/default/koha-community to your liking. 'ES_VERBOSE' might be a good one. 4. Do an elasticsearch reindex and observe that your parameter defaults are respected. Test plan, simple: 1. With a git checkout: * `sudo ln -s .../koha/debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh` * `sudo ln -s .../koha/debian/koha-common.default /etc/default/koha-common` 2. Modify `.../koha/debian/scripts/koha-elasticsearch` around line 200 so that it prints out the variables, and see that it properly respects modifying the defaults and/or setting the command line arguments. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.