https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Testing again to add another signoff to be less out of bounds regarding to:
If a patch is not passed QA for one month, then someone from the same company or institution as the patch author can QA it, as long as the patch signer is from another company or institution. The RM can still ask for a second sign-off in this case. https://wiki.koha-community.org/wiki/Development_workflow#Rules
----- It works! :) I don't know how to actually test EDIFACT to confirm a valid ean is picked and that it will work irl but here is a circumvention: Compare the POST request which leads to the page "Are you sure you want to generate an EDIFACT order and close basket My Basket?" With and without the patch, we end up with the same params so the rest of the workflow should continue working :) ----- Looking at the code, there is a path for [% IF eans.count == 1 %] but it somehow doesn't get executed when I have only one ean. I still have the dropdown and it has one element :o [% eans.count %] doesn't display anything. With one or two eans. ---- When having no Library EAN the dropdown is there but it's empty. Which doesn't look great UI wise. And UX wise it makes the process less discoverable than the old page that said:
Select the library account submitting the EDI order Select ordering library account:
Which was a hint (not great but still a hint) that one should go to "Library EANs" page and create an EAN. -- You are receiving this mail because: You are watching all bug changes.