[Bug 37993] New: Having a single EDI EAN account produces a bad redirect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Bug ID: 37993 Summary: Having a single EDI EAN account produces a bad redirect Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In acqui/edi_ean.pl: if ( @eans == 1 ) { my $ean = $eans[0]->ean; print $query->redirect( "/cgi-bin/koha/acqui/basket.pl?basketno=$basketno&op=cud-ediorder&ean=$ean" ); } So if you only have the single 'Library EAN' account Koha redirects to: /cgi-bin/koha/acqui/basket.pl?basketno=$basketno&op=cud-ediorder&ean=$ean This causes an error "op 'cud-ediorder' must not start with cud-" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36192 CC| |phil@chetcolibrary.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Carolyn Hughesman <chughesman@cclsny.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chughesman@cclsny.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- *** Bug 38401 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Minimal test plan: 1. Enable the EDIFACT syspref 2. Add a Library EAN: Administration > Library EANs 3. Add an EDI account for a vendor: Administration > EDI accounts 4. Go to a basket 5. click "Create EDIFACT order" 6. Error 403 Programming error - op 'cud-ediorder' must not start with 'cud-' for GET http://localhost:8081/intranet/acqui/basket.pl?basketno=1&op=cud-ediorder&ean=11111 (referer: http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=1) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175024&action=edit Bug 37993: Replace edi_ean link with dropdown The edi_ean page is a slim page with a single select input for selecting the appropriate library and ean. This patch replaces the link to that page with a simple select in the menu on the original page instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175025&action=edit Bug 37993: Remove edi_ean page In the previous patch we replace the only link to the edi_ean selection page with a select list embedded in the page. As such, we no longer need this page at all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175024|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 175026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175026&action=edit Bug 37993: Replace edi_ean link with dropdown The edi_ean page is a slim page with a single select input for selecting the appropriate library and ean. This patch replaces the link to that page with a simple select in the menu on the original page instead. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175025|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 175027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175027&action=edit Bug 37993: Remove edi_ean page In the previous patch we replace the only link to the edi_ean selection page with a select list embedded in the page. As such, we no longer need this page at all. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@ptfs-europe |y.org |.com CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175026|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175042&action=edit Bug 37993: Replace edi_ean link with dropdown The edi_ean page is a slim page with a single select input for selecting the appropriate library and ean. This patch replaces the link to that page with a simple select in the menu on the original page instead. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175027|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175043&action=edit Bug 37993: Remove edi_ean page In the previous patch we replace the only link to the edi_ean selection page with a select list embedded in the page. As such, we no longer need this page at all. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175044&action=edit Bug 37993: (QA follow-up): Add missing data for breadcrumbs The vendor name was missing from the breadcrumbs, this patch adds it back in Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Small fix added to address missing data in the breadcrumbs but otherwise the QA script is happy and all works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Testing again to add another signoff to be less out of bounds regarding to:
If a patch is not passed QA for one month, then someone from the same company or institution as the patch author can QA it, as long as the patch signer is from another company or institution. The RM can still ask for a second sign-off in this case. https://wiki.koha-community.org/wiki/Development_workflow#Rules
----- It works! :) I don't know how to actually test EDIFACT to confirm a valid ean is picked and that it will work irl but here is a circumvention: Compare the POST request which leads to the page "Are you sure you want to generate an EDIFACT order and close basket My Basket?" With and without the patch, we end up with the same params so the rest of the workflow should continue working :) ----- Looking at the code, there is a path for [% IF eans.count == 1 %] but it somehow doesn't get executed when I have only one ean. I still have the dropdown and it has one element :o [% eans.count %] doesn't display anything. With one or two eans. ---- When having no Library EAN the dropdown is there but it's empty. Which doesn't look great UI wise. And UX wise it makes the process less discoverable than the old page that said:
Select the library account submitting the EDI order Select ordering library account:
Which was a hint (not great but still a hint) that one should go to "Library EANs" page and create an EAN. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #12 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 175069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175069&action=edit Bug 37993: (QA follow-up) Use submit form link asset guideline JS16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #13 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 175070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175070&action=edit Bug 37993: (QA follow-up) Add a hint/warning when no EANs are defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for the follow-ups here guys, nice bit of golfing and some solid improvements made. I'll properly review the follow-ups and add my own stamp back and then reset to PQA.. thanks again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175042|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175072&action=edit Bug 37993: Replace edi_ean link with dropdown The edi_ean page is a slim page with a single select input for selecting the appropriate library and ean. This patch replaces the link to that page with a simple select in the menu on the original page instead. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175043|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175073&action=edit Bug 37993: Remove edi_ean page In the previous patch we replace the only link to the edi_ean selection page with a select list embedded in the page. As such, we no longer need this page at all. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175044|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175074&action=edit Bug 37993: (QA follow-up): Add missing data for breadcrumbs The vendor name was missing from the breadcrumbs, this patch adds it back in Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175069|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175075&action=edit Bug 37993: (QA follow-up) Use submit form link asset guideline JS16 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175070|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175076&action=edit Bug 37993: (QA follow-up) Add a hint/warning when no EANs are defined Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|matt.blenkinsop@ptfs-europe |nick@bywatersolutions.com |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- OK acqui/basket.pl FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt FAIL spelling diasbled ==> disabled QA tools complain, but fixing this typo might have an unwanted effect? Please verify! <a title="You must define an EAN in Administration -> Library EANs" class="btn btn-default btn-xs" diasbled="disabled" href="#"><i class="fa fa-download"></i> Create EDIFACT order</a> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #20)
OK acqui/basket.pl
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt FAIL spelling diasbled ==> disabled
QA tools complain, but fixing this typo might have an unwanted effect? Please verify!
<a title="You must define an EAN in Administration -> Library EANs" class="btn btn-default btn-xs" diasbled="disabled" href="#"><i class="fa fa-download"></i> Create EDIFACT order</a>
Nah, it's just a typo.. needs fixing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175081&action=edit Bug 37993: (QA follow-up) Fix Typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize (ashimema) from comment #21)
(In reply to Katrin Fischer from comment #20)
OK acqui/basket.pl
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt FAIL spelling diasbled ==> disabled
QA tools complain, but fixing this typo might have an unwanted effect? Please verify!
<a title="You must define an EAN in Administration -> Library EANs" class="btn btn-default btn-xs" diasbled="disabled" href="#"><i class="fa fa-download"></i> Create EDIFACT order</a>
Nah, it's just a typo.. needs fixing.
OK, was worried it would make the "disabled" work when it wasn't before blocking something. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks all, nice team work :D ----- Does anyone else when having no library EAN account doesn't see the tooltip on the "create EDIFACT order" button when clicking on it? Clicking prevents the tooltip from appearing on Firefox and Chromium. As a result when trying to use the button, I almost never see the tooltip. I have to voluntarily over on it. So basically know that there is a tooltip there. Which mean knowing in advance the issue the tooltip is warning about. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175132&action=edit Bug 37993: (QA follow-up) Fix tooltip and disabled display This patch re-arranges the button markup slightly to properly style the disabled 'Create EDI Order' button when there are no EAN's defined for the library. It also moves the tooltip to the container btn-group element to ensure the tooltip works even though the button itself is disabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- All good here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes creating an release notes| |EDIFACT order for a basket | |in acquisitions - if there | |was only one library EAN | |defined, then a 403 page | |error was generated. It | |also simplifies creating an | |EDIFACT order: | |- If there | |are no library EANs | |defined, the "Create | |EDIFACT order" button is | |greyed out and has a | |tooltip "You must define an | |EAN in Administration > | |Library EANs". | |- If there | |is only one library EAN | |defined, you are prompted | |to generate the order | |without needing to select | |an EAN. | |- If there is more | |than one library EAN, the | |"Create EDIFACT order" | |button incorporates a | |dropdown list with the | |available library EANs. | |(The error is related to | |the CSRF changes added in | |Koha 24.05 to improve form | |security.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 --- Comment #29 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Bug 37993 depends on bug 36192, which changed state. Bug 36192 Summary: [OMNIBUS] CSRF Protection for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #30 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Martin, Just testing this for 24.05.x backport. Cherry-picking the second patch from 24.11.x onto 24.05.x conflicts (see below). Would you mind please attaching rebased 24.05.x patches to this bug report? ---- kohadev-koha@kohadevbox:koha(24.05.x)$ git cherry-pick 4dcaef65ca9595663fcc0ba6e4b6208eb92ac893 CONFLICT (modify/delete): koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edi_ean.tt deleted in 4dcaef65ca9 (Bug 37993: Remove edi_ean page) and modified in HEAD. Version HEAD of koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edi_ean.tt left in tree. error: could not apply 4dcaef65ca9... Bug 37993: Remove edi_ean page hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". kohadev-koha@kohadevbox:koha(24.05.x|CHERRY-PICKING)$ git status On branch 24.05.x You are currently cherry-picking commit 4dcaef65ca9. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: deleted: acqui/edi_ean.pl Unmerged paths: (use "git add/rm <file>..." as appropriate to mark resolution) deleted by them: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edi_ean.tt kohadev-koha@kohadevbox:koha(24.05.x|CHERRY-PICKING)$ ---- Many thanks in advance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #31 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 [Bug 39787] Sending EDI order from basket fails if only one Library EAN exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #32 from Andrii Nugged <nugged@gmail.com> --- Consider there is Bug 39787, caused by current one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 [Bug 39572] Create EDIFACT order button no longer gives librarians chance to review -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39787 Depends on|39787 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39787 [Bug 39787] Sending EDI order from basket fails if only one Library EAN exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting --- Comment #33 from David Nind <david@davidnind.com> --- Changes to the UI, changing status back to needs documenting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #34 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix to restore expected behaviour. Noting to add or edit in the Koha manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org