https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191562&action=edit Bug 41623: (follow-up) Correct JS variable name This patch fixes the variable name meant to display the circulation desk name when the waiting hold was checked in at a specific circ desk. A revised test plan to test this specific case: - Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA - Log in to the staff client and set your circulation desk - Requires that the UseCirculationDesks preference is enabled and at least one desk is defined in Administration -> Desks. - Place a hold to be picked up at your logged-in library - Check in the item on hold and confirm the hold - Go to the record details page. In the holdings table you should see this under "Status" for that item: --> "Waiting at [library], undefined since [date]." - Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." - Apply patch - Update strings again - Check translation files again --> The string should be there - Translate the string (making sure to remove the fuzzy line if any) - Install the translation again (only the translate install part) - Check the record details page again. You should now see: --> "Waiting at [library], [desk] since [date]." Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.