[Bug 41623] New: Missing translation string in catalogue_detail.inc (again)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Bug ID: 41623 Summary: Missing translation string in catalogue_detail.inc (again) Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com Jonathan did a change to the strings in bug 38450 and this change was overwritten in bug 37334. Probably a rebase error or something like that... In short, Waiting at ... since ... in the record details is not translatables since at least 25.05 (probably 24.11.08 also since both were backported to that version). To recreate: 1. Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA 2. Place a hold 3. Check in the item on hold and confirm the hold 4. Go to the record details page --> Waiting at ... since ... is in English 5. Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37334, 38450 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 [Bug 37334] Cannot filter holdings table by status https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38450 [Bug 38450] Missing translation string in catalogue_detail.inc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 191479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191479&action=edit Bug 41623 : Fix translation pickup in catalogue_details.inc This patch redoes the fix that was made in bug 38450 to make sure the "Waiting at ... since ..." string is picked up by the translation tool. It's a parenthesis move. See bug 38450 for explanation. _("This %s is picked").format(foo) _("This %s is NOT picked".format(bar)) To test: 1. Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA 2. Place a hold 3. Check in the item on hold and confirm the hold 4. Go to the record details page --> Waiting at ... since ... is in English 5. Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." 6. Apply patch 7. Update strings again 8. Check translation files again --> The string should be there 9. Translate the string (making sure to remove the fuzzy line if any) 10. Install the translation again (only the translate install part) 11. Check the record details page --> It should be translated! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191479|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191483&action=edit Bug 41623: Fix translation pickup in catalogue_details.inc This patch redoes the fix that was made in bug 38450 to make sure the "Waiting at ... since ..." string is picked up by the translation tool. It's a parenthesis move. See bug 38450 for explanation. _("This %s is picked").format(foo) _("This %s is NOT picked".format(bar)) To test: 1. Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA 2. Place a hold 3. Check in the item on hold and confirm the hold 4. Go to the record details page --> Waiting at ... since ... is in English 5. Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." 6. Apply patch 7. Update strings again 8. Check translation files again --> The string should be there 9. Translate the string (making sure to remove the fuzzy line if any) 10. Install the translation again (only the translate install part) 11. Check the record details page --> It should be translated! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191484&action=edit Bug 41623: (follow-up) Correct JS variable name This patch fixes the variable name meant to display the circulation desk name when the waiting hold was checked in at a specific circ desk. A revised test plan to test this specific case: - Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA - Log in to the staff client and set your circulation desk - Requires that the UseCirculationDesks preference is enabled and at least one desk is defined in Administration -> Desks. - Place a hold to be picked up at your logged-in library - Check in the item on hold and confirm the hold - Go to the record details page. In the holdings table you should see this under "Status" for that item: --> "Waiting at [library], undefined since [date]." - Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." - Apply patch - Update strings again - Check translation files again --> The string should be there - Translate the string (making sure to remove the fuzzy line if any) - Install the translation again (only the translate install part) - Check the record details page again. You should now see: --> "Waiting at [library], [desk] since [date]." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191484|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 191504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191504&action=edit Bug 41623: (follow-up) Correct JS variable name This patch fixes the variable name meant to display the circulation desk name when the waiting hold was checked in at a specific circ desk. A revised test plan to test this specific case: - Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA - Log in to the staff client and set your circulation desk - Requires that the UseCirculationDesks preference is enabled and at least one desk is defined in Administration -> Desks. - Place a hold to be picked up at your logged-in library - Check in the item on hold and confirm the hold - Go to the record details page. In the holdings table you should see this under "Status" for that item: --> "Waiting at [library], undefined since [date]." - Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." - Apply patch - Update strings again - Check translation files again --> The string should be there - Translate the string (making sure to remove the fuzzy line if any) - Install the translation again (only the translate install part) - Check the record details page again. You should now see: --> "Waiting at [library], [desk] since [date]." Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191483|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191504|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191561&action=edit Bug 41623: Fix translation pickup in catalogue_details.inc This patch redoes the fix that was made in bug 38450 to make sure the "Waiting at ... since ..." string is picked up by the translation tool. It's a parenthesis move. See bug 38450 for explanation. _("This %s is picked").format(foo) _("This %s is NOT picked".format(bar)) To test: 1. Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA 2. Place a hold 3. Check in the item on hold and confirm the hold 4. Go to the record details page --> Waiting at ... since ... is in English 5. Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." 6. Apply patch 7. Update strings again 8. Check translation files again --> The string should be there 9. Translate the string (making sure to remove the fuzzy line if any) 10. Install the translation again (only the translate install part) 11. Check the record details page --> It should be translated! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191562&action=edit Bug 41623: (follow-up) Correct JS variable name This patch fixes the variable name meant to display the circulation desk name when the waiting hold was checked in at a specific circ desk. A revised test plan to test this specific case: - Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA - Log in to the staff client and set your circulation desk - Requires that the UseCirculationDesks preference is enabled and at least one desk is defined in Administration -> Desks. - Place a hold to be picked up at your logged-in library - Check in the item on hold and confirm the hold - Go to the record details page. In the holdings table you should see this under "Status" for that item: --> "Waiting at [library], undefined since [date]." - Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." - Apply patch - Update strings again - Check translation files again --> The string should be there - Translate the string (making sure to remove the fuzzy line if any) - Install the translation again (only the translate install part) - Check the record details page again. You should now see: --> "Waiting at [library], [desk] since [date]." Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks for the quick QA Jonathan! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 | released in| | --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Note for rmaints, this was broken since at least 25.05.00 and probably 24.11.08 (haven't checked but the original fix and the unfix were both backported to 24.11). If it could be backported, it would be great! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)| |25.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 --- Comment #11 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Bug 41623 depends on bug 38450, which changed state. Bug 38450 Summary: Missing translation string in catalogue_detail.inc https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38450 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.02 |25.11.02,25.05.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.07 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Correction: This was pushed to 25.05.x based on 25.05.08 (not 25.05.07 as previously noted). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Bug 41623 depends on bug 37334, which changed state. Bug 37334 Summary: Cannot filter holdings table by status https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Follow-up applied, desk_name does not exist in 24.11 too. Content of the first patch is already present in 24.11.x. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.02,25.05.09 |25.11.02,25.05.09,24.11.14 released in| | Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41623 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #16 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to change in the manual. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org