https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #169 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, first review here: 1) QA tools: FAIL cataloguing/additem.pl FAIL valid "my" variable $item masks earlier declaration in same scope 2) Unit tests Ran the database update, but tests are failing: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. 33/41 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry 'OPLKEwkZw0DMeIN2d05GnFYtiGaCnqBtN4N03FSuWrNz' for key 'userid' [for Statement "UPDATE `borrowers` SET `userid` = ? WHERE ( `borrowernumber` = ? )" with ParamValues: 0='OPLKEwkZw0DMeIN2d05GnFYtiGaCnqBtN4N03FSuWrNz', 1='199'] at /home/vagrant/kohaclone/Koha/Object.pm line 166 t/db_dependent/Koha/Patrons.t .. 42/41 # Looks like you planned 41 tests but ran 42. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 255 (wstat 65280, 0xff00) All 41 subtests passed Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 65280 Tests: 42 Failed: 1) Failed test: 42 Non-zero exit status: 255 Parse errors: Bad plan. You planned 41 tests but ran 42. 3) Methods libraries_where_can_see_patrons is added to Patron.pm I am not sure how it fits into this functionality, maybe a leftover from an earlier development? 4) Item edit checks I think we might also need a check on the permission from the item search edit item link. -- You are receiving this mail because: You are watching all bug changes.