[Bug 20256] New: Development: Limit view/edit of patrons and items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Bug ID: 20256 Summary: Development: Limit view/edit of patrons and items to home library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jesse@bywatersolutions.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org A.) Base work off of bug 18403 B.) Add limit for items in similar manner that 18403 does for patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Development: Limit |Development: Limit |view/edit of patrons and |view/edit of items to home |items to home library |library CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Assignee|jesse@bywatersolutions.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Development: Limit |Add ability to limit |view/edit of items to home |editing of items to home |library |library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87226&action=edit Bug 20256: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87227&action=edit Bug 20256: Add new permission to editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87228&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87229&action=edit Bug 20256: Add new methods for checking item editing permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87230&action=edit Bug 20256: Update Schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87231&action=edit Bug 20256: Update groups editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87232&action=edit Bug 20256: Use new methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87233&action=edit Bug 20256: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Needs a test plan... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87226|0 |1 is obsolete| | Attachment #87227|0 |1 is obsolete| | Attachment #87228|0 |1 is obsolete| | Attachment #87229|0 |1 is obsolete| | Attachment #87230|0 |1 is obsolete| | Attachment #87231|0 |1 is obsolete| | Attachment #87232|0 |1 is obsolete| | Attachment #87233|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87262&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87262|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87263&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87264&action=edit Bug 20256: Add new permission to editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87265&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87266&action=edit Bug 20256: Add new methods for checking item editing permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87267&action=edit Bug 20256: Update Schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87268&action=edit Bug 20256: Update groups editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87269&action=edit Bug 20256: Use new methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87270&action=edit Bug 20256: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87263|0 |1 is obsolete| | Attachment #87264|0 |1 is obsolete| | Attachment #87265|0 |1 is obsolete| | Attachment #87266|0 |1 is obsolete| | Attachment #87267|0 |1 is obsolete| | Attachment #87268|0 |1 is obsolete| | Attachment #87269|0 |1 is obsolete| | Attachment #87270|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88537&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88537|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88539&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88541&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88542&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88543&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88544&action=edit Bug 20256: Update Schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88545&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88546&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88547&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #28 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 88546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88546 Bug 20256: Use new methods Review of attachment 88546: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20256&attachment=88546) ----------------------------------------------------------------- ::: C4/Items.pm @@ +1746,4 @@
$status = "book_on_loan"; } elsif ( defined C4::Context->userenv + and !Koha::Patrons->find( C4::Context->userenv->{number} )->can_edit_item( $item ) )
What if patron does not exist? This subroutine is called by misc/cronjobs/delete_items.pl ::: catalogue/detail.pl @@ +340,4 @@
$item->{'course_reserves'} = GetItemCourseReservesInfo( itemnumber => $item->{'itemnumber'} ); }
+ $item->{cannot_be_edited} = !$patron->can_edit_item( $item_object );
Why do you use negative and then again negative (UNLESS) in template? ::: cataloguing/additem.pl @@ +810,3 @@
#verifying rights + unless ( $patron->can_edit_item($subfieldvalue) ) { + warn "NOMOD";
debug message, should be removed ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ +223,5 @@
[% IF (StaffDetailItemSelection) %] <td style="text-align:center;vertical-align:middle"> + [% UNLESS item.cannot_be_edited %] + <input type="checkbox" value="[% item.itemnumber | html %]" name="itemnumber" /> + [% END %]
This could be [% IF item.can_be_edited %] See my previous comment on detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #29 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 88543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88543 Bug 20256: Add new methods for checking item editing permissions Review of attachment 88543: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20256&attachment=88543) ----------------------------------------------------------------- ::: Koha/Patron.pm @@ +1147,5 @@
}
+=head3 libraries_where_can_see_patrons + +my $libraries = $patron-libraries_where_can_see_patrons;
Should be $patron->libraries_where_can_see_patrons; missing ">" character -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Josef Moravec <josef.moravec@gmail.com> --- I think it is great enhancement, just need to polish some little issues ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Comment on attachment 88546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88546 Bug 20256: Use new methods Review of attachment 88546: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20256&attachment=88546) ----------------------------------------------------------------- ::: C4/Items.pm @@ +1746,4 @@
$status = "book_on_loan"; } elsif ( defined C4::Context->userenv + and !Koha::Patrons->find( C4::Context->userenv->{number} )->can_edit_item( $item ) )
cli scripts have no userenv, so this is cli safe. ::: catalogue/detail.pl @@ +340,4 @@
$item->{'course_reserves'} = GetItemCourseReservesInfo( itemnumber => $item->{'itemnumber'} ); }
+ $item->{cannot_be_edited} = !$patron->can_edit_item( $item_object );
Fair enough. I'll submit a followup for fix that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88632&action=edit Bug 20256: (QA Follow-up) Remove double negative from code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Kyle M Hall from comment #31)
Comment on attachment 88546 [details] [review] Bug 20256: Use new methods
Review of attachment 88546 [details] [review]: -----------------------------------------------------------------
::: C4/Items.pm @@ +1746,4 @@
$status = "book_on_loan"; } elsif ( defined C4::Context->userenv + and !Koha::Patrons->find( C4::Context->userenv->{number} )->can_edit_item( $item ) )
cli scripts have no userenv, so this is cli safe.
Sorry, I totally misread the code, you are right -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22600 --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Josef Moravec from comment #33)
(In reply to Kyle M Hall from comment #31)
Comment on attachment 88546 [details] [review] [review] Bug 20256: Use new methods
Review of attachment 88546 [details] [review] [review]: -----------------------------------------------------------------
::: C4/Items.pm @@ +1746,4 @@
$status = "book_on_loan"; } elsif ( defined C4::Context->userenv + and !Koha::Patrons->find( C4::Context->userenv->{number} )->can_edit_item( $item ) )
cli scripts have no userenv, so this is cli safe.
Sorry, I totally misread the code, you are right
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88632|0 |1 is obsolete| | --- Comment #35 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88702&action=edit Bug 20256: (QA follow-up) Remove double negative from code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #36 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88703&action=edit Bug 20256: (QA follow-up) Change meaning should change code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #37 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88704&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #38 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88705&action=edit Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Josef Moravec from comment #33)
(In reply to Kyle M Hall from comment #31)
Comment on attachment 88546 [details] [review] [review] Bug 20256: Use new methods
Review of attachment 88546 [details] [review] [review]: -----------------------------------------------------------------
::: C4/Items.pm @@ +1746,4 @@
$status = "book_on_loan"; } elsif ( defined C4::Context->userenv + and !Koha::Patrons->find( C4::Context->userenv->{number} )->can_edit_item( $item ) )
cli scripts have no userenv, so this is cli safe.
Sorry, I totally misread the code, you are right
I misread the code, but it is still valid, since bug 22600 added userenv to commandline/cron scripts... I added follow-up for this and for some other minor issues. But there is still one bigger problem: On biblio detail page, the checkbox is shown only when user can edit the item, but the edit button in the most right column of items table does not respect this logic. Even worse, I am able to edit the item, when i click it or reach the edit item form directly. This should be fixed on module level I think... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88935&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88936&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Quick review: 1. ->can_edit_item if ( C4::Context->preference('IndependentBranches') ) { return $userenv->{branch} eq $branchcode; } We certainly want to handle non-existing $userenv 2. On update, should not we set edit_any_item for patrons who where already allowed to edit items? 3. on /cataloguing/additem.pl, the whole dropdown list (edit, delete, print, etc.) is not displayed, I would expect to see some of them 4. You can add items to other libraries but then you cannot longer edit them? Maybe add and update should be impacted by this change? 5. Restriction is only done at template level (at least for batchMod), there should be a low level exception raised if the logged in user is trying to edit/delete (add?) an item outside of their group. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Component|Architecture, internals, |Cataloging |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches still apply, QA tools look good. Can you please take a look at Joubu's questions on comment 42? I think it would be nice to also limit update and add... as otherwise this leaves potential for 'locking yourself out' of an item you just added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22923 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10263 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88539|0 |1 is obsolete| | Attachment #88541|0 |1 is obsolete| | Attachment #88542|0 |1 is obsolete| | Attachment #88543|0 |1 is obsolete| | Attachment #88544|0 |1 is obsolete| | Attachment #88545|0 |1 is obsolete| | Attachment #88546|0 |1 is obsolete| | Attachment #88547|0 |1 is obsolete| | Attachment #88702|0 |1 is obsolete| | Attachment #88703|0 |1 is obsolete| | Attachment #88704|0 |1 is obsolete| | Attachment #88705|0 |1 is obsolete| | Attachment #88935|0 |1 is obsolete| | Attachment #88936|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96015&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96015|0 |1 is obsolete| | --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96016&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96017&action=edit Bug 20256: Add new permission to editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96018&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96019&action=edit Bug 20256: Add new methods for checking item editing permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96020&action=edit Bug 20256: Update Schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96021&action=edit Bug 20256: Update groups editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96022&action=edit Bug 20256: Use new methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96023&action=edit Bug 20256: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96024&action=edit Bug 20256: (QA follow-up) Remove double negative from code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96025&action=edit Bug 20256: (QA follow-up) Change meaning should change code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96026&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96027&action=edit Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96028&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96029&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96030&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #60 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96031&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96032&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #62 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96033&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Kyle, I am not able to test: Can't call method "libraries_where_can_edit_items" on an undefined value at /kohadevbox/koha/cataloguing/additem.pl line 178 Also, do not you think "edit_any_items" description should refer to "libraries in the same group" and not only "home library"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22923 | CC| |fridolin.somers@biblibre.co | |m --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 22923 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com | |, | |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96016|0 |1 is obsolete| | Attachment #96017|0 |1 is obsolete| | Attachment #96018|0 |1 is obsolete| | Attachment #96019|0 |1 is obsolete| | Attachment #96020|0 |1 is obsolete| | Attachment #96021|0 |1 is obsolete| | Attachment #96022|0 |1 is obsolete| | Attachment #96023|0 |1 is obsolete| | Attachment #96024|0 |1 is obsolete| | Attachment #96025|0 |1 is obsolete| | Attachment #96026|0 |1 is obsolete| | Attachment #96027|0 |1 is obsolete| | Attachment #96028|0 |1 is obsolete| | Attachment #96029|0 |1 is obsolete| | Attachment #96030|0 |1 is obsolete| | Attachment #96031|0 |1 is obsolete| | Attachment #96032|0 |1 is obsolete| | Attachment #96033|0 |1 is obsolete| | --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102622&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102622|0 |1 is obsolete| | --- Comment #66 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102623&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102623|0 |1 is obsolete| | --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102624&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #68 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102625&action=edit Bug 20256: Add new permission to editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #69 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102626&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #70 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102627&action=edit Bug 20256: Add new methods for checking item editing permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #71 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102628&action=edit Bug 20256: Update groups editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102629&action=edit Bug 20256: Use new methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #73 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102630&action=edit Bug 20256: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102631&action=edit Bug 20256: (QA follow-up) Remove double negative from code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102632&action=edit Bug 20256: (QA follow-up) Change meaning should change code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102633&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #77 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102634&action=edit Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102635&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #79 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102636&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #80 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102637&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #81 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102638&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #82 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102639&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #83 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102640&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #84 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102641&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #85 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102642&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #86 from Owen Leonard <oleonard@myacpl.org> --- In my tests this is working correctly. I would like to have a more thorough test plan because I worry I was missing something I should have been looking at. However, there are a couple of complaints by the QA tool which need to be addressed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102624|0 |1 is obsolete| | Attachment #102625|0 |1 is obsolete| | Attachment #102626|0 |1 is obsolete| | Attachment #102627|0 |1 is obsolete| | Attachment #102628|0 |1 is obsolete| | Attachment #102629|0 |1 is obsolete| | Attachment #102630|0 |1 is obsolete| | Attachment #102631|0 |1 is obsolete| | Attachment #102632|0 |1 is obsolete| | Attachment #102633|0 |1 is obsolete| | Attachment #102634|0 |1 is obsolete| | Attachment #102635|0 |1 is obsolete| | Attachment #102636|0 |1 is obsolete| | Attachment #102637|0 |1 is obsolete| | Attachment #102638|0 |1 is obsolete| | Attachment #102639|0 |1 is obsolete| | Attachment #102640|0 |1 is obsolete| | Attachment #102641|0 |1 is obsolete| | Attachment #102642|0 |1 is obsolete| | --- Comment #87 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102703&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102703|0 |1 is obsolete| | --- Comment #88 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102704&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #89 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102705&action=edit Bug 20256: Add new permission to editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #90 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102706&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #91 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102707&action=edit Bug 20256: Add new methods for checking item editing permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #92 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102708&action=edit Bug 20256: Update groups editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #93 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102709&action=edit Bug 20256: Use new methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #94 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102710&action=edit Bug 20256: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #95 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102711&action=edit Bug 20256: (QA follow-up) Remove double negative from code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #96 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102712&action=edit Bug 20256: (QA follow-up) Change meaning should change code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #97 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102713&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #98 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102714&action=edit Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #99 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102715&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #100 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102716&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #101 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102717&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #102 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102718&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #103 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102719&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #104 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102720&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #105 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102721&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #106 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102722&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #107 from Kyle M Hall <kyle@bywatersolutions.com> --- Test Plan: * Apply this patch set * Run updatedatabase.pl * Restart all the things! * Create two library groups with half the libraries in each * Enable the new item editing limits for the groups * Note you can now only edit items from the same group as your logged in users home library * Verify you cannot edit other library group's items using the batch item editor * Give your user the new "edit_any_item" user permission, verify the user can now edit any item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102704|0 |1 is obsolete| | Attachment #102705|0 |1 is obsolete| | Attachment #102706|0 |1 is obsolete| | Attachment #102707|0 |1 is obsolete| | Attachment #102708|0 |1 is obsolete| | Attachment #102709|0 |1 is obsolete| | Attachment #102710|0 |1 is obsolete| | Attachment #102711|0 |1 is obsolete| | Attachment #102712|0 |1 is obsolete| | Attachment #102713|0 |1 is obsolete| | Attachment #102714|0 |1 is obsolete| | Attachment #102715|0 |1 is obsolete| | Attachment #102716|0 |1 is obsolete| | Attachment #102717|0 |1 is obsolete| | Attachment #102718|0 |1 is obsolete| | Attachment #102719|0 |1 is obsolete| | Attachment #102720|0 |1 is obsolete| | Attachment #102721|0 |1 is obsolete| | Attachment #102722|0 |1 is obsolete| | --- Comment #108 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102732&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102732|0 |1 is obsolete| | --- Comment #109 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102733&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #110 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102734&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #111 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102735&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #112 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102736&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #113 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102737&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #114 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102738&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #115 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102739&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #116 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102740&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #117 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102741&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #118 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102742&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #119 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102743&action=edit Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #120 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102744&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #121 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102745&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #122 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102746&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #123 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102747&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #124 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102748&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #125 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102749&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #126 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102750&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #127 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 102751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102751&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #128 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches curently no longer apply, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20256: Update database Applying: Bug 20256: Add new permission to editor Applying: Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Applying: Bug 20256: Add new methods for checking item editing permissions Applying: Bug 20256: Update groups editor Applying: Bug 20256: Use new methods Applying: Bug 20256: Add unit tests Using index info to reconstruct a base tree... M t/db_dependent/Koha/Patrons.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Patrons.t Applying: Bug 20256: (QA follow-up) Remove double negative from code Applying: Bug 20256: (QA follow-up) Change meaning should change code Applying: Bug 20256: (QA follow-up) test borrowernumber in userenv too Applying: Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing Applying: Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Applying: Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Applying: Bug 20256: (QA follow-up) Handle non-existing userenv Applying: Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Applying: Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit .git/rebase-apply/patch:14: trailing whitespace. my $i = 1; error: sha1 information is lacking or useless (tools/batchMod.pl). error: could not build fake ancestor Patch failed at 0001 Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20256-QA-follow-up-Skip-batch-editing-items-th-PQV8Ge.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102733|0 |1 is obsolete| | Attachment #102734|0 |1 is obsolete| | Attachment #102735|0 |1 is obsolete| | Attachment #102736|0 |1 is obsolete| | Attachment #102737|0 |1 is obsolete| | Attachment #102738|0 |1 is obsolete| | Attachment #102739|0 |1 is obsolete| | Attachment #102740|0 |1 is obsolete| | Attachment #102741|0 |1 is obsolete| | Attachment #102742|0 |1 is obsolete| | Attachment #102743|0 |1 is obsolete| | Attachment #102744|0 |1 is obsolete| | Attachment #102745|0 |1 is obsolete| | Attachment #102746|0 |1 is obsolete| | Attachment #102747|0 |1 is obsolete| | Attachment #102748|0 |1 is obsolete| | Attachment #102749|0 |1 is obsolete| | Attachment #102750|0 |1 is obsolete| | Attachment #102751|0 |1 is obsolete| | --- Comment #129 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107312&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #130 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107313&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #131 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107314&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #132 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107315&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #133 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107316&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #134 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107317&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #135 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107318&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #136 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107319&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #137 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107320&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #138 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107321&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #139 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107322&action=edit Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #140 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107323&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #141 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107324&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #142 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107325&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #143 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107326&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #144 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107327&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #145 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107328&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #146 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107329&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #147 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107330&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #148 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This no longer applies, please rebase! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20256: Update database Applying: Bug 20256: Add new permission to editor Applying: Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Applying: Bug 20256: Add new methods for checking item editing permissions Applying: Bug 20256: Update groups editor Applying: Bug 20256: Use new methods Using index info to reconstruct a base tree... M Koha/Item.pm M catalogue/detail.pl M catalogue/moredetail.pl M cataloguing/additem.pl M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M tools/batchMod.pl Falling back to patching base and 3-way merge... Auto-merging tools/batchMod.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging cataloguing/additem.pl Auto-merging catalogue/moredetail.pl Auto-merging catalogue/detail.pl Auto-merging Koha/Item.pm Applying: Bug 20256: Add unit tests Applying: Bug 20256: (QA follow-up) Remove double negative from code Applying: Bug 20256: (QA follow-up) Change meaning should change code Applying: Bug 20256: (QA follow-up) test borrowernumber in userenv too Applying: Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing Applying: Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Applying: Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item error: sha1 information is lacking or useless (cataloguing/additem.pl). error: could not build fake ancestor Patch failed at 0001 Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20256-QA-follow-up-Redirect-to-record-details--3RxR9W.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107312|0 |1 is obsolete| | Attachment #107313|0 |1 is obsolete| | Attachment #107314|0 |1 is obsolete| | Attachment #107315|0 |1 is obsolete| | Attachment #107316|0 |1 is obsolete| | Attachment #107317|0 |1 is obsolete| | Attachment #107318|0 |1 is obsolete| | Attachment #107319|0 |1 is obsolete| | Attachment #107320|0 |1 is obsolete| | Attachment #107321|0 |1 is obsolete| | Attachment #107322|0 |1 is obsolete| | Attachment #107323|0 |1 is obsolete| | Attachment #107324|0 |1 is obsolete| | Attachment #107325|0 |1 is obsolete| | Attachment #107326|0 |1 is obsolete| | Attachment #107327|0 |1 is obsolete| | Attachment #107328|0 |1 is obsolete| | Attachment #107329|0 |1 is obsolete| | Attachment #107330|0 |1 is obsolete| | --- Comment #149 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108851&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108851|0 |1 is obsolete| | --- Comment #150 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108852&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #151 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108853&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #152 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108854&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #153 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108855&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #154 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108856&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #155 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108857&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #156 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108858&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #157 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108859&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #158 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108860&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #159 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108861&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #160 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108862&action=edit Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #161 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108863&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #162 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108864&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #163 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108865&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #164 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108866&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #165 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108867&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #166 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108868&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #167 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108869&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #168 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108870&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #169 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, first review here: 1) QA tools: FAIL cataloguing/additem.pl FAIL valid "my" variable $item masks earlier declaration in same scope 2) Unit tests Ran the database update, but tests are failing: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. 33/41 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry 'OPLKEwkZw0DMeIN2d05GnFYtiGaCnqBtN4N03FSuWrNz' for key 'userid' [for Statement "UPDATE `borrowers` SET `userid` = ? WHERE ( `borrowernumber` = ? )" with ParamValues: 0='OPLKEwkZw0DMeIN2d05GnFYtiGaCnqBtN4N03FSuWrNz', 1='199'] at /home/vagrant/kohaclone/Koha/Object.pm line 166 t/db_dependent/Koha/Patrons.t .. 42/41 # Looks like you planned 41 tests but ran 42. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 255 (wstat 65280, 0xff00) All 41 subtests passed Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 65280 Tests: 42 Failed: 1) Failed test: 42 Non-zero exit status: 255 Parse errors: Bad plan. You planned 41 tests but ran 42. 3) Methods libraries_where_can_see_patrons is added to Patron.pm I am not sure how it fits into this functionality, maybe a leftover from an earlier development? 4) Item edit checks I think we might also need a check on the permission from the item search edit item link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #170 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109939&action=edit Bug 20256: (QA follow-up) Fix variable masking warning in additem.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #171 from Kyle M Hall <kyle@bywatersolutions.com> ---
1) QA tools:
FAIL cataloguing/additem.pl FAIL valid "my" variable $item masks earlier declaration in same scope
Fixed!
2) Unit tests
Ran the database update, but tests are failing:
I wasn't able to recreate your unit test failure. Can you try again?
3) Methods
libraries_where_can_see_patrons is added to Patron.pm I am not sure how it fits into this functionality, maybe a leftover from an earlier development?
This subroutine is from Jonathan's patch that added group limits for viewing patrons. This patch set takes that logic and makes it more generic for use with other objects that also have branchcodes. libraries_where_can_see_patrons is the specific implementation for jonathans previous feature, which is now a wrapper around the more generic method that can also be used for items and other objects in the future.
4) Item edit checks
I think we might also need a check on the permission from the item search edit item link.
I've been working on this patch, but it occurs to me that the edit item link shows even if a record has no items. It's a useful way to go straight to the items editor to create a new item. As such, I don't think we should hide the link because it can still be used in that way even if the librarian can't edit any existing items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #172 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
4) Item edit checks
I think we might also need a check on the permission from the item search edit item link.
I've been working on this patch, but it occurs to me that the edit item link shows even if a record has no items. It's a useful way to go straight to the items editor to create a new item. As such, I don't think we should hide the link because it can still be used in that way even if the librarian can't edit any existing items.
Hi Kyle, I meant the "item search" - in this case the form for editing this specific item opens. So I think it makes sense to hide it there and I think there is already some logic for that now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #173 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110005&action=edit Bug 20256: (QA follow-up) Fix number of tests in Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #174 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #172)
4) Item edit checks
I think we might also need a check on the permission from the item search edit item link.
I've been working on this patch, but it occurs to me that the edit item link shows even if a record has no items. It's a useful way to go straight to the items editor to create a new item. As such, I don't think we should hide the link because it can still be used in that way even if the librarian can't edit any existing items.
Hi Kyle, I meant the "item search" - in this case the form for editing this specific item opens. So I think it makes sense to hide it there and I think there is already some logic for that now. I identified 3 places now that require action:
- Edit item link from course reserves - Edit item link form item search (not catalog search) - Edit item link from items tab (moredetail.pl) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108852|0 |1 is obsolete| | Attachment #108853|0 |1 is obsolete| | Attachment #108854|0 |1 is obsolete| | Attachment #108855|0 |1 is obsolete| | Attachment #108856|0 |1 is obsolete| | Attachment #108857|0 |1 is obsolete| | Attachment #108858|0 |1 is obsolete| | Attachment #108859|0 |1 is obsolete| | Attachment #108860|0 |1 is obsolete| | Attachment #108861|0 |1 is obsolete| | Attachment #108862|0 |1 is obsolete| | Attachment #108863|0 |1 is obsolete| | Attachment #108864|0 |1 is obsolete| | Attachment #108865|0 |1 is obsolete| | Attachment #108866|0 |1 is obsolete| | Attachment #108867|0 |1 is obsolete| | Attachment #108868|0 |1 is obsolete| | Attachment #108869|0 |1 is obsolete| | Attachment #108870|0 |1 is obsolete| | Attachment #109939|0 |1 is obsolete| | Attachment #110005|0 |1 is obsolete| | --- Comment #175 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113706&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #176 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113707&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #177 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113708&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #178 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113709&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #179 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113710&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #180 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113711&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #181 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113712&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #182 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113713&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #183 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113714&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #184 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113715&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #185 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113716&action=edit Bug 20256: (QA follow-up) Fix column description for ft_limit_item_editing Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #186 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113717&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #187 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113718&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #188 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113719&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #189 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113720&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #190 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113721&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #191 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113722&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #192 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113723&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #193 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113724&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #194 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113725&action=edit Bug 20256: (QA follow-up) Fix variable masking warning in additem.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #195 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113726&action=edit Bug 20256: (QA follow-up) Fix number of tests in Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #196 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113727&action=edit Bug 20256: (QA follow-up) Implement for course reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #197 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113728&action=edit Bug 20256: (QA follow-up) Implement for item search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #198 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #174)
(In reply to Katrin Fischer from comment #172)
4) Item edit checks
I think we might also need a check on the permission from the item search edit item link.
I've been working on this patch, but it occurs to me that the edit item link shows even if a record has no items. It's a useful way to go straight to the items editor to create a new item. As such, I don't think we should hide the link because it can still be used in that way even if the librarian can't edit any existing items.
Hi Kyle, I meant the "item search" - in this case the form for editing this specific item opens. So I think it makes sense to hide it there and I think there is already some logic for that now. I identified 3 places now that require action:
- Edit item link from course reserves - Edit item link form item search (not catalog search) - Edit item link from items tab (moredetail.pl)
The edit item link on moredetail.pl was already implemented, is it not working for you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113706|0 |1 is obsolete| | Attachment #113707|0 |1 is obsolete| | Attachment #113708|0 |1 is obsolete| | Attachment #113709|0 |1 is obsolete| | Attachment #113710|0 |1 is obsolete| | Attachment #113711|0 |1 is obsolete| | Attachment #113712|0 |1 is obsolete| | Attachment #113713|0 |1 is obsolete| | Attachment #113714|0 |1 is obsolete| | Attachment #113715|0 |1 is obsolete| | Attachment #113716|0 |1 is obsolete| | Attachment #113717|0 |1 is obsolete| | Attachment #113718|0 |1 is obsolete| | Attachment #113719|0 |1 is obsolete| | Attachment #113720|0 |1 is obsolete| | Attachment #113721|0 |1 is obsolete| | Attachment #113722|0 |1 is obsolete| | Attachment #113723|0 |1 is obsolete| | Attachment #113724|0 |1 is obsolete| | Attachment #113725|0 |1 is obsolete| | Attachment #113726|0 |1 is obsolete| | Attachment #113727|0 |1 is obsolete| | Attachment #113728|0 |1 is obsolete| | --- Comment #199 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116042&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116042|0 |1 is obsolete| | --- Comment #200 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116043&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #201 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116044&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #202 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116045&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #203 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116046&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #204 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116047&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #205 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116048&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #206 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116049&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #207 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116050&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #208 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116051&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #209 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116052&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #210 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116053&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #211 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116054&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #212 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116055&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #213 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116056&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #214 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116057&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #215 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116058&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #216 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116059&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #217 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116060&action=edit Bug 20256: (QA follow-up) Fix variable masking warning in additem.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #218 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116061&action=edit Bug 20256: (QA follow-up) Fix number of tests in Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #219 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116062&action=edit Bug 20256: (QA follow-up) Implement for course reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #220 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116063&action=edit Bug 20256: (QA follow-up) Implement for item search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #221 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116064&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #222 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, could you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20256: Update database Applying: Bug 20256: Add new permission to editor Applying: Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Applying: Bug 20256: Add new methods for checking item editing permissions error: sha1 information is lacking or useless (Koha/Patron.pm). error: could not build fake ancestor Patch failed at 0001 Bug 20256: Add new methods for checking item editing permissions The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20256-Add-new-methods-for-checking-item-editin-QeAIqS.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to limit |Add ability to limit |editing of items to home |editing of items to home |library |library or library group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #223 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 28174 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116043|0 |1 is obsolete| | Attachment #116044|0 |1 is obsolete| | Attachment #116045|0 |1 is obsolete| | Attachment #116046|0 |1 is obsolete| | Attachment #116047|0 |1 is obsolete| | Attachment #116048|0 |1 is obsolete| | Attachment #116049|0 |1 is obsolete| | Attachment #116050|0 |1 is obsolete| | Attachment #116051|0 |1 is obsolete| | Attachment #116052|0 |1 is obsolete| | Attachment #116053|0 |1 is obsolete| | Attachment #116054|0 |1 is obsolete| | Attachment #116055|0 |1 is obsolete| | Attachment #116056|0 |1 is obsolete| | Attachment #116057|0 |1 is obsolete| | Attachment #116058|0 |1 is obsolete| | Attachment #116059|0 |1 is obsolete| | Attachment #116060|0 |1 is obsolete| | Attachment #116061|0 |1 is obsolete| | Attachment #116062|0 |1 is obsolete| | Attachment #116063|0 |1 is obsolete| | Attachment #116064|0 |1 is obsolete| | --- Comment #224 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120055&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120055|0 |1 is obsolete| | --- Comment #225 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120056&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #226 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120057&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #227 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120058&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #228 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120059&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #229 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120060&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #230 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120061&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #231 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120062&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #232 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120063&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #233 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120064&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #234 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120065&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #235 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120066&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #236 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120067&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #237 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120068&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #238 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120069&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #239 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120070&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #240 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120071&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #241 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120072&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #242 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120073&action=edit Bug 20256: (QA follow-up) Fix variable masking warning in additem.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #243 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120074&action=edit Bug 20256: (QA follow-up) Implement for course reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #244 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120075&action=edit Bug 20256: (QA follow-up) Implement for item search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #245 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120076&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #246 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This looks good to me, and in my testing, all seems to be working well. As Katrin appears to already be most of the way through testing however.. I'll leave it to her to do the final signoff and PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120056|0 |1 is obsolete| | --- Comment #247 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121771&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120057|0 |1 is obsolete| | --- Comment #248 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121772&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120058|0 |1 is obsolete| | --- Comment #249 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121773&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120059|0 |1 is obsolete| | --- Comment #250 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121774&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120060|0 |1 is obsolete| | --- Comment #251 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121775&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120061|0 |1 is obsolete| | --- Comment #252 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121776&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120062|0 |1 is obsolete| | --- Comment #253 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121777&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120063|0 |1 is obsolete| | --- Comment #254 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121778&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120064|0 |1 is obsolete| | --- Comment #255 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121779&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120065|0 |1 is obsolete| | --- Comment #256 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121780&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120066|0 |1 is obsolete| | --- Comment #257 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121781&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120067|0 |1 is obsolete| | --- Comment #258 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121782&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120068|0 |1 is obsolete| | --- Comment #259 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121783&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120069|0 |1 is obsolete| | --- Comment #260 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121785&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120070|0 |1 is obsolete| | --- Comment #261 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121786&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120071|0 |1 is obsolete| | --- Comment #262 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121787&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120072|0 |1 is obsolete| | --- Comment #263 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121788&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120073|0 |1 is obsolete| | --- Comment #264 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121789&action=edit Bug 20256: (QA follow-up) Fix variable masking warning in additem.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120074|0 |1 is obsolete| | --- Comment #265 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121790&action=edit Bug 20256: (QA follow-up) Implement for course reserves Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120075|0 |1 is obsolete| | --- Comment #266 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121791&action=edit Bug 20256: (QA follow-up) Implement for item search Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120076|0 |1 is obsolete| | --- Comment #267 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121792&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #268 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor rebase and added my SO line as I've tested this.. still think it would be good to let Katrin do the final QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #269 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20256: Update database Applying: Bug 20256: Add new permission to editor Applying: Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Applying: Bug 20256: Add new methods for checking item editing permissions Applying: Bug 20256: Update groups editor Applying: Bug 20256: Use new methods Applying: Bug 20256: Add unit tests Applying: Bug 20256: (QA follow-up) Remove double negative from code Applying: Bug 20256: (QA follow-up) Change meaning should change code Applying: Bug 20256: (QA follow-up) test borrowernumber in userenv too Applying: Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Applying: Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Applying: Bug 20256: (QA follow-up) Handle non-existing userenv Applying: Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Applying: Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit error: sha1 information is lacking or useless (tools/batchMod.pl). error: could not build fake ancestor Patch failed at 0001 Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20256-QA-follow-up-Skip-batch-editing-items-th-RbN33J.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121771|0 |1 is obsolete| | --- Comment #270 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124286&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121772|0 |1 is obsolete| | --- Comment #271 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124287&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121773|0 |1 is obsolete| | --- Comment #272 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124288&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121774|0 |1 is obsolete| | --- Comment #273 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124289&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121775|0 |1 is obsolete| | --- Comment #274 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124290&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121776|0 |1 is obsolete| | --- Comment #275 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124291&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121777|0 |1 is obsolete| | --- Comment #276 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124292&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121778|0 |1 is obsolete| | --- Comment #277 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124293&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121779|0 |1 is obsolete| | --- Comment #278 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124294&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121780|0 |1 is obsolete| | --- Comment #279 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124295&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121781|0 |1 is obsolete| | --- Comment #280 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124296&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121782|0 |1 is obsolete| | --- Comment #281 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124297&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121783|0 |1 is obsolete| | --- Comment #282 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124298&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121785|0 |1 is obsolete| | --- Comment #283 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124299&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121786|0 |1 is obsolete| | --- Comment #284 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124300&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121787|0 |1 is obsolete| | --- Comment #285 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124301&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121788|0 |1 is obsolete| | --- Comment #286 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124302&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121789|0 |1 is obsolete| | --- Comment #287 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124303&action=edit Bug 20256: (QA follow-up) Fix variable masking warning in additem.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121790|0 |1 is obsolete| | --- Comment #288 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124304&action=edit Bug 20256: (QA follow-up) Implement for course reserves Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121791|0 |1 is obsolete| | --- Comment #289 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124305&action=edit Bug 20256: (QA follow-up) Implement for item search Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121792|0 |1 is obsolete| | --- Comment #290 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124306&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #291 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124307&action=edit Bug 20256: (follow-up) Fix spelling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #292 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124321&action=edit Bug 20256: (follow-up) Don't filter if no libraries are restricted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #293 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches no longer apply, could you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20256: Update database Applying: Bug 20256: Add new permission to editor Applying: Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Applying: Bug 20256: Add new methods for checking item editing permissions Applying: Bug 20256: Update groups editor Applying: Bug 20256: Use new methods Using index info to reconstruct a base tree... M Koha/Item.pm M catalogue/detail.pl M cataloguing/additem.pl M tools/batchMod.pl Falling back to patching base and 3-way merge... Auto-merging tools/batchMod.pl CONFLICT (content): Merge conflict in tools/batchMod.pl Auto-merging cataloguing/additem.pl CONFLICT (content): Merge conflict in cataloguing/additem.pl Auto-merging catalogue/detail.pl Auto-merging Koha/Item.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20256: Use new methods The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20256-Use-new-methods-G2R6lg.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124286|0 |1 is obsolete| | Attachment #124287|0 |1 is obsolete| | Attachment #124288|0 |1 is obsolete| | Attachment #124289|0 |1 is obsolete| | Attachment #124290|0 |1 is obsolete| | Attachment #124291|0 |1 is obsolete| | Attachment #124292|0 |1 is obsolete| | Attachment #124293|0 |1 is obsolete| | Attachment #124294|0 |1 is obsolete| | Attachment #124295|0 |1 is obsolete| | Attachment #124296|0 |1 is obsolete| | Attachment #124297|0 |1 is obsolete| | Attachment #124298|0 |1 is obsolete| | Attachment #124299|0 |1 is obsolete| | Attachment #124300|0 |1 is obsolete| | Attachment #124301|0 |1 is obsolete| | Attachment #124302|0 |1 is obsolete| | Attachment #124303|0 |1 is obsolete| | Attachment #124304|0 |1 is obsolete| | Attachment #124305|0 |1 is obsolete| | Attachment #124306|0 |1 is obsolete| | Attachment #124307|0 |1 is obsolete| | Attachment #124321|0 |1 is obsolete| | --- Comment #294 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128734&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #295 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128735&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #296 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128736&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #297 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128737&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #298 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128738&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #299 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128739&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #300 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128740&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #301 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128741&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #302 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128742&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #303 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128743&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #304 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128744&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #305 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128745&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #306 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128746&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #307 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128747&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #308 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128748&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #309 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128749&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #310 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128750&action=edit Bug 20256: (QA follow-up) Implement for course reserves Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #311 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128751&action=edit Bug 20256: (QA follow-up) Implement for item search Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #312 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128752&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #313 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128753&action=edit Bug 20256: (follow-up) Fix spelling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128734|0 |1 is obsolete| | --- Comment #314 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131676&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128735|0 |1 is obsolete| | --- Comment #315 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131677&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128736|0 |1 is obsolete| | --- Comment #316 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131678&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128737|0 |1 is obsolete| | --- Comment #317 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131679&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128738|0 |1 is obsolete| | --- Comment #318 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131680&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128739|0 |1 is obsolete| | --- Comment #319 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131681&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128740|0 |1 is obsolete| | --- Comment #320 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131682&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128741|0 |1 is obsolete| | --- Comment #321 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131683&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128742|0 |1 is obsolete| | --- Comment #322 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131684&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128743|0 |1 is obsolete| | --- Comment #323 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131685&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128744|0 |1 is obsolete| | --- Comment #324 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131686&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128745|0 |1 is obsolete| | --- Comment #325 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131687&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128746|0 |1 is obsolete| | --- Comment #326 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131688&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128747|0 |1 is obsolete| | --- Comment #327 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131689&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128748|0 |1 is obsolete| | --- Comment #328 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131690&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128749|0 |1 is obsolete| | --- Comment #329 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131691&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128750|0 |1 is obsolete| | --- Comment #330 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131692&action=edit Bug 20256: (QA follow-up) Implement for course reserves Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128751|0 |1 is obsolete| | --- Comment #331 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131693&action=edit Bug 20256: (QA follow-up) Implement for item search Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128752|0 |1 is obsolete| | --- Comment #332 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131694&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128753|0 |1 is obsolete| | --- Comment #333 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131695&action=edit Bug 20256: (follow-up) Fix spelling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #334 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131696&action=edit Bug 20256: (QA follow-up) Fix number of tests in Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #335 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131697&action=edit Bug 20256: (QA follow-up) Fix typo in comment on kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #336 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches still apply with a tiny rebase :) I've added the rebased patch set with 2 tiny follow-ups, but have some issues I am struggling with: 1) Tests don't pass and there is a warning that might relate to some rebase issue: kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. Subroutine libraries_where_can_see_patrons redefined at /kohadevbox/koha/Koha/Patron.pm line 1610. 2) Permission descriptions We now have: * Edit any item. If not set the logged in user can only edit items whose home library matches the logged in library. (edit_any_item) * Edit items (edit_items) I think we need to actually rephrase Edit items if the note on edit_any_item rings true. Also, we need to factor in the library group feature somehow... Edit all items with user's home library and from libaries within the edit item library group (edit_items) It makes me realize I am not super sure yet how the library groups and permissions work together, can you please check and maybe explain a little more? 3) Library groups <li>Limit item editing for librarians outside of this group.</li> Maybe this would be clearer as: <li>Limit item editing to librarians inside of this group</li> But I might be misunderstanding something? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #337 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132483&action=edit Bug 20256: (QA follow-up) Remove duplicated sub -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #338 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132484&action=edit Bug 20256: (QA follow-up) Update permission descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #339 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132486&action=edit Bug 20256: (QA follow-up) Update group feature description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #340 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #336)
Patches still apply with a tiny rebase :)
I've added the rebased patch set with 2 tiny follow-ups, but have some issues I am struggling with:
1) Tests don't pass and there is a warning that might relate to some rebase issue:
kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. Subroutine libraries_where_can_see_patrons redefined at /kohadevbox/koha/Koha/Patron.pm line 1610.
Should be fixed with this latest followup!
2) Permission descriptions
We now have:
* Edit any item. If not set the logged in user can only edit items whose home library matches the logged in library. (edit_any_item) * Edit items (edit_items)
I think we need to actually rephrase Edit items if the note on edit_any_item rings true. Also, we need to factor in the library group feature somehow...
Edit all items with user's home library and from libaries within the edit item library group (edit_items)
It makes me realize I am not super sure yet how the library groups and permissions work together, can you please check and maybe explain a little more?
I've added a followup to update those descriptions. I think the new ones are better, but if anyone has more improvements they would be welcome!
3) Library groups
<li>Limit item editing for librarians outside of this group.</li>
Maybe this would be clearer as:
<li>Limit item editing to librarians inside of this group</li>
But I might be misunderstanding something?
That sounds good to me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #341 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132917&action=edit Bug 20256: (QA follow-up) Fix typo in permission descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #342 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Started to test functionality a bit more and I feel like there is a bigger issue with how this will change how item editing is set up. We now have: * Edit items (not including items restricted by library group) (edit_items) * Edit any item including items that would otherwise be restricted (edit_any_item) Test case 1: * edit_items * Independentbranches is off * No library groups are set up Items from other libraries cannot be edited. This means that now both permissions are required in order to have the current behaviour when Independentbranches is turned off. As the permissions for existing staff users are not updated with this patch set, it will cause a behaviour change and require a lot of config changes (depending on staff numbers) to fix. So what can we do? 1) Update staff permissions for existing staff users. This will still mean that 2 checkboxes will have to be set to allow for full item editing. 2) Change the checks to see if there are actually any library groups for 'item edit' set up and only apply the limit if there are. What do you think? I lean a bit more towards 2 as this will make the default config a little easier (= no restrictions set up, no restrictions applied) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #343 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, I misread the database update, there actually is an update! + $dbh->do(q{ + INSERT INTO user_permissions ( borrowernumber, module_bit, code ) + SELECT borrowernumber, '9', 'edit_any_item' + FROM user_permissions + WHERE module_bit = '9' + AND code = 'edit_items' + }); Still wondering if we could get around the 2 permissions for simple item edit somehow... but maybe not. Because: if we implemented my suggestion 2) libraries wanting to limit on home branch for editing would have to set up a group for each branch, which is also not nice. I'll test more! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #344 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- =Testing restrictions= Test case 1: * edit_items = yes * edit_any_items = no * Independentbranches = NO * No library groups defined Only items from home branch can be edited. Test case 2: * edit_items = yes * edit_any_items = yes * Independentbranches = NO * No library groups defined All items can be edited. Test case 3: * edit_items = yes * edit_any_items = no * Independentbranches = YES * No library groups defined Only items from home branch can be edited. Same as with Indybranches off. Test case 4: * edit_items = yes * edit_any_items = yes * Independentbranches = YES * No library groups defined All items can be edited. Same as with Indybranches off. Test case 5: * edit_items = yes * edit_any_items = no * Independentbranches = YES or NO * Library group includes staff users home branch (MPL) and other library branch (CPL) Only items from home branch (CPL) and group library (MPL) can be edited. Test case 6: * edit_items = yes * edit_any_items = yes * Independentbranches = YES or NO * No library groups defined All items can be edited. Summary: ==> The new edit_any_items overwrites the Indybranches pref. In consequence it appears it no longer has any effect. Correct? Should we update the IndependantBranches description to reflect that? Currently reads: Prevent staff (but not superlibrarians) from modifying objects (holds, items, patrons, etc.) belonging to other libraries: [Yes|No] ==> We update all staff users to have edit_any_items, but we should possibly only update if IndependentBranches is set to off, to keep current behaviour! (blocker) =Edit buttons= Tested with configuration from Test case 5. 1) OK - detail page - holdings table 2) OK - detail page - items tab 3) NOT OK - item edit page The Edit link in the Actions menu always shows, but redirects to detail page, if no permission. It shoudl only show if editing is possible. (blocker) 4) OK - item search It could be improved later, so that if there is only "edit record" we show this option directly (no blocker). 5) NOT OK - Course reserves a) Use a barcode to add a reserve to a course from another branch, don't change home branch The edit link is removed, but something with the table structure is broken because of it and causes breakage of the datatable: Uncaught TypeError: Cannot set property '_DT_CellIndex' of undefined. (blocker) b) Use a barcode to add a reserve to a course from another branch, update home branch to an editable one The links are shown and the table keeps working. This one is tricky, I think for sure we need to fix the table to not be broken (minimum requirement). But this could be easily a thing where a patron 'traps' themselves with a reserve they can only 'remove' using the 'remove all' feature. Conclusion: An idea: As there sure is a use case for getting items from other branches for your course reserve, maybe we can do this: - Always show button to remove the item from the reserve (that's not editing right?) Also might fix the table issue. - Maybe: Allow editing of the item for this use case after the item has been added to the course reserve. If we allow on adding it... it would be consequential and it's only temporary changes. 6) OK - detail page - batch editing 7) NOT OK - tools - items batch edit - Added barcodes of one editable and a non-editable item. Exlosion (blocker) Can't locate object method "params" via package "Koha::UI::Table::Builder::Items" at /kohadevbox/koha/Koha/UI/Table/Builder/Items.pm line 75 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #345 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 134375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134375&action=edit Bug 20256: (QA follow-up) hide Edit chooice in Actions on items editor if item cannot be edited -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #346 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 134376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134376&action=edit Bug 20256: (QA follow-up) Allow removal of course reserves for items that cannot be edited -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #347 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 134377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134377&action=edit Bug 20256: (QA follow-up) Fix explosion for items batch edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #348 from Kyle M Hall <kyle@bywatersolutions.com> ---
Summary: ==> The new edit_any_items overwrites the Indybranches pref. In consequence it appears it no longer has any effect. Correct?
IndependentBranches is built into this feature. If IndependentBranches is enabled, only a superlibrarian can edit all items, and non-superlibrarians can only edit items from his or her home library.
3) NOT OK - item edit page The Edit link in the Actions menu always shows, but redirects to detail page, if no permission. It shoudl only show if editing is possible. (blocker)
Fixed!
5) NOT OK - Course reserves a) Use a barcode to add a reserve to a course from another branch, don't change home branch
The edit link is removed, but something with the table structure is broken because of it and causes breakage of the datatable: Uncaught TypeError: Cannot set property '_DT_CellIndex' of undefined. (blocker)
Fixed!
7) NOT OK - tools - items batch edit - Added barcodes of one editable and a non-editable item. Exlosion (blocker) Can't locate object method "params" via package "Koha::UI::Table::Builder::Items" at /kohadevbox/koha/Koha/UI/Table/Builder/Items.pm line 75
Fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #349 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #348)
Summary: ==> The new edit_any_items overwrites the Indybranches pref. In consequence it appears it no longer has any effect. Correct?
IndependentBranches is built into this feature. If IndependentBranches is enabled, only a superlibrarian can edit all items, and non-superlibrarians can only edit items from his or her home library.
I think that's not the case, I tried all the combinations. It depends on the edit_any_items preference with this patch set. I was testing with a non-superlibrarian user: "Test case 4: * edit_items = yes * edit_any_items = yes * Independentbranches = YES * No library groups defined All items can be edited. Same as with Indybranches off." Can you please test yourself and take a look at my summary? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #350 from Kyle M Hall <kyle@bywatersolutions.com> ---
"Test case 4: * edit_items = yes * edit_any_items = yes * Independentbranches = YES * No library groups defined
All items can be edited. Same as with Indybranches off."
Can you please test yourself and take a look at my summary?
As far as I can tell, it's working as expected. Can you take a look at this video and let me know if I'm missing anything? https://www.youtube.com/watch?v=kkwd-qCoM50 Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #351 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 6423 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131676|0 |1 is obsolete| | Attachment #131677|0 |1 is obsolete| | Attachment #131678|0 |1 is obsolete| | Attachment #131679|0 |1 is obsolete| | Attachment #131680|0 |1 is obsolete| | Attachment #131681|0 |1 is obsolete| | Attachment #131682|0 |1 is obsolete| | Attachment #131683|0 |1 is obsolete| | Attachment #131684|0 |1 is obsolete| | Attachment #131685|0 |1 is obsolete| | Attachment #131686|0 |1 is obsolete| | Attachment #131687|0 |1 is obsolete| | Attachment #131688|0 |1 is obsolete| | Attachment #131689|0 |1 is obsolete| | Attachment #131690|0 |1 is obsolete| | Attachment #131691|0 |1 is obsolete| | Attachment #131692|0 |1 is obsolete| | Attachment #131693|0 |1 is obsolete| | Attachment #131694|0 |1 is obsolete| | Attachment #131695|0 |1 is obsolete| | Attachment #131696|0 |1 is obsolete| | Attachment #131697|0 |1 is obsolete| | Attachment #132483|0 |1 is obsolete| | Attachment #132484|0 |1 is obsolete| | Attachment #132486|0 |1 is obsolete| | Attachment #132917|0 |1 is obsolete| | Attachment #134375|0 |1 is obsolete| | Attachment #134376|0 |1 is obsolete| | Attachment #134377|0 |1 is obsolete| | --- Comment #352 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139135&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #353 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139136&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #354 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139137&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #355 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139138&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #356 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139139&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #357 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139140&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #358 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139141&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #359 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139142&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #360 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139143&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #361 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139144&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #362 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139145&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #363 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139146&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #364 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139147&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #365 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139148&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #366 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139149&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #367 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139150&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #368 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139151&action=edit Bug 20256: (QA follow-up) Implement for course reserves Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #369 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139152&action=edit Bug 20256: (QA follow-up) Implement for item search Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #370 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139153&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #371 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139154&action=edit Bug 20256: (follow-up) Fix spelling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #372 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139155&action=edit Bug 20256: (QA follow-up) Fix typo in comment on kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #373 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139156&action=edit Bug 20256: (QA follow-up) Remove duplicated sub -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #374 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139157&action=edit Bug 20256: (QA follow-up) Update permission descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #375 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139158&action=edit Bug 20256: (QA follow-up) Update group feature description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #376 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139159&action=edit Bug 20256: (QA follow-up) Fix typo in permission descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #377 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139160&action=edit Bug 20256: (QA follow-up) hide Edit chooice in Actions on items editor if item cannot be edited -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #378 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139161&action=edit Bug 20256: (QA follow-up) Allow removal of course reserves for items that cannot be edited -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #379 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139162&action=edit Bug 20256: (QA follow-up) Fix explosion for items batch edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #380 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139163&action=edit Bug 20256: (QA follow-up) Hide link to delete item if unable to delete the item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply Keywords|rel_22_05_candidate |rel_22_11_candidate --- Comment #381 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, could you please rebase? I was hoping someone else would look into the case we disagreed about, but now ready to try and tackle this again. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20256: Update database Applying: Bug 20256: Add new permission to editor Applying: Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Applying: Bug 20256: Add new methods for checking item editing permissions Applying: Bug 20256: Update groups editor Applying: Bug 20256: Use new methods Using index info to reconstruct a base tree... M Koha/Item.pm M Koha/UI/Table/Builder/Items.pm M catalogue/detail.pl M catalogue/moredetail.pl M cataloguing/additem.pl M koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M tools/batchMod.pl Falling back to patching base and 3-way merge... Auto-merging tools/batchMod.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc Auto-merging cataloguing/additem.pl Auto-merging catalogue/moredetail.pl CONFLICT (content): Merge conflict in catalogue/moredetail.pl Auto-merging catalogue/detail.pl CONFLICT (content): Merge conflict in catalogue/detail.pl Auto-merging Koha/UI/Table/Builder/Items.pm CONFLICT (content): Merge conflict in Koha/UI/Table/Builder/Items.pm Auto-merging Koha/Item.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20256: Use new methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139135|0 |1 is obsolete| | Attachment #139136|0 |1 is obsolete| | Attachment #139137|0 |1 is obsolete| | Attachment #139138|0 |1 is obsolete| | Attachment #139139|0 |1 is obsolete| | Attachment #139140|0 |1 is obsolete| | Attachment #139141|0 |1 is obsolete| | Attachment #139142|0 |1 is obsolete| | Attachment #139143|0 |1 is obsolete| | Attachment #139144|0 |1 is obsolete| | Attachment #139145|0 |1 is obsolete| | Attachment #139146|0 |1 is obsolete| | Attachment #139147|0 |1 is obsolete| | Attachment #139148|0 |1 is obsolete| | Attachment #139149|0 |1 is obsolete| | Attachment #139150|0 |1 is obsolete| | Attachment #139151|0 |1 is obsolete| | Attachment #139152|0 |1 is obsolete| | Attachment #139153|0 |1 is obsolete| | Attachment #139154|0 |1 is obsolete| | Attachment #139155|0 |1 is obsolete| | Attachment #139156|0 |1 is obsolete| | Attachment #139157|0 |1 is obsolete| | Attachment #139158|0 |1 is obsolete| | Attachment #139159|0 |1 is obsolete| | Attachment #139160|0 |1 is obsolete| | Attachment #139161|0 |1 is obsolete| | Attachment #139162|0 |1 is obsolete| | Attachment #139163|0 |1 is obsolete| | --- Comment #382 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143527&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #383 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143529&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #384 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143530&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #385 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143531&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #386 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143532&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #387 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143533&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #388 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143534&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #389 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143535&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #390 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143536&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #391 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143537&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #392 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143538&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #393 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143539&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #394 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143540&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #395 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143541&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #396 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143542&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #397 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143543&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #398 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143544&action=edit Bug 20256: (QA follow-up) Implement for course reserves Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #399 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143545&action=edit Bug 20256: (QA follow-up) Implement for item search Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #400 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143546&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #401 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143547&action=edit Bug 20256: (follow-up) Fix spelling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #402 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143548&action=edit Bug 20256: (QA follow-up) Fix typo in comment on kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #403 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143549&action=edit Bug 20256: (QA follow-up) Remove duplicated sub -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #404 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143550&action=edit Bug 20256: (QA follow-up) Update permission descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #405 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143551&action=edit Bug 20256: (QA follow-up) Update group feature description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #406 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143552&action=edit Bug 20256: (QA follow-up) Fix typo in permission descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #407 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143553&action=edit Bug 20256: (QA follow-up) hide Edit chooice in Actions on items editor if item cannot be edited -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #408 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143554&action=edit Bug 20256: (QA follow-up) Allow removal of course reserves for items that cannot be edited -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #409 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143555&action=edit Bug 20256: (QA follow-up) Fix explosion for items batch edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #410 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143556&action=edit Bug 20256: (QA follow-up) Hide link to delete item if unable to delete the item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143527|0 |1 is obsolete| | Attachment #143529|0 |1 is obsolete| | Attachment #143530|0 |1 is obsolete| | Attachment #143531|0 |1 is obsolete| | Attachment #143532|0 |1 is obsolete| | Attachment #143533|0 |1 is obsolete| | Attachment #143534|0 |1 is obsolete| | Attachment #143535|0 |1 is obsolete| | Attachment #143536|0 |1 is obsolete| | Attachment #143537|0 |1 is obsolete| | Attachment #143538|0 |1 is obsolete| | Attachment #143539|0 |1 is obsolete| | Attachment #143540|0 |1 is obsolete| | Attachment #143541|0 |1 is obsolete| | Attachment #143542|0 |1 is obsolete| | Attachment #143543|0 |1 is obsolete| | Attachment #143544|0 |1 is obsolete| | Attachment #143545|0 |1 is obsolete| | Attachment #143546|0 |1 is obsolete| | Attachment #143547|0 |1 is obsolete| | Attachment #143548|0 |1 is obsolete| | Attachment #143549|0 |1 is obsolete| | Attachment #143550|0 |1 is obsolete| | Attachment #143551|0 |1 is obsolete| | Attachment #143552|0 |1 is obsolete| | Attachment #143553|0 |1 is obsolete| | Attachment #143554|0 |1 is obsolete| | Attachment #143555|0 |1 is obsolete| | Attachment #143556|0 |1 is obsolete| | --- Comment #411 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145286&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #412 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145287&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #413 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145288&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #414 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145289&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #415 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145290&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #416 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145291&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #417 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145292&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #418 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145293&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #419 from Kyle M Hall <kyle@bywatersolutions.com> --- Follow-ups have been squashed into the main patch set to make everything manageable and readable again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #420 from Michaela Sieber <michaela.sieber@kit.edu> --- Hi Kyle, I would like to test this feature but it was not possible to create a sandbox: https://sandbox.bywatersolutions.com/provision_log/bug20256 Could you please have a look? Thanks! :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145286|0 |1 is obsolete| | Attachment #145287|0 |1 is obsolete| | Attachment #145288|0 |1 is obsolete| | Attachment #145289|0 |1 is obsolete| | Attachment #145290|0 |1 is obsolete| | Attachment #145291|0 |1 is obsolete| | Attachment #145292|0 |1 is obsolete| | Attachment #145293|0 |1 is obsolete| | --- Comment #421 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145482&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #422 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145483&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #423 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145484&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #424 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145485&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #425 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145486&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #426 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145487&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #427 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145488&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #428 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145489&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #429 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Michaela Sieber from comment #420)
Hi Kyle, I would like to test this feature but it was not possible to create a sandbox: https://sandbox.bywatersolutions.com/provision_log/bug20256
Could you please have a look? Thanks! :-)
Please try again! Patches needed a rebase against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #430 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Kyle M Hall from comment #429)
Please try again! Patches needed a rebase against master.
Error when trying to see the detail view of a biblio: Could not compile /kohadevbox/koha/catalogue/detail.pl.... http://staff-edititems.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/catalogue/de... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #431 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Michaela Sieber from comment #430)
(In reply to Kyle M Hall from comment #429)
Please try again! Patches needed a rebase against master.
Error when trying to see the detail view of a biblio:
Could not compile /kohadevbox/koha/catalogue/detail.pl....
http://staff-edititems.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/catalogue/ detail.pl?biblionumber=30
Full error is: Could not compile /kohadevbox/koha/catalogue/detail.pl: Global symbol "$item_object" requires explicit package name (did you forget to declare "my $item_object"?) at /kohadevbox/koha/catalogue/detail.pl line 445. BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/catalogue/detail.pl line 693. at /usr/share/perl5/CGI/Compile.pm line 144 Maybe a rebase issue with some changes on master? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145482|0 |1 is obsolete| | Attachment #145483|0 |1 is obsolete| | Attachment #145484|0 |1 is obsolete| | Attachment #145485|0 |1 is obsolete| | Attachment #145486|0 |1 is obsolete| | Attachment #145487|0 |1 is obsolete| | Attachment #145488|0 |1 is obsolete| | Attachment #145489|0 |1 is obsolete| | --- Comment #432 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145809&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #433 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145810&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #434 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145811&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #435 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145812&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #436 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145813&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #437 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145814&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #438 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145815&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #439 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145816&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #440 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, does the last patch set fix the error Michaela noted on comment 430? Michaela also told that in her testing it showed the behavior as you described it - so I need to do my homework and retest. I aim to have another go at this patch set on Friday. Fingers crossed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145809|0 |1 is obsolete| | Attachment #145810|0 |1 is obsolete| | Attachment #145811|0 |1 is obsolete| | Attachment #145812|0 |1 is obsolete| | Attachment #145813|0 |1 is obsolete| | Attachment #145814|0 |1 is obsolete| | Attachment #145815|0 |1 is obsolete| | Attachment #145816|0 |1 is obsolete| | --- Comment #441 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145887&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #442 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145888&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #443 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145889&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #444 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145890&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #445 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145891&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145887|0 |1 is obsolete| | Attachment #145888|0 |1 is obsolete| | Attachment #145889|0 |1 is obsolete| | Attachment #145890|0 |1 is obsolete| | Attachment #145891|0 |1 is obsolete| | --- Comment #446 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145892&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #447 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145893&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #448 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145894&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #449 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145895&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #450 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 145896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145896&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/bywaters | |olutions/bywater-koha-devel | |/tree/bug_20256 --- Comment #451 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #440)
Hi Kyle,
does the last patch set fix the error Michaela noted on comment 430?
Michaela also told that in her testing it showed the behavior as you described it - so I need to do my homework and retest. I aim to have another go at this patch set on Friday. Fingers crossed.
Yes it should! I'm getting "413 Request Entity Too Large" when I attach my new patchset, so I've posted the github url in the URL field for this bug. https://github.com/bywatersolutions/bywater-koha-devel/tree/bug_20256 I will deprecate the attached patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145892|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145893|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145894|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145895|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145896|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #452 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 145951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145951&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #453 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 145952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145952&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #454 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 145953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145953&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #455 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 145954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145954&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #456 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 145955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145955&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff@clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145952|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145951|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Status|Signed Off |Passed QA --- Comment #457 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I tested the feature and after a rebase fix Kyle did it is working properly. The QA scripts are happy, things are covered by tests and they pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #458 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #459 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #440)
Hi Kyle,
does the last patch set fix the error Michaela noted on comment 430?
Michaela also told that in her testing it showed the behavior as you described it - so I need to do my homework and retest. I aim to have another go at this patch set on Friday. Fingers crossed.
It's Friday, but I am no longer needed here :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate |additional_work_needed --- Comment #460 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Kyle, we talked about a fix for a random failure on t/db_dependent/Koha/Acquisition/Order.t related to this bug. Please check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #461 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1530 my $branchcode = 1531 $ref eq 'Koha::Item' ? $item->homebranch 1532 : $ref eq 'HASH' ? $item->{homebranch} 1533 : $ref eq q{} ? $item 1534 : undef; This reads bad, and introduce an incorrect pattern, can you have another look at it please? Why not simply having can_edit_items_from that takes the branchcode? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33054 --- Comment #462 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #460)
Kyle, we talked about a fix for a random failure on t/db_dependent/Koha/Acquisition/Order.t related to this bug. Please check.
Failing again, see bug 33054. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33054 [Bug 33054] Koha/Acquisition/Order.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33070 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33070 [Bug 33070] Get rid of Koha::Patron->can_edit_item and use can_edit_item_from instead -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Sponsored by CLiC (Colorado submission| |Library Consortium). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored by CLiC (Colorado release notes| |Library Consortium). Documentation|Sponsored by CLiC (Colorado | submission|Library Consortium). | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/681 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored by CLiC (Colorado |**Sponsored by** *CLiC release notes|Library Consortium). |(Colorado Library | |Consortium)* | | | |This adds | |the ability to limit item | |editing to staff users from | |libraries within a specific | |library group. This is done | |via a new option when | |creating item groups. There | |is also a new system | |preference `edit_any_item` | |that permits users to edit | |all items on a record | |independent of the library | |groups and their own home | |library. Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34589 [Bug 34589] Update on bug 20256 is not idempotent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #463 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I'm not sure if this is somehow covered in this huge bug but I noticed that if you are limiting the editing per library group you lose the ability to choose items on record details page. This is enabled in StaffDetailItemSelection. You cannot choose your own items either. It would be ok not to choose items that you cannot edit/delete but if you cannot choose your own items it is a big disadvantage. You cannot choose multiple items and do batch edits or deletes to them from details page. I tested the feature in PTFS Europe's sandbox (v. 23.06). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #464 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Anneli Österman from comment #463)
I'm not sure if this is somehow covered in this huge bug but I noticed that if you are limiting the editing per library group you lose the ability to choose items on record details page. This is enabled in StaffDetailItemSelection. You cannot choose your own items either. It would be ok not to choose items that you cannot edit/delete but if you cannot choose your own items it is a big disadvantage. You cannot choose multiple items and do batch edits or deletes to them from details page. I tested the feature in PTFS Europe's sandbox (v. 23.06).
Can you file a dependent bug report for this issue? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34814 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34814 [Bug 34814] Limiting item editing to library or library group disables choosing items from record's details page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #465 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- (In reply to Kyle M Hall from comment #464)
(In reply to Anneli Österman from comment #463)
I'm not sure if this is somehow covered in this huge bug but I noticed that if you are limiting the editing per library group you lose the ability to choose items on record details page. This is enabled in StaffDetailItemSelection. You cannot choose your own items either. It would be ok not to choose items that you cannot edit/delete but if you cannot choose your own items it is a big disadvantage. You cannot choose multiple items and do batch edits or deletes to them from details page. I tested the feature in PTFS Europe's sandbox (v. 23.06).
Can you file a dependent bug report for this issue?
Sure, I added bug 34814 (hope I did it right). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #466 from Kyle M Hall <kyle@bywatersolutions.com> ---
Sure, I added bug 34814 (hope I did it right).
Looks good. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Sally Lodico <Slodico@knoxlib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35159 [Bug 35159] New edit item limitation to library groups also prevents batch modification of items owned by other libraries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Pablo AB <pablo.bianchi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi@gmail.com --- Comment #467 from Pablo AB <pablo.bianchi@gmail.com> --- Druart's comment 42 (4) was ignored? I'm able (v23.11.07) to create an item, then switch homebranch (and holdingbranch), and therefore no longer being able to edit it. Does _edit_ imply create and delete? I though so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40588 [Bug 40588] Clarify impact of edit_any_item permission when no library groups are defined -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org