https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #67 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi guys, 1) It appears opac_user_holds, opac_user_overdues, opac_user_article_requests template params are set but never used i.e. dead code in opac-user.pl. Can you please confirm? 2) The 'Fix deletion off by one error' commit applies the same change to both basket.js (OPAC + Staff) but the OPAC one does arrayRecords.splice before the check, whereas the Staff one does arrayRecords.splice after the check. Can you please confirm if this is intentional? Thanks in advance. -- You are receiving this mail because: You are watching all bug changes.