[Bug 36868] New: Add ability to automatically empty cart after placing holds ( staff interface and OPAC )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Bug ID: 36868 Summary: Add ability to automatically empty cart after placing holds ( staff interface and OPAC ) Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Some librarians would like to have the cart automatically clear itself after placing holds on items in the current cart. This would behave similar to how online retail/e-commerce sites work after one has purchased items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166834&action=edit Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166835&action=edit Bug 36868: Logic for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166835|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167558&action=edit Bug 36868: Logic for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167695&action=edit Bug 36868: Add logic for OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166834|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167699&action=edit Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167558|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167700&action=edit Bug 36868: Logic for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167695|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167701&action=edit Bug 36868: Add logic for OPAC 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the new AutoDeleteFromCartWhenHoldPlaced system preference 3. Turn it on for both staff and OPAC 4. From the staff interface put some items in your cart. 5. Place a hold on all of them. 6. Once the hold(s) have been successfully done those items should no longer be in your cart. 7. Put more items into your staff cart, place a hold on some of them but not all. 8. Only the items you have placed a hold on should be removed. 9. Go to the OPAC and put some items in your cart. 10. Place a hold on all of them, those items should now be deleted from the cart. 11. Place more items into your OPAC cart, place a hold on some of them but not all. 12. Only the items you have placed a hold on should be removed. 13. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'staff'. 14. Try steps 4-8 again. 15. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'opac'. 16. Try steps 9 -12 again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |samalau@gmail.com --- Comment #8 from Sam Lau <samalau@gmail.com> --- After adding items to cart, from the cart if I select all and place a hold, after completion, it only removes one of the items from the cart and the others stay. Placing the holds one by one worked though. Also, qa script didn't like the ordering placement of the sys. pref in installer/data/mysql/mandatory/sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167851&action=edit Bug 36868: (follow-up) Fix staff interface code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167699|0 |1 is obsolete| | --- Comment #10 from Sam Lau <samalau@gmail.com> --- Created attachment 167852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167852&action=edit Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167700|0 |1 is obsolete| | --- Comment #11 from Sam Lau <samalau@gmail.com> --- Created attachment 167853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167853&action=edit Bug 36868: Logic for staff interface Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167701|0 |1 is obsolete| | --- Comment #12 from Sam Lau <samalau@gmail.com> --- Created attachment 167854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167854&action=edit Bug 36868: Add logic for OPAC 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the new AutoDeleteFromCartWhenHoldPlaced system preference 3. Turn it on for both staff and OPAC 4. From the staff interface put some items in your cart. 5. Place a hold on all of them. 6. Once the hold(s) have been successfully done those items should no longer be in your cart. 7. Put more items into your staff cart, place a hold on some of them but not all. 8. Only the items you have placed a hold on should be removed. 9. Go to the OPAC and put some items in your cart. 10. Place a hold on all of them, those items should now be deleted from the cart. 11. Place more items into your OPAC cart, place a hold on some of them but not all. 12. Only the items you have placed a hold on should be removed. 13. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'staff'. 14. Try steps 4-8 again. 15. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'opac'. 16. Try steps 9 -12 again. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167851|0 |1 is obsolete| | --- Comment #13 from Sam Lau <samalau@gmail.com> --- Created attachment 167855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167855&action=edit Bug 36868: (follow-up) Fix staff interface code Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Why not a checkbox instead of a new syspref? Seems more flexible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #14)
Why not a checkbox instead of a new syspref?
Seems more flexible.
I like any solution that doesn't require a syspref. Can you explain what you mean? A checkbox where? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #15)
(In reply to Jonathan Druart from comment #14)
Why not a checkbox instead of a new syspref?
Seems more flexible.
I like any solution that doesn't require a syspref. Can you explain what you mean? A checkbox where?
On the "Place holds" page. If at least one record is in the cart we could have a "Remove from cart" checkbox that will behave like what you have done with the pref if checkbed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167852|0 |1 is obsolete| | --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177760&action=edit Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167853|0 |1 is obsolete| | --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177761&action=edit Bug 36868: Logic for staff interface Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167854|0 |1 is obsolete| | --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177762&action=edit Bug 36868: Add logic for OPAC 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the new AutoDeleteFromCartWhenHoldPlaced system preference 3. Turn it on for both staff and OPAC 4. From the staff interface put some items in your cart. 5. Place a hold on all of them. 6. Once the hold(s) have been successfully done those items should no longer be in your cart. 7. Put more items into your staff cart, place a hold on some of them but not all. 8. Only the items you have placed a hold on should be removed. 9. Go to the OPAC and put some items in your cart. 10. Place a hold on all of them, those items should now be deleted from the cart. 11. Place more items into your OPAC cart, place a hold on some of them but not all. 12. Only the items you have placed a hold on should be removed. 13. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'staff'. 14. Try steps 4-8 again. 15. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'opac'. 16. Try steps 9 -12 again. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167855|0 |1 is obsolete| | --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177763&action=edit Bug 36868: (follow-up) Fix staff interface code Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 177760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177760 Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced Review of attachment 177760: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36868&attachment=177760) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ +763,5 @@
- pref: HoldRatioDefault class: integer - . + - + - Automatically delete items from cart when placing on hold on the
Phrasing looks weird: «when placing on hold on the OPAC». Typo or maybe it's just an uncommon phrasing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 178640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178640&action=edit Bug 36868: (QA follow-up): fix exec permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | Status|Signed Off |Failed QA --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- The new syspref needs to be added to Hea (C4/UsageStats.pm) https://wiki.koha-community.org/wiki/Database_updates#Additional_hints ------- QA script: They looks either false positives or have their enforcement suspended (tt_valid) so nothing to worry here. FAIL installer/data/mysql/mandatory/sysprefs.sql FAIL semicolon simicolon found instead of comma at line 877 FAIL sysprefs_order Not blocker: Sysprefs hidelostitems is bad placed (see bug 10610) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt FAIL tt_valid lines 388, 937, 1096 FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt FAIL tt_valid lines 368 ------ I'll continue with testing asap. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 178700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178700&action=edit Bug 36868: (QA follow-up): fix typo in DBRev and DBRev skeleton Hijack this follow-up also fix the source (skeleton) which lead this typo to have 40 occurences! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178700|0 |1 is obsolete| | --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 178701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178701&action=edit Bug 36868: (QA follow-up): fix typo in DBRev and DBRev skeleton Hijacking this follow-up to also fix the source (skeleton) which lead this typo to have 40 occurences! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- 1. Apply and update DB 2. AutoDeleteFromCartWhenHoldPlaced = both or OPAC only 3. Go to OPAC and on search results add 3 records to cart 4. One one result, place hold 5. "item has been removed from cart", count = 2 6. From the current "Your summary" page, cancel the hold 7. Now we want to go back to the search results to test more case. So we will use the back button a few times. 8. Go back once 9. "item has been removed from cart", count = 1 Not great but doesn't really matter if it's just there. 10. Go back more times to get back to the search results 11. cart count = 3 Not really a problem, it's just the old value because we are going back. 12. Click on any link to go to any page 13. cart count = 1 Oh no it was persistent! >_< 14. click on cart 15. 2 items Confirmation that cart count is now desynced >_< (better than removing another of the remaining records) Instead of cancelling the hold, I could have went to any page and hit back, it would have likely(speculation) done the same. I didn't test on staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 177762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177762 Bug 36868: Add logic for OPAC Review of attachment 177762: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36868&attachment=177762) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ +1077,5 @@
[% INCLUDE 'datatables.inc' %] <script> + [% IF successful_holds && Koha.Preference('AutoDeleteFromCartWhenHoldPlaced').grep('opac').size %] + [% FOREACH success IN successful_holds.split('\|') %] + delSingleRecord('[% success | html %]');
Having a function call dropped in a <script> of page it likely the cause. Such technique need the call to be idempotent. Like making the count always be calculated from the cart content instead a separate variable? Even without going as far as such of a refactor, it looks like a bug that passing an already removed record would trigger the correct message but still decrement the count. Or somehow having the call only done once. (self deleting <script> tag? 😆) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177760|0 |1 is obsolete| | --- Comment #28 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188235&action=edit Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177763|0 |1 is obsolete| | --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188236&action=edit Bug 36868: (follow-up) Fix staff interface code Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177762|0 |1 is obsolete| | --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188237&action=edit Bug 36868: Add logic for OPAC 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the new AutoDeleteFromCartWhenHoldPlaced system preference 3. Turn it on for both staff and OPAC 4. From the staff interface put some items in your cart. 5. Place a hold on all of them. 6. Once the hold(s) have been successfully done those items should no longer be in your cart. 7. Put more items into your staff cart, place a hold on some of them but not all. 8. Only the items you have placed a hold on should be removed. 9. Go to the OPAC and put some items in your cart. 10. Place a hold on all of them, those items should now be deleted from the cart. 11. Place more items into your OPAC cart, place a hold on some of them but not all. 12. Only the items you have placed a hold on should be removed. 13. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'staff'. 14. Try steps 4-8 again. 15. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'opac'. 16. Try steps 9 -12 again. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178640|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178701|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|victor@tuxayo.net | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- this is rebased and squashed, it seems to be again ready for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #32 from Victor Grousset/tuxayo <victor@tuxayo.net> --- This introduces @successful_holds (filled with $biblioNum) but bug 40517 (07275db04f1) changed $hold_group to @successful_hold_ids (filled with $reserve_id) So we would have successful_holds and successful_hold_ids. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188235|0 |1 is obsolete| | --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190497&action=edit Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188236|0 |1 is obsolete| | --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190498&action=edit Bug 36868: (follow-up) Fix staff interface code Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188237|0 |1 is obsolete| | --- Comment #35 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190499&action=edit Bug 36868: Add logic for OPAC 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the new AutoDeleteFromCartWhenHoldPlaced system preference 3. Turn it on for both staff and OPAC 4. From the staff interface put some items in your cart. 5. Place a hold on all of them. 6. Once the hold(s) have been successfully done those items should no longer be in your cart. 7. Put more items into your staff cart, place a hold on some of them but not all. 8. Only the items you have placed a hold on should be removed. 9. Go to the OPAC and put some items in your cart. 10. Place a hold on all of them, those items should now be deleted from the cart. 11. Place more items into your OPAC cart, place a hold on some of them but not all. 12. Only the items you have placed a hold on should be removed. 13. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'staff'. 14. Try steps 4-8 again. 15. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'opac'. 16. Try steps 9 -12 again. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190497|0 |1 is obsolete| | --- Comment #36 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190618&action=edit Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190498|0 |1 is obsolete| | --- Comment #37 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190619&action=edit Bug 36868: (follow-up) Fix staff interface code Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190499|0 |1 is obsolete| | --- Comment #38 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190620&action=edit Bug 36868: Add logic for OPAC 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the new AutoDeleteFromCartWhenHoldPlaced system preference 3. Turn it on for both staff and OPAC 4. From the staff interface put some items in your cart. 5. Place a hold on all of them. 6. Once the hold(s) have been successfully done those items should no longer be in your cart. 7. Put more items into your staff cart, place a hold on some of them but not all. 8. Only the items you have placed a hold on should be removed. 9. Go to the OPAC and put some items in your cart. 10. Place a hold on all of them, those items should now be deleted from the cart. 11. Place more items into your OPAC cart, place a hold on some of them but not all. 12. Only the items you have placed a hold on should be removed. 13. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'staff'. 14. Try steps 4-8 again. 15. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'opac'. 16. Try steps 9 -12 again. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #39 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Was not able to recreate the new behavior following the test plan. Can someone else try to confirm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #40 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Kyle M Hall (khall) from comment #39)
Was not able to recreate the new behavior following the test plan. Can someone else try to confirm?
On current main the patch doesn't apply. Did you fix the conflicts manually? After doing so, at what point in the test plan did the patch fail? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190618|0 |1 is obsolete| | --- Comment #41 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 194176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194176&action=edit Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190619|0 |1 is obsolete| | --- Comment #42 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 194177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194177&action=edit Bug 36868: (follow-up) Fix staff interface code Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190620|0 |1 is obsolete| | --- Comment #43 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 194178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194178&action=edit Bug 36868: Add logic for OPAC 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the new AutoDeleteFromCartWhenHoldPlaced system preference 3. Turn it on for both staff and OPAC 4. From the staff interface put some items in your cart. 5. Place a hold on all of them. 6. Once the hold(s) have been successfully done those items should no longer be in your cart. 7. Put more items into your staff cart, place a hold on some of them but not all. 8. Only the items you have placed a hold on should be removed. 9. Go to the OPAC and put some items in your cart. 10. Place a hold on all of them, those items should now be deleted from the cart. 11. Place more items into your OPAC cart, place a hold on some of them but not all. 12. Only the items you have placed a hold on should be removed. 13. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'staff'. 14. Try steps 4-8 again. 15. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'opac'. 16. Try steps 9 -12 again. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 194179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194179&action=edit Bug 36868: (follow-up) Remove unused variable in opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Kyle M Hall (khall) from comment #39)
Was not able to recreate the new behavior following the test plan. Can someone else try to confirm?
It is working for me with the patches applied. Kyle, can you try again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194176|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194177|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194178|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194179|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #46 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197009&action=edit Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #47 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197010&action=edit Bug 36868: (follow-up) Fix staff interface code Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197011&action=edit Bug 36868: Add logic for OPAC 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the new AutoDeleteFromCartWhenHoldPlaced system preference 3. Turn it on for both staff and OPAC 4. From the staff interface put some items in your cart. 5. Place a hold on all of them. 6. Once the hold(s) have been successfully done those items should no longer be in your cart. 7. Put more items into your staff cart, place a hold on some of them but not all. 8. Only the items you have placed a hold on should be removed. 9. Go to the OPAC and put some items in your cart. 10. Place a hold on all of them, those items should now be deleted from the cart. 11. Place more items into your OPAC cart, place a hold on some of them but not all. 12. Only the items you have placed a hold on should be removed. 13. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'staff'. 14. Try steps 4-8 again. 15. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'opac'. 16. Try steps 9 -12 again. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #49 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197012&action=edit Bug 36868: (follow-up) Remove unused variable in opac-reserve.pl Patch from commit cd51681 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset adds the release notes| |ability to automatically | |delete items from the | |cart/bookbag when a hold is | |place on that on item. The | |feature is controlled by a | |new system preference, | |AutoDeleteFromCartWhenHoldP | |laced. The system | |preference allows one to | |enable this feature for the | |staff interface, OPAC, or | |both. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #50 from Jonathan Druart <jonathan.druart@gmail.com> --- Patch application failed for attachment 197010 - Bug 36868: (follow-up) Fix staff interface code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197009|0 |1 is obsolete| | Attachment #197010|0 |1 is obsolete| | Attachment #197011|0 |1 is obsolete| | Attachment #197012|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #51 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201213&action=edit Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #52 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201214&action=edit Bug 36868: (follow-up) Fix staff interface code Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #53 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201215&action=edit Bug 36868: Add logic for OPAC 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the new AutoDeleteFromCartWhenHoldPlaced system preference 3. Turn it on for both staff and OPAC 4. From the staff interface put some items in your cart. 5. Place a hold on all of them. 6. Once the hold(s) have been successfully done those items should no longer be in your cart. 7. Put more items into your staff cart, place a hold on some of them but not all. 8. Only the items you have placed a hold on should be removed. 9. Go to the OPAC and put some items in your cart. 10. Place a hold on all of them, those items should now be deleted from the cart. 11. Place more items into your OPAC cart, place a hold on some of them but not all. 12. Only the items you have placed a hold on should be removed. 13. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'staff'. 14. Try steps 4-8 again. 15. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'opac'. 16. Try steps 9 -12 again. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #54 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201216&action=edit Bug 36868: (follow-up) Remove unused variable in opac-reserve.pl Patch from commit cb39473 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |blawlor@clamsnet.org CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #55 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 201215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201215 Bug 36868: Add logic for OPAC Review of attachment 201215: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36868&attachment=201215) ----------------------------------------------------------------- ::: opac/opac-reserve.pl @@ +313,4 @@
if ($reserve_id) { ++$reserve_cnt; push @successful_hold_ids, $reserve_id; + push @successful_holds, $biblioNum;
Coming back about Comment 32 So there is possible redundancy between the two variables. Are both the reserve_id and the biblioNum values needed for performance reasons? If not, that's a actual redundancy. If yes, the naming is confusing. Especially when in reserve/placerequest.pl we also create @successful_biblionumbers filled also with $biblionumber. And that file also has @successful_hold_ids filled with $reserve_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #56 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201929&action=edit Bug 36868: (follow-up) Fix variable names Patch from commit f891a5d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #57 from Brendan Lawlor <blawlor@clamsnet.org> --- This works as described. I'm only failing QA for a couple of minor issues. 1. In the staff interface it's possible for the Cart basketcount to display -1 To reproduce: 1. Enable AutoDeleteFromCartWhenHoldPlaced 2. Go to a bib record and add the bib to the cart 3. Click remove from cart 4. Place a hold on the item 5. See the cart shows (-1) This would happen in other scenarios when the cookie intranet_bib_list exists but is empty string and delSingleRecord() is called. Then arrayRecords = valCookie.split("/"); evaluates to [""] and pos = jQuery.inArray(biblionumber, arrayRecords); evaluates to -1 The fix should be in delSingleRecord() if pos === -1 just return out of the function: line 272: + if (pos === -1) { return; } The same bug exists in the opac, but it's not shown in the ui. It's silent because updateBasket checks if (updated_value > 0) I think it would still be good to update delSingleRecord in the same way for the opac because this could potentially lead to other bogs. The second issue is very minor. the atomic update is idempotent, but the output will always say "Added new system preference" It could be improved to warn when the system preference already exists like: if ($rows == 0) { say_warning( $out, "System preference 'AutoDeleteFromCartWhe nHoldPlaced' already exists" ); } else { say_success( $out, "Added new system preference 'AutoDeleteF romCartWhenHoldPlaced'" ); } }, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #58 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 202123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202123&action=edit Bug 36868: (follow-up) Fix deletion when nothing is in the cart, and make DB update better Patch from commit 7c0ba9c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #59 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 202396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202396&action=edit Bug 36868: (QA follow-up) Fix deletion off by one error When the biblionumber is not in the array -1 is returned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201213|0 |1 is obsolete| | Attachment #201214|0 |1 is obsolete| | Attachment #201215|0 |1 is obsolete| | Attachment #201216|0 |1 is obsolete| | Attachment #201929|0 |1 is obsolete| | Attachment #202123|0 |1 is obsolete| | Attachment #202396|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #60 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205227&action=edit Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #61 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205228&action=edit Bug 36868: (follow-up) Fix staff interface code Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #62 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205229&action=edit Bug 36868: Add logic for OPAC 1. APPLY PATCH, updatedatabase, restart_all 2. Search for the new AutoDeleteFromCartWhenHoldPlaced system preference 3. Turn it on for both staff and OPAC 4. From the staff interface put some items in your cart. 5. Place a hold on all of them. 6. Once the hold(s) have been successfully done those items should no longer be in your cart. 7. Put more items into your staff cart, place a hold on some of them but not all. 8. Only the items you have placed a hold on should be removed. 9. Go to the OPAC and put some items in your cart. 10. Place a hold on all of them, those items should now be deleted from the cart. 11. Place more items into your OPAC cart, place a hold on some of them but not all. 12. Only the items you have placed a hold on should be removed. 13. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'staff'. 14. Try steps 4-8 again. 15. Switch the AutoDeleteFromCartWhenHoldPlaced to only be for 'opac'. 16. Try steps 9 -12 again. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Sarah Fletcher <sfletcher@ncwlibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #63 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205230&action=edit Bug 36868: (follow-up) Remove unused variable in opac-reserve.pl Patch from commit 36fb6c4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #64 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205231&action=edit Bug 36868: (follow-up) Fix variable names Patch from commit 810f803 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #65 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205232&action=edit Bug 36868: (follow-up) Fix deletion when nothing is in the cart, and make DB update better Patch from commit f73bc63 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #66 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205233&action=edit Bug 36868: (QA follow-up) Fix deletion off by one error When the biblionumber is not in the array -1 is returned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #67 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi guys, 1) It appears opac_user_holds, opac_user_overdues, opac_user_article_requests template params are set but never used i.e. dead code in opac-user.pl. Can you please confirm? 2) The 'Fix deletion off by one error' commit applies the same change to both basket.js (OPAC + Staff) but the OPAC one does arrayRecords.splice before the check, whereas the Staff one does arrayRecords.splice after the check. Can you please confirm if this is intentional? Thanks in advance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #68 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
1) It appears opac_user_holds, opac_user_overdues, opac_user_article_requests template params are set but never used i.e. dead code in opac-user.pl. Can you please confirm?
Yes, removed by Bug 41558: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41558 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #69 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205330&action=edit Bug 36868: Remove dead code in opac-user.pl Patch from commit fe37a04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #70 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
2) The 'Fix deletion off by one error' commit applies the same change to both basket.js (OPAC + Staff) but the OPAC one does arrayRecords.splice before the check, whereas the Staff one does arrayRecords.splice after the check. Can you please confirm if this is intentional?
We want to splice the array after the check instead of mutating it before checking. It wasn't causing any bugs because of the return. I will follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #71 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205331&action=edit Bug 36868: Move array splice in OPAC js to after the -1 check Patch from commit 791c654 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #72 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #73 from Jonathan Druart <jonathan.druart@gmail.com> --- There are a couple of wrong things here: 1. xt/tt_kohaTable_tidy.t is failing 2. duplicated code: * hold_table_settings instanciated twice * Asset.js called twice on holds.js, hold-group.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #74 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205666&action=edit Bug 36868: (follow-up) fix failing tt_kohaTable_tidy.t test Patch from commit 5bf7569 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #75 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205667&action=edit Bug 36868: (follow-up) Remove double instanciated hold_table_settings Patch from commit 2f6e98d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #76 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205668&action=edit Bug 36868: (follow-up) Remove 2x call of holds.js, hold-group.js Patch from commit 543098a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #77 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #73)
There are a couple of wrong things here: 1. xt/tt_kohaTable_tidy.t is failing 2. duplicated code: * hold_table_settings instanciated twice * Asset.js called twice on holds.js, hold-group.js
Thanks, follow-ups provided. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org